DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Sujith Sankar <ssujith@cisco.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 4/7] VNIC common code
Date: Fri, 07 Nov 2014 16:51:24 +0100	[thread overview]
Message-ID: <3857314.dObtBBdJqR@xps13> (raw)
In-Reply-To: <1415390747-9532-5-git-send-email-ssujith@cisco.com>

2014-11-08 01:35, Sujith Sankar:
>  lib/librte_pmd_enic/src/cq_desc.h       |  122 ++++
>  lib/librte_pmd_enic/src/cq_enet_desc.h  |  257 ++++++++
>  lib/librte_pmd_enic/src/rq_enet_desc.h  |   72 +++
>  lib/librte_pmd_enic/src/vnic_cq.c       |  113 ++++
>  lib/librte_pmd_enic/src/vnic_cq.h       |  148 +++++
>  lib/librte_pmd_enic/src/vnic_dev.c      | 1077 +++++++++++++++++++++++++++++++
>  lib/librte_pmd_enic/src/vnic_dev.h      |  198 ++++++
>  lib/librte_pmd_enic/src/vnic_devcmd.h   |  770 ++++++++++++++++++++++
>  lib/librte_pmd_enic/src/vnic_enet.h     |   74 +++
>  lib/librte_pmd_enic/src/vnic_intr.c     |   79 +++
>  lib/librte_pmd_enic/src/vnic_intr.h     |  122 ++++
>  lib/librte_pmd_enic/src/vnic_nic.h      |   84 +++
>  lib/librte_pmd_enic/src/vnic_resource.h |   93 +++
>  lib/librte_pmd_enic/src/vnic_rq.c       |  242 +++++++
>  lib/librte_pmd_enic/src/vnic_rq.h       |  278 ++++++++
>  lib/librte_pmd_enic/src/vnic_rss.c      |   81 +++
>  lib/librte_pmd_enic/src/vnic_rss.h      |   57 ++
>  lib/librte_pmd_enic/src/vnic_stats.h    |   82 +++
>  lib/librte_pmd_enic/src/vnic_wq.c       |  241 +++++++
>  lib/librte_pmd_enic/src/vnic_wq.h       |  279 ++++++++
>  lib/librte_pmd_enic/src/wq_enet_desc.h  |  110 ++++
>  21 files changed, 4579 insertions(+)

What is the status of these files?
Are they copied from somewhere?
Please explain in the commit log.

Could you move them in a subdirectory vnic/ or base/?

Please could you remove the src/ subdirectory level?

Thanks
-- 
Thomas

  reply	other threads:[~2014-11-07 15:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-07 20:05 [dpdk-dev] [PATCH 0/7] Cisco Systems Inc. VIC Ethernet PMD - ENIC PMD Sujith Sankar
2014-11-07 11:09 ` Thomas Monjalon
2014-11-10  9:50   ` Sujith Sankar (ssujith)
2014-11-07 15:47 ` Thomas Monjalon
2014-11-07 15:56   ` Sujith Sankar (ssujith)
2014-11-10  9:27   ` Sujith Sankar (ssujith)
2014-11-07 20:05 ` [dpdk-dev] [PATCH 1/7] DPDK changes for accommodating " Sujith Sankar
2014-11-07 11:33   ` Neil Horman
2014-11-07 20:05 ` [dpdk-dev] [PATCH 2/7] ENIC PMD License Sujith Sankar
2014-11-07 11:30   ` Neil Horman
2014-11-07 20:05 ` [dpdk-dev] [PATCH 3/7] ENIC PMD Makefile Sujith Sankar
2014-11-07 11:34   ` Neil Horman
2014-11-07 15:46     ` Sujith Sankar (ssujith)
2014-11-10  9:59       ` Sujith Sankar (ssujith)
2014-11-07 20:05 ` [dpdk-dev] [PATCH 4/7] VNIC common code Sujith Sankar
2014-11-07 15:51   ` Thomas Monjalon [this message]
2014-11-10 10:16     ` Sujith Sankar (ssujith)
2014-11-07 20:05 ` [dpdk-dev] [PATCH 5/7] ENIC PMD specific code Sujith Sankar
2014-11-07 20:05 ` [dpdk-dev] [PATCH 6/7] DPDK-ENIC PMD interface Sujith Sankar
2014-11-07 20:05 ` [dpdk-dev] [PATCH 7/7] Release notes for ENIC PMD 1.0.0.3 Sujith Sankar
2014-11-07 12:20   ` Thomas Monjalon
2014-11-07 15:52     ` Sujith Sankar (ssujith)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3857314.dObtBBdJqR@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=ssujith@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).