From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18529A0A03; Mon, 18 Jan 2021 15:02:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 04B3B140EDA; Mon, 18 Jan 2021 15:02:57 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 513B1140EC5; Mon, 18 Jan 2021 15:02:54 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 900D515A9; Mon, 18 Jan 2021 09:02:52 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 18 Jan 2021 09:02:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= 9DUKt1a55mPCzZ8nU7n0XzhgGauxfDp/EteXR4YFPSM=; b=Vkr7qliiLl1LG8D8 qYruw+/iwtjnYLrD+E4XDy6OnshKvlDYuU7h1cQgQj8RPbvJlQ3LsR0+sN6M5DLb GiLoscC1AexWnsKu+m0OAolxZclDSmVZ8snf6PbGRY1tz1yq2UUbAXa4LGIDVX+p D0f2nJd1FemQ8OkW0wmAvbEMyJs7Cq1uzN0InKQYcZnFlfYUkBkqp2P/wA8eiCOb M3IDVRcqLVL+dIauA0VEFfj8K0HiYoIpLn/BXI7CN7kIM17CthLWoXlXkf2zL/CE GxUfiv4UEq0kjVDx0vf4+QjLLCui2pukio9qK5fVBjiSh3KA4RC9Y19xFBpOYH8q 9Un0dA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=9DUKt1a55mPCzZ8nU7n0XzhgGauxfDp/EteXR4YFP SM=; b=XCxdBnj+9G5ln3+vk7Nl63al/WFkgWPg737Uqee6NOOoPgEaAa1M1GZSK VztrZ//Oeo8LLKXfilp28vlZj4kV0Y26VDQrXIk5kSQp901+hWqCznpuZVEk99jt NKgyQFJ81A6mLkp4ueF61MV8srsE7N5k6fDilrlxZ76xvC3XN0dlzgZOhcdLN3Pp dE3TMUZ7LU7Yb/gRqQgw1eHAfIK9Thb1QoDdb+03keOzFdoao8J2YDPG1fK1EqbN F4C2d3Lm+P0+opOhnXWgg6y4FHw3kHo9AMQmVjKZogkmZwdrLub761CY2IxVBoJN /HOZ+c56+gcWsfRfsutfAoR3ixysA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrtdekgdehlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DD7491080063; Mon, 18 Jan 2021 09:02:50 -0500 (EST) From: Thomas Monjalon To: "Richardson, Bruce" Cc: "dev@dpdk.org" , "stable@dpdk.org" , "Yigit, Ferruh" , Andrew Rybchenko , "Wiles, Keith" , "Power, Ciara" Date: Mon, 18 Jan 2021 15:02:49 +0100 Message-ID: <38646937.bSsQRFMa1O@thomas> In-Reply-To: References: <20210114121733.46801-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: avoid blocking telemetry callback for link status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > >When querying the link status via telemetry interface, we don't want the > >client to have to wait for multiple seconds for a reply. Therefore use > >"rte_eth_link_get_nowait()" rather than "rte_eth_link_get()" in the telemetry > >callback. > > > >Cc: stable@dpdk.org > >Fixes: c190daedb9b1 ("ethdev: add telemetry callbacks") > > > >Signed-off-by: Bruce Richardson > >--- > >--- a/lib/librte_ethdev/rte_ethdev.c > >+++ b/lib/librte_ethdev/rte_ethdev.c > >@@ -5692,7 +5692,7 @@ eth_dev_handle_port_link_status(const char *cmd > >- ret = rte_eth_link_get(port_id, &link); > >+ ret = rte_eth_link_get_nowait(port_id, &link); > > This change looks good to me. > > Acked-by: Ciara Power Acked-by: Thomas Monjalon