From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id C533B1B130; Mon, 14 Jan 2019 19:49:39 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6D79928EDD; Mon, 14 Jan 2019 13:49:39 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 14 Jan 2019 13:49:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=//TajbtlommDyFwZhu9hmqUM6bEn4T7S8q8WxODaJwQ=; b=dBgrT9LIip5r iBLD9jb4MjhvFdYbpCEzfdfACUfSA06GRoRqCzQ4ZEbsncAqjHmGU8cq0sCWc1bS GAZk9bpT3Egyj98Y7HK1Lbp2oCoQHiRknrVIW6S6Y01RfAq+n4CcMDZm7h2gEIwO Fn/E1HBv4qwl2JDY/UYepOHyC6OGtfk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=//TajbtlommDyFwZhu9hmqUM6bEn4T7S8q8WxODaJ wQ=; b=KOwrppokvHB79SDPSXHmWsdEsWOf+UCXAJs16PK7y5nrYBPRDCh7fYXyA YCmf1IFD8rf0l7TAntZBXMNKOFZ8OGYJOt7VB5aJIanQR92U/1czEV+d8NFcU0Zh wpgxlY0TA6wK/wI480fP7Gf2b0QRGOactwspZCG11DK/63QS6djWsrg/f+FauAYK ikj7mLKQcM3eSitQz+bUO0txWRJREE/osdM02QwnZqRpqak8JAQuiLX3TfbbAusn 5rZlUpXXYY3A5YLP15VWusvAUhSIUWKnE+bogtFH8PS8yUsErPPPhRO2aZGA1yOZ EuMxBkNuyheR5SNk15NKsH45g6cFg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgedugdduudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B1ECDE4662; Mon, 14 Jan 2019 13:49:37 -0500 (EST) From: Thomas Monjalon To: Ilya Maximets Cc: stable@dpdk.org, dev@dpdk.org, Pavan Nikhilesh , honnappa.nagarahalli@arm.com Date: Mon, 14 Jan 2019 19:49:35 +0100 Message-ID: <3867865.yVi6bGp0KD@xps> In-Reply-To: <2566607.iMXo4xvV1S@xps> References: <20190114161442.8277-1-i.maximets@samsung.com> <2566607.iMXo4xvV1S@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix build of external apps with clang on armv8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 18:49:40 -0000 14/01/2019 17:27, Thomas Monjalon: > 14/01/2019 17:14, Ilya Maximets: > > In case DPDK built using GCC, RTE_TOOLCHAIN_CLANG is not defined. > > But 'rte_atomic.h' is a generic header that included to the > > external apps like OVS while building with DPDK. As a result, > > clang build of OVS fails on ARMv8 if DPDK built using gcc: > > > > include/generic/rte_atomic.h:215:9: error: > > implicit declaration of function '__atomic_exchange_2' > > is invalid in C99 > > include/generic/rte_atomic.h:494:9: error: > > implicit declaration of function '__atomic_exchange_4' > > is invalid in C99 > > include/generic/rte_atomic.h:772:9: error: > > implicit declaration of function '__atomic_exchange_8' > > is invalid in C99 > > > > We need to check for current compiler, not the compiler used for > > DPDK build. > > Right, API cannot rely on internal build system configuration. > > > Fixes: 7bdccb93078e ("eal: fix ARM build with clang") > > Cc: stable@dpdk.org > > > > Signed-off-by: Ilya Maximets > > Acked-by: Thomas Monjalon Applied (if armv8 typo), thanks