From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id E7F86B482 for ; Wed, 18 Feb 2015 10:57:55 +0100 (CET) Received: by mail-wi0-f180.google.com with SMTP id h11so897476wiw.1 for ; Wed, 18 Feb 2015 01:57:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Ej32PJX4x5DnwDvW03GX+4oLrTnlTxlPImwIIF0t8WM=; b=IP3rwTEQWmXGoUoLwivSa31kGOO7Pr1EYFXA0iJyceUQ//4RgGzHwxOSRxuISY+YUO yqy0DjCt5D2b8Ke6UfGpfuSn0pwqERLDSu1e6MtdkAh55vXWDhHNj2srDXceSihfxqB5 a5eflUf2nViWca47RuH68V8oDOy9dL2cfvZcnNBaOc7O20rvEZdBV2ytf+puIfQrCXFK g1rcuBXPvljv9u/HAJdFBHDdthwjHKjROK/2Zgm2LQCm5CmnwNOUTfTFkBek+kDUVoUY vlVxvGMlKDsOwjQ7AZrkv0N+oFMK1NMVbyJQz7LC5UAQk6rHONIGqeLmgqwFiOsWv05P pXLg== X-Gm-Message-State: ALoCoQnXsQXiNJzOx44UZBy4KStzWcsJXyxZx7h+3mR7TDP8ayIXI1Q2BXH91vlQZdJzU0QzQrCp X-Received: by 10.194.190.10 with SMTP id gm10mr7074706wjc.91.1424253475321; Wed, 18 Feb 2015 01:57:55 -0800 (PST) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id gi3sm28549425wic.15.2015.02.18.01.57.54 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Feb 2015 01:57:54 -0800 (PST) From: Thomas Monjalon To: Tetsuya Mukawa Date: Wed, 18 Feb 2015 10:57:25 +0100 Message-ID: <3870939.2syNine7YF@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <54E42CCD.6020900@igel.co.jp> References: <1423470639-15744-2-git-send-email-mukawa@igel.co.jp> <54E3F0F0.1030102@igel.co.jp> <54E42CCD.6020900@igel.co.jp> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Neil Horman Subject: Re: [dpdk-dev] [PATCH v8 03/14] eal/pci, ethdev: Remove assumption that port will not be detached X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 09:57:56 -0000 2015-02-18 15:10, Tetsuya Mukawa: > On 2015/02/18 10:54, Tetsuya Mukawa wrote: > > On 2015/02/18 9:31, Thomas Monjalon wrote: > >> 2015-02-17 15:14, Tetsuya Mukawa: > >>> On 2015/02/17 9:36, Thomas Monjalon wrote: > >>>> 2015-02-16 13:14, Tetsuya Mukawa: > >>>> Is uint8_t sill a good size for hotpluggable virtual device ids? > >>> I am not sure it's enough, but uint8_t is widely used in "rte_ethdev.c" > >>> as port id. > >>> If someone reports it doesn't enough, I guess it will be the time to > >>> write a patch to change all uint_8 in one patch. > >> It's a big ABI breakage. So if we feel it's going to be required, > >> it's better to do it now in 2.0 release I think. > >> > >> Any opinion? > >> > > Hi Thomas, > > > > I agree with it. > > I will add an one more patch to change uint8_t to uint16_t. > > > > Thanks, > > Tetsuya > > > > Hi Thomas, > > Could I make sure. > After changing uint8_t to uint16_t in "rte_ethdev.[ch]", must I also > need to change other applications and libraries that call ethdev APIs? > If so, I would not finish it by 23rd. > > I've counted how many lines call ethdev APIs that are related to port_id. > Could you please check an attached file? > It's over 1200 lines. Probably to fix one of caller, I will need to > check how port_id is used, and fix more related lines. So probably > thousands lines may need to be fixed. > > When is deadline for fixing this changing? > Also, if you have a good idea to fix it easier, could you please let me > know? It was an open question. If everybody is fine with 255 ports maximum, let's keep it as is.