From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com
 [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 1540D231C
 for <dev@dpdk.org>; Thu, 27 Nov 2014 21:24:52 +0100 (CET)
Received: by mail-wi0-f169.google.com with SMTP id r20so19298752wiv.2
 for <dev@dpdk.org>; Thu, 27 Nov 2014 12:24:51 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=0cpu+5EDLkr5a63DFUjV4ohl7LsLv6KDG4aRsyhDB4A=;
 b=ZR9f9sO51Cz/iVWx+x7kDLoKyuDhICEQEqLy6TQqV+LfBB6RQsV1ZK50pYHJCY8ee+
 TTJVXaMFBQICgtZN6Bp5Woo/pVYYGZG+iZg5Zyikp1kJmZKQfUzeLuKlYC9FntrzgMOx
 EzsByLJMEN+WJnUhWPfjF+N6NoceGVoX7WWrlc+/sUVXPbMmLPFPjRI8E5RoAGBLJEBX
 ZtUXERpwqWHnGnk+r+1ZAiNMcA7bhmYE80IVoOoE4ftEVC4qxRZ96e6yYBJwmZm0oYuz
 zx3cuRt6ZNgxamPUUroSG0kQtJGbVA8cs7sWfcXJlHcBSgFEkTdgdbR2nOcabQPR+RWE
 vTbQ==
X-Gm-Message-State: ALoCoQlhhZFKnYHLtIocp1ixLbcK8dPDgvvFvX3DocCeiq33LlLCtAHxuWoWY91KHRpzx5kJxCVy
X-Received: by 10.194.103.232 with SMTP id fz8mr62938908wjb.110.1417119891893; 
 Thu, 27 Nov 2014 12:24:51 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id 4sm12138077wjs.24.2014.11.27.12.24.50
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 27 Nov 2014 12:24:51 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Sujith Sankar <ssujith@cisco.com>
Date: Thu, 27 Nov 2014 21:24:28 +0100
Message-ID: <3873403.PSCWCNKvtK@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; )
In-Reply-To: <2232586.GRrg2Bq1yj@xps13>
References: <1417108480-28341-1-git-send-email-ssujith@cisco.com>
 <2232586.GRrg2Bq1yj@xps13>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] enicpmd: compilation error during inclusion
	of vfio.h
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Nov 2014 20:24:52 -0000

2014-11-27 19:01, Thomas Monjalon:
> 2014-11-27 22:44, Sujith Sankar:
> > Inclusion of vfio.h was giving compilation errors if kernel version is less
> > than 3.6.0 and if RTE_EAL_VFIO was on in config.
> > 
> > Replaced inclusion of vfio.h with eal_vfio.h and replaced RTE_EAL_VFIO with
> > VFIO_PRESENT in enicpmd code.
> 
> You should add
> Reported-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
> 
> > Signed-off-by: Sujith Sankar <ssujith@cisco.com>
> [...]
> >  CFLAGS += -I$(RTE_SDK)/lib/librte_hash/ -I$(RTE_SDK)/lib/librte_pmd_enic/vnic/
> >  CFLAGS += -I$(RTE_SDK)/lib/librte_pmd_enic/
> > +CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linuxapp/eal/
> >  CFLAGS += -O3 -Wno-deprecated
> 
> I think -I$(RTE_SDK)/lib/librte_hash/ and -I$(RTE_SDK)/lib/librte_eal/linuxapp/eal/
> are not needed.
> 
> I'll fix it if you confirm.

Applied with above comments.

-- 
Thomas