From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 07AFC9E4; Mon, 18 Jun 2018 12:01:43 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jun 2018 03:01:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,238,1526367600"; d="scan'208";a="65025355" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.252.30.40]) ([10.252.30.40]) by fmsmga001.fm.intel.com with ESMTP; 18 Jun 2018 03:01:41 -0700 To: Dariusz Stojaczyk , dev@dpdk.org Cc: olivier.matz@6wind.com, stable@dpdk.org References: <1528461427-164113-1-git-send-email-dariuszx.stojaczyk@intel.com> <1528461427-164113-2-git-send-email-dariuszx.stojaczyk@intel.com> From: "Burakov, Anatoly" Message-ID: <387954ec-779e-6f29-5966-f8d2a41945e1@intel.com> Date: Mon, 18 Jun 2018 11:01:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1528461427-164113-2-git-send-email-dariuszx.stojaczyk@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] eal/thread: fix return codes for rte_ctrl_thread_create() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2018 10:01:44 -0000 On 08-Jun-18 1:37 PM, Dariusz Stojaczyk wrote: > This function returned positive error numbers instead > of negative ones as desbribed in the doc. What's worse, > multiple of its callers only check for (rc < 0) to detect > failure. > > It was incorrectly assumed that pthread_create > and pthread_setaffinity_np return negative errnos. They > always returns positive ones, so this patch negates their > return values before returning. > > Fixes: 9e5afc72c909 ("eal: add function to create control threads") > Cc: olivier.matz@6wind.com > Cc: stable@dpdk.org > > Signed-off-by: Dariusz Stojaczyk > --- Acked-by: Anatoly Burakov -- Thanks, Anatoly