From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20BB2A09D3; Thu, 12 Nov 2020 15:39:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3668D5928; Thu, 12 Nov 2020 15:39:35 +0100 (CET) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 433564CA6 for ; Thu, 12 Nov 2020 15:39:33 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id A32B45810B7; Thu, 12 Nov 2020 09:39:31 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 12 Nov 2020 09:39:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= x1BGbctjjpc/Od3DIrjBLmAlJz5OUhVYzZ6dwmd7PYk=; b=ucgWHbN1Apr05xTt CW7uW2wW64e4WSk0oOLv1upxHBYjHv6KJ4lY7EunNV1b/dXY9cu6gAhl53BmUf5p 3b5O0HjyZr2XcKLfAhHB0FJbGCG9oPmo3s/tfHA6EAoL6MpG3bkxJKPg9anLbpyg uOewGlC+00uu8dL9Osi1tsxMRk9lw3juyHcz7N4YQwhr3EFWFyYvRPqj1h2v4BYH Z6j7BafjgHCLWKht5b974SdwMSc/uVZFwnnwEz0DAzkE664UYnf82zK+W0ko06n+ l+n+f+V/xIE6VTyTEVRbaYQb4pLdL9+tno5y50kRnoQp6jQ7snt2lAtoBchSHzvv HBFSwg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=x1BGbctjjpc/Od3DIrjBLmAlJz5OUhVYzZ6dwmd7P Yk=; b=XMYnoYYIRZhbi+vBbD69MTsOuMq5QJQdSZWwDQaCD9yoIGGbPabaonuab z9VTV6jQXNVf+8v/KhAnXoogvRKyJpx5N/nVd8/JihJLkqy9FawkvTTmIgt9NQAg PUILAoKHXQX0PExa8wllIP4OgHsJUANFCDdbqJ8RMTvs/YdApLrwa9B53xFydxGE Tg9V53heL1fcTgU5RiwVsKR+SXBtohiyrP3Lp03YtCsF4LiQ4CjfraZQPxjBCYIk QYSac36HJm5Bi1uagm3EC/hjXsSZgZMwNLSV/ZJvVd2HeXUCUUiIQMORfzme06al rK2QiGoK3rxrhNhAiAniwWq00/iRg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddvfedggeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrd dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AD0FA328005D; Thu, 12 Nov 2020 09:39:28 -0500 (EST) From: Thomas Monjalon To: dev@dpdk.org Cc: Olivier Matz , David Marchand , Ferruh Yigit , Morten =?ISO-8859-1?Q?Br=F8rup?= , "Ananyev, Konstantin" , Andrew Rybchenko , Viacheslav Ovsiienko , Ajit Khaparde , Jerin Jacob , Hemant Agrawal , Ray Kinsella , Neil Horman , Jerin Jacob Date: Thu, 12 Nov 2020 15:39:27 +0100 Message-ID: <3880040.cf593ZQX9F@thomas> In-Reply-To: References: <20201107155306.463148-1-thomas@monjalon.net> <20201110162509.GN1898@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 2/2] mbuf: move pool pointer in first half X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > According to the Technical Board decision > > > (http://mails.dpdk.org/archives/dev/2020-November/191859.html), > > > the mempool pointer in the mbuf struct is moved > > > from the second to the first half. > > > It may increase performance in some cases > > > on systems having 64-byte cache line, i.e. mbuf split in two cache lines. > > > > > > Due to this change, tx_offload is moved. > > > Hopefully no vector data path is impacted. > > > > > > Moving this field gives more space to dynfield1 > > > while dropping the temporary dynfield0. > > > > > > This is how the mbuf layout looks like (pahole-style): > > > > > > word type name byte size > > > 0 void * buf_addr; /* 0 + 8 */ > > > 1 rte_iova_t buf_iova /* 8 + 8 */ > > > /* --- RTE_MARKER64 rearm_data; */ > > > 2 uint16_t data_off; /* 16 + 2 */ > > > uint16_t refcnt; /* 18 + 2 */ > > > uint16_t nb_segs; /* 20 + 2 */ > > > uint16_t port; /* 22 + 2 */ > > > 3 uint64_t ol_flags; /* 24 + 8 */ > > > /* --- RTE_MARKER rx_descriptor_fields1; */ > > > 4 uint32_t union packet_type; /* 32 + 4 */ > > > uint32_t pkt_len; /* 36 + 4 */ > > > 5 uint16_t data_len; /* 40 + 2 */ > > > uint16_t vlan_tci; /* 42 + 2 */ > > > 5.5 uint64_t union hash; /* 44 + 8 */ > > > 6.5 uint16_t vlan_tci_outer; /* 52 + 2 */ > > > uint16_t buf_len; /* 54 + 2 */ > > > 7 struct rte_mempool * pool; /* 56 + 8 */ > > > /* --- RTE_MARKER cacheline1; */ > > > 8 struct rte_mbuf * next; /* 64 + 8 */ > > > 9 uint64_t union tx_offload; /* 72 + 8 */ > > > 10 struct rte_mbuf_ext_shared_info * shinfo; /* 80 + 8 */ > > > 11 uint16_t priv_size; /* 88 + 2 */ > > > uint16_t timesync; /* 90 + 2 */ > > > 11.5 uint32_t dynfield1[9]; /* 92 + 36 */ > > > 16 /* --- END 128 */ > > > > > > Signed-off-by: Thomas Monjalon > > > > Acked-by: Olivier Matz > > Acked-by: Jerin Jacob Series applied