From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Shelton Chia <jiaxt@sinogrid.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] librte_pmd_e1000: power down the serdes link
Date: Mon, 30 Mar 2015 22:30:22 +0200
Message-ID: <3880400.EaJEZrUXi7@xps13> (raw)
In-Reply-To: <1425700658-12077-1-git-send-email-jiaxt@sinogrid.com>
2015-03-07 11:57, Shelton Chia:
> Signed-off-by: Shelton Chia <jiaxt@sinogrid.com>
> ---
> lib/librte_pmd_e1000/igb_ethdev.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_pmd_e1000/igb_ethdev.c b/lib/librte_pmd_e1000/igb_ethdev.c
> index 504ae74..314ef2a 100644
> --- a/lib/librte_pmd_e1000/igb_ethdev.c
> +++ b/lib/librte_pmd_e1000/igb_ethdev.c
> @@ -948,7 +948,10 @@ eth_igb_stop(struct rte_eth_dev *dev)
> }
>
> /* Power down the phy. Needed to make the link go Down */
> - e1000_power_down_phy(hw);
> + if (hw->phy.media_type == e1000_media_type_copper)
> + e1000_power_down_phy(hw);
> + else
> + e1000_shutdown_fiber_serdes_link(hw);
>
> igb_dev_clear_queues(dev);
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Applied, thanks
prev parent reply other threads:[~2015-03-30 20:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-07 3:57 Shelton Chia
2015-03-23 11:40 ` Thomas Monjalon
2015-03-30 20:30 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3880400.EaJEZrUXi7@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=jiaxt@sinogrid.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
DPDK patches and discussions
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
dev@dpdk.org
public-inbox-index dev
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://inbox.dpdk.org/inbox.dpdk.dev
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git