From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53CD543BC0; Sat, 24 Feb 2024 12:18:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43896402C8; Sat, 24 Feb 2024 12:18:34 +0100 (CET) Received: from fout5-smtp.messagingengine.com (fout5-smtp.messagingengine.com [103.168.172.148]) by mails.dpdk.org (Postfix) with ESMTP id 898A3402A8 for ; Sat, 24 Feb 2024 12:18:32 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.nyi.internal (Postfix) with ESMTP id 20D2713800C5; Sat, 24 Feb 2024 06:18:32 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 24 Feb 2024 06:18:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1708773512; x=1708859912; bh=KM9D023nz3z05YdbT8AiS5V7OQR0dJTJgwFYd3NiJCc=; b= q39jel19fFBtbLDAwKnb5vGZRtOZ0VGaKqsWBIv3uFWLwuZ5u91Luu4GpauURxGF EM2voovhodXe4NPdd0YeSAtA3o4mTLxz84sP4OYGE5OLBKpQKR7P/HMxRKureS7S FH44PwW2VItFnwNYaGRd8PyxKGgnu0rqI8mtePnx8BF8mZLq2MsGmb/c8Sap/3JN +GypLEG0Cwnef0O8tCKF5cwsEWh6+lqV+4ziC12ShyQKTfkmN11j3S0ppns3dHS/ jggXTaWePrTEsAIf537onz68S18X0S4jleNWGK21u6O+h9OD4vyQVHXyGlMNysEW rnxXP6xQCIju6FjpeMfNvA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708773512; x= 1708859912; bh=KM9D023nz3z05YdbT8AiS5V7OQR0dJTJgwFYd3NiJCc=; b=C DpCqm9RYAL9z3I2esL5mM2qDOg29Ii0RNuR/t4Y/oC/lMT5qcaHMQyxxCJp2TMzl kma5bXtu5QJgU5Q10wMl97VSp579xMzI1Bx2nyqk6J7DZR46Fdow64OPIeXeN+jd O9nh9/kGjJgk+rytMLQNzj3sk6DiDxN8AQl5klyYVQ7ZPJddhWmVzdkne/P12Qe4 AnsYX9W+XuG9qgQzDj7vmxf1shHQ1QGQ5vq+D4JmXCb1MVViBxTHl/YyxrIk3Uc8 WdsUZWPgYP1tS8mja4i+3iKy46jNIYzsBN9KPQxLZhlusr1VZa902AWbyn5UrqCX K7ogkvUT0y7GGC6IWsVig== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeekgddviecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 24 Feb 2024 06:18:25 -0500 (EST) From: Thomas Monjalon To: Tyler Retzlaff Cc: dev@dpdk.org, Ajit Khaparde , Andrew Boyer , Andrew Rybchenko , Bruce Richardson , Chenbo Xia , Chengwen Feng , Dariusz Sosnowski , David Christensen , Hyong Youb Kim , Jerin Jacob , Jie Hai , Jingjing Wu , John Daley , Kevin Laatz , Kiran Kumar K , Konstantin Ananyev , Maciej Czekaj , Matan Azrad , Maxime Coquelin , Nithin Dabilpuram , Ori Kam , Ruifeng Wang , Satha Rao , Somnath Kotur , Suanming Mou , Sunil Kumar Kori , Viacheslav Ovsiienko , Yisen Zhuang , Yuying Zhang , mb@smartsharesystems.com Subject: Re: [PATCH v5 01/22] eal: provide macro to expand marker extensions Date: Sat, 24 Feb 2024 12:18:23 +0100 Message-ID: <38839087.10thIPus4b@thomas> In-Reply-To: <1803928.TLkxdtWsSY@thomas> References: <1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com> <1708762927-14126-2-git-send-email-roretzla@linux.microsoft.com> <1803928.TLkxdtWsSY@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 24/02/2024 11:51, Thomas Monjalon: > 24/02/2024 09:21, Tyler Retzlaff: > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Provide a > > new macro __rte_marker(type, name) that may be used to expand RTE_MARKER > > empty in struct definitions when building with MSVC. > > I don't think we need to define a new marker macro. > I propose to simply not define them with MSVC, triggering a compilation error. > So we keep the old markers for applications which were not using MSVC anyway. > And inside DPDK libraries and drivers, we remove their usages. One more thing to fix: When padding is done on the marker, example: RTE_MARKER cacheline1 __rte_cache_min_aligned; We need to move alignment on the first real field, while keeping compatibility with the marker. I'm afraid we need to have alignment done only once. It may be difficult without using #ifdef inside the struct. It's probably easier to replace alignment with explicit padding.