From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
dev@dpdk.org, stable@dpdk.org,
Bruce Richardson <bruce.richardson@intel.com>,
Ferruh Yigit <ferruh.yigit@xilinx.com>
Subject: Re: [PATCH] build: enable developer mode for all working trees
Date: Mon, 29 Aug 2022 12:47:05 +0200 [thread overview]
Message-ID: <3885173.ZaRXLXkqSa@thomas> (raw)
In-Reply-To: <0da8815a-9d50-6a58-cd3b-eeb1104cfd39@xilinx.com>
16/08/2022 10:51, Ferruh Yigit:
> On 8/10/2022 8:26 PM, Stephen Hemminger wrote:
> > On Wed, 10 Aug 2022 20:40:58 +0300
> > Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
> >
> >> Developer mode was detected if `.git` was a directory.
> >> Linked git working trees created by `git worktree add`
> >> contain `.git` file instead of `.git` directory.
> >> Developer mode was not detected for such directories.
> >> Detect developer mode by the presence of `.git` path.
> >>
> >> Fixes: bc4617433845 ("build: enable a developer mode setting")
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
Good catch!
I am a user of the "git worktree" feature, it is very convenient
to do some parallel work and not mess recompilation.
Applied, thanks.
prev parent reply other threads:[~2022-08-29 10:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 17:40 Dmitry Kozlyuk
2022-08-10 19:26 ` Stephen Hemminger
2022-08-16 8:51 ` Ferruh Yigit
2022-08-29 10:47 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3885173.ZaRXLXkqSa@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=ferruh.yigit@xilinx.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).