From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E9D8A0544; Mon, 29 Aug 2022 12:47:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2EF9A4069D; Mon, 29 Aug 2022 12:47:09 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 025F74003C; Mon, 29 Aug 2022 12:47:07 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B0D045C00A9; Mon, 29 Aug 2022 06:47:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 29 Aug 2022 06:47:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1661770027; x= 1661856427; bh=/4fqIU2w1Dwv06CwrQpKKkx9lt8wwAgXbiP/CUJf4R0=; b=N jzd+klutJ3ZyHVKiTeF+uS3hkO9pr/fOY3b7OqK4TrmqLVH+3W3TsUx/5Drz7Gl3 IDes1qyhdvy8V7OuREu9CJDR2HIDH1Vozz+knv7zmu4ZM8hQKkarYYmVUU14SjBT hh2L1eXlwv4fkCFojRj5YQdcq97l8/iwAfJYuwO88918KNF8t7z46CTiORX1POPb GSF9hT6/LTKBonBdAybwMeZrvpL09AysD9XuUOoxdvGpp7SiknEqJ+Wlpvxpe2sa 1sWH8YtFOcpGaZpRvxzMKE302PeNb/nRonKMcdqxWv1USFNfBE4UgdYk9+CSZfFP jYEUUybzD5xveJTp8vtgQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1661770027; x= 1661856427; bh=/4fqIU2w1Dwv06CwrQpKKkx9lt8wwAgXbiP/CUJf4R0=; b=G 1iINHfOIkioD1HuLmcgMJNE8WW6Jq4SnYasdLkaF2dhInkHQk9CKqQSFL2HT1D6G SxyJXVKemwpmY2QBKWw0YPPb44pS528csYwaKfmGFat/5reuzoLW9RpAvSiUZg33 ugWh9AAFnQmfCZ/q/DrAjd8Tv77XGu579OY14Nc43fXf+Mm1xptUK6hzLS1hB1dC ODU3Ff3FbTycZ1P7cyqvzlbZUgR6PaxJUQx2v9qMKHDR0HpNGt06aIvDxkncUizF EDJkJBjIO1KJtvuwc7IFHfdeOA1BYcKEuDdvo8d77hMbEXEBla28kgfA6V4/tssP HBNylNz7E1YBiQMsDOhWg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdekuddgfeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 29 Aug 2022 06:47:06 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: Stephen Hemminger , dev@dpdk.org, stable@dpdk.org, Bruce Richardson , Ferruh Yigit Subject: Re: [PATCH] build: enable developer mode for all working trees Date: Mon, 29 Aug 2022 12:47:05 +0200 Message-ID: <3885173.ZaRXLXkqSa@thomas> In-Reply-To: <0da8815a-9d50-6a58-cd3b-eeb1104cfd39@xilinx.com> References: <20220810174058.604568-1-dmitry.kozliuk@gmail.com> <20220810122606.645eb085@hermes.local> <0da8815a-9d50-6a58-cd3b-eeb1104cfd39@xilinx.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/08/2022 10:51, Ferruh Yigit: > On 8/10/2022 8:26 PM, Stephen Hemminger wrote: > > On Wed, 10 Aug 2022 20:40:58 +0300 > > Dmitry Kozlyuk wrote: > > > >> Developer mode was detected if `.git` was a directory. > >> Linked git working trees created by `git worktree add` > >> contain `.git` file instead of `.git` directory. > >> Developer mode was not detected for such directories. > >> Detect developer mode by the presence of `.git` path. > >> > >> Fixes: bc4617433845 ("build: enable a developer mode setting") > >> Cc: stable@dpdk.org > >> > >> Signed-off-by: Dmitry Kozlyuk > > Acked-by: Stephen Hemminger > Acked-by: Ferruh Yigit Good catch! I am a user of the "git worktree" feature, it is very convenient to do some parallel work and not mess recompilation. Applied, thanks.