From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id DF61FC44E for ; Tue, 28 Jul 2015 18:06:42 +0200 (CEST) Received: by wibud3 with SMTP id ud3so166480540wib.0 for ; Tue, 28 Jul 2015 09:06:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=WiJRWqx6T1reX9/2fTv2T0dTMlcJWjxsyKM1stHrubQ=; b=Qzv79Wu8LyRpiJ2FRtrd5wB2rV4T3+S+H9cpF8m/FuYab+hBBGKl4yRu7eGKNSS25t T8f8DhWDbtlqSOzOecm6yPIoL0uRhhiCIFY9TspUcRPatNFYXzcc8XBgcdtORSJNqEpO MZ8ZET3lCY1X4gL4ycyDX6WY+8YDsiwNv9ENijyq1MUjzDj3nKlHQoewlOHMFcDnj36R hAYNyfvN7tdjMsSB1ThaDI/2xPceTIK5QNx/3wTfUQuaRrJxibN1EkVbfm2/SdEXnEaW Gl6mhG090JbN/iXiTuAkMEw5CN5SX1VSgTKh57rA8aoIMbgQxmhaNUaKLZs3dFER11kI QBLw== X-Gm-Message-State: ALoCoQmFQPwn0E1QLt1S/QM8GhpI4ze1qGeWiQzZcyQTw1Gs5TG6THtlO+RJl5ynRAbQuzFZltkz X-Received: by 10.194.109.167 with SMTP id ht7mr65694704wjb.60.1438099602632; Tue, 28 Jul 2015 09:06:42 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.151.210]) by smtp.gmail.com with ESMTPSA id yu4sm13757386wjc.43.2015.07.28.09.06.41 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Jul 2015 09:06:42 -0700 (PDT) From: Thomas Monjalon To: Vladimir Medvedkin Date: Tue, 28 Jul 2015 18:05:26 +0200 Message-ID: <3885263.OLndnQdN2M@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <1438088792-16344-1-git-send-email-medvedkinv@gmail.com> <1831659.nSDl63dTav@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] Make the thash library arch-independent X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2015 16:06:43 -0000 2015-07-28 18:33, Vladimir Medvedkin: > 2015-07-28 16:47 GMT+03:00 Thomas Monjalon : > > 2015-07-28 09:06, Vladimir Medvedkin: > > Please explain how it was broken and how you fixed it. > > It would be interesting to know which part is __SSE3__ and __SSE__. > > > As mentioned in http://dpdk.org/ml/archives/dev/2015-July/022020.html > compilation fails on non x86 architectures( in that case it was tile). So I > add for optimized code, which uses SSE3 intrinsics, non optimized general > version. I know. I was requesting an updated commit with explanations: build is broken because... x86 version uses SSE3... Some code is enclosed with __SSE__, not __SSE3__ because... What happens if it is built with SSE3 support but run on a CPU without such support? Please check how it is done for ACL. > > > +#ifdef __SSE3__ > > > +#include > > > +#endif /* __SSE3__ */ > > > > Comments after short ifdef block are not needed. > > > Should I delete it? Yes please. > > > +#ifndef XMM_SIZE > > > +#define XMM_SIZE 16 > > > > Why is it needed? > > > because there is no defines for XMM_SIZE on non X86 architectures Why XMM_SIZE is needed on non x86 arch?