From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 4A6541B3E0; Thu, 4 Apr 2019 19:51:30 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B980821D1F; Thu, 4 Apr 2019 13:51:29 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 04 Apr 2019 13:51:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=SKwxTglOv7gT1AfzAuGFyfWhzCKWxCv5SAuD9nbZFHE=; b=l0wG6QQgDKLM liPqnDVmA8SDt/PE+nnd+QilNKwL5GPhCuoeFjFVssVx5sIiLafnoPqFlhSQVcF2 7pdDW9fHjPMtWAq/KvPHX3NmzUugtjNFfLyaMz/ChTmKt2qPCFSge6yuswaYtOKp mIkkDX+RRiAd9U7eaybx3BfuVHdrGvk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=SKwxTglOv7gT1AfzAuGFyfWhzCKWxCv5SAuD9nbZF HE=; b=tQv812Eqp8Yc4LS9Ytvfy1hBza+hp3rriIm/MbVZfF6Ghjdsc1Yp/Abrq /MyuCAuz1JmUOH5YEx/Q4WCeNMUqmtUGNUPerrsS0LSQOpxnBA7kVzrNirkSHMqm 7rtj45j1a9R7oIM7lQVK8c9RVcR2g9HiSHCURjgW6uHJTO3z9X+Y9BKMJPbNiTM0 Tqrqr0NKqvBOwWjFV1W91s3hd8RUGnV9SuPer47u1gxWy2Ubdr6jPB3i1StV2kwN tEAJ+mdBZobyZRDDQGlPhSwOe5/79CqKk3KlnVzJG3x0pA5Qs6RuMnfYmkjEadah /uxh0YEahfK770G89ffDcOrU/HwTA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtdehgdduudeiucdltddurdeguddtrddttd dmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfhgggfgtsehtufertddttddv necuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjh grlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghm pehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhush htvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3375DE456D; Thu, 4 Apr 2019 13:51:28 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, anatoly.burakov@intel.com, stable@dpdk.org Date: Thu, 04 Apr 2019 19:51:26 +0200 Message-ID: <38862193.gjzVnSvd9M@xps> In-Reply-To: <20190403160226.GA1340@bricha3-MOBL.ger.corp.intel.com> References: <20190403160034.31176-1-bruce.richardson@intel.com> <20190403160226.GA1340@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: tighten permissions on shared memory files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Apr 2019 17:51:30 -0000 03/04/2019 18:02, Bruce Richardson: > Adding stable@dpdk.org since this is suitable for backporting > > On Wed, Apr 03, 2019 at 05:00:34PM +0100, Bruce Richardson wrote: > > When creating files on disk, e.g. for EAL configuration or shared memory > > locks, etc., there is no need to grant any permissions on those files to > > other users. All directories are already created with 0700 permissions, so > > we should create all files with 0600 permissions. > > > CC: stable@dpdk.org > > Signed-off-by: Bruce Richardson It means the primary and secondary processes must have the same owner. Is it worth to document it? I feel the mask could be an EAL option. Anyway the directories have already a fixed tight mask, so Applied, thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 33FEBA0679 for ; Thu, 4 Apr 2019 19:51:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 84E7C1B44F; Thu, 4 Apr 2019 19:51:32 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 4A6541B3E0; Thu, 4 Apr 2019 19:51:30 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B980821D1F; Thu, 4 Apr 2019 13:51:29 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 04 Apr 2019 13:51:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=SKwxTglOv7gT1AfzAuGFyfWhzCKWxCv5SAuD9nbZFHE=; b=l0wG6QQgDKLM liPqnDVmA8SDt/PE+nnd+QilNKwL5GPhCuoeFjFVssVx5sIiLafnoPqFlhSQVcF2 7pdDW9fHjPMtWAq/KvPHX3NmzUugtjNFfLyaMz/ChTmKt2qPCFSge6yuswaYtOKp mIkkDX+RRiAd9U7eaybx3BfuVHdrGvk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=SKwxTglOv7gT1AfzAuGFyfWhzCKWxCv5SAuD9nbZF HE=; b=tQv812Eqp8Yc4LS9Ytvfy1hBza+hp3rriIm/MbVZfF6Ghjdsc1Yp/Abrq /MyuCAuz1JmUOH5YEx/Q4WCeNMUqmtUGNUPerrsS0LSQOpxnBA7kVzrNirkSHMqm 7rtj45j1a9R7oIM7lQVK8c9RVcR2g9HiSHCURjgW6uHJTO3z9X+Y9BKMJPbNiTM0 Tqrqr0NKqvBOwWjFV1W91s3hd8RUGnV9SuPer47u1gxWy2Ubdr6jPB3i1StV2kwN tEAJ+mdBZobyZRDDQGlPhSwOe5/79CqKk3KlnVzJG3x0pA5Qs6RuMnfYmkjEadah /uxh0YEahfK770G89ffDcOrU/HwTA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtdehgdduudeiucdltddurdeguddtrddttd dmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfhgggfgtsehtufertddttddv necuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjh grlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghm pehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhush htvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3375DE456D; Thu, 4 Apr 2019 13:51:28 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, anatoly.burakov@intel.com, stable@dpdk.org Date: Thu, 04 Apr 2019 19:51:26 +0200 Message-ID: <38862193.gjzVnSvd9M@xps> In-Reply-To: <20190403160226.GA1340@bricha3-MOBL.ger.corp.intel.com> References: <20190403160034.31176-1-bruce.richardson@intel.com> <20190403160226.GA1340@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal: tighten permissions on shared memory files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190404175126.AYwDx6-K_U_rtjgq4tJ81hkdKuxj-J3lbEB-hotf9gA@z> 03/04/2019 18:02, Bruce Richardson: > Adding stable@dpdk.org since this is suitable for backporting > > On Wed, Apr 03, 2019 at 05:00:34PM +0100, Bruce Richardson wrote: > > When creating files on disk, e.g. for EAL configuration or shared memory > > locks, etc., there is no need to grant any permissions on those files to > > other users. All directories are already created with 0700 permissions, so > > we should create all files with 0600 permissions. > > > CC: stable@dpdk.org > > Signed-off-by: Bruce Richardson It means the primary and secondary processes must have the same owner. Is it worth to document it? I feel the mask could be an EAL option. Anyway the directories have already a fixed tight mask, so Applied, thanks