From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DAD49A0093; Mon, 18 May 2020 11:22:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A6D321D51E; Mon, 18 May 2020 11:22:20 +0200 (CEST) Received: from wnew1-smtp.messagingengine.com (wnew1-smtp.messagingengine.com [64.147.123.26]) by dpdk.org (Postfix) with ESMTP id 3A2C51D508; Mon, 18 May 2020 11:22:19 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.west.internal (Postfix) with ESMTP id 466DBBDC; Mon, 18 May 2020 05:22:17 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 18 May 2020 05:22:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 5C66cSASQLE0JCWwdperKwqfKHbJ1xWfmr9afB2XkxE=; b=d1bYCLXobr6wiPRT jmArlobenrfvWLn67E4a83KLB+L3woKv/TuIpQTwQWVq0i1OsUxhHABL7vrz1SSV hfSuhKVZAhl2pXVYlqtrssNV99WcfKh7SXyGaUYkwtAwrQH83VT731j5n45M8HfS kLr+qTgOnd07M6t7OYKH5Tu7yfzSHlzAwB6dLb89cdIcw9HbIuv9Z7ytbm0F7K+O k/33dlEMm1pcen0HoT0AqoroagHTHFSbFOFb2rJymE5EGLZ5FMqVa+Ipu+6CQCCA oPhih2a2BToHeWq1PTQX013YE+k8ZkUJ9/MYcDpCzJ6hu4R8SoRNNY2DZEK2x1A6 /1GTPA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=5C66cSASQLE0JCWwdperKwqfKHbJ1xWfmr9afB2Xk xE=; b=jxqhmtfU9PRaRINCacBAnbk2ElB/PCUJbrrkXkXE2pPQ/rzw28AY2ayGN X0wZrvXqdvqOkz9a4he15ofRBU+GsmwBCIAhNpFRVvg0aWaUQokTMqwWtlhEMaSl ccpdhy7x+74ubNgah5gFwPIqlkXneYej/rtHsBW+UJx04mlMh324bBvWCoyRfNJv 2IX4EXM+0Qk5xPVhTCzJuHetPFSmosSEm6Bb6Wbn7Y3Ja+Gu4AC16/7J8ilYqzZ/ 96yCjplEQdhhNBTsPAP3hHO3R3j+8tpLIoZOCLcbHNUKpxJA4t4N0LIjXaarg/Os i6YBDilOyz/j4hwx35BKX/1+LyzRw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddthedgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrd dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A954430663E8; Mon, 18 May 2020 05:22:12 -0400 (EDT) From: Thomas Monjalon To: "Yigit, Ferruh" , Ray Kinsella Cc: "Dumitrescu, Cristian" , Neil Horman , Eelco Chaudron , "dev@dpdk.org" , David Marchand , "stable@dpdk.org" , Luca Boccassi , "Richardson, Bruce" , "Stokes, Ian" , Andrzej Ostruszka Date: Mon, 18 May 2020 11:22:10 +0200 Message-ID: <3888163.3T5rpR7ggn@thomas> In-Reply-To: <476bc533-b967-ec72-fe9c-8286eab4639e@ashroe.eu> References: <20200513121149.2283385-1-ferruh.yigit@intel.com> <476bc533-b967-ec72-fe9c-8286eab4639e@ashroe.eu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] meter: provide experimental alias of API for old apps X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/05/2020 08:29, Ray Kinsella: > On 17/05/2020 20:52, Dumitrescu, Cristian wrote: > > From: Yigit, Ferruh > >> > >> On v20.02 some meter APIs have been matured and symbols moved from > >> EXPERIMENTAL to DPDK_20.0.1 block. > >> > >> This can break the applications that were using these mentioned APIs on > >> v19.11. Although there is no modification on the APIs and the action is > >> positive and matures the APIs, the affect can be negative to > >> applications. > >> > >> Since experimental APIs can change or go away without notice as part of > >> contract, to prevent this negative affect that may occur by maturing > >> experimental API, a process update already suggested, which enables > >> aliasing without forcing it: > >> https://patches.dpdk.org/patch/65863/ > >> > > > > Personally, I am not convinced this is really needed. > > > > Are there any users asking for this? > > As it happens it is all breaking our abi regression test suite. > One of the things we do is to run the unit tests binary from v19.11 against the latest release. > > > Is there any other library where this is also applied, or is librte_meter the only library? > > librte_meter is the only example AFAIK. > But then we only have one example of needing symbol versioning also at the moment (Cryptodev). > > This is going to happen with experimental symbols that have been around a while, > that have become used in applications. It is a non-mandatory tool a maintainer can use > to preserve abi compatibility. If you want to maintain ABI compatibility of experimental symbols, it IS a mandatory tool. You cannot enforce your "ABI regression test suite" and at the same time say it is "non-mandatory". The real question here is to know whether we want to maintain compatibility of experimental symbols. We said no. Then we said we can. The main concern is the message clarity in my opinion.