[dpdk-dev] [PATCH] eventdev: fix resetting software timer

[dpdk-dev] [PATCH] eventdev: fix resetting software timer

[Dan Gora]

Fix the call to rte_timer_reset_sync() in sw_event_timer_cb().  The
second parameter is the number of ticks, the third is the timer type.

Fixes: 6750b21bd6af ("eventdev: add default software timer adapter")
Cc: erik.g.carrillo@intel.com

Signed-off-by: Dan Gora <dg@adax.com>
---
 lib/librte_eventdev/rte_event_timer_adapter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eventdev/rte_event_timer_adapter.c b/lib/librte_eventdev/rte_event_timer_adapter.c
index 9a863f5cb..6f1d672ce 100644
--- a/lib/librte_eventdev/rte_event_timer_adapter.c
+++ b/lib/librte_eventdev/rte_event_timer_adapter.c
@@ -565,7 +565,7 @@ sw_event_timer_cb(struct rte_timer *tim, void *arg)
 		 * immediate expiry value, so that we process it again on the
 		 * next iteration.
 		 */
-		rte_timer_reset_sync(tim, SINGLE, 0, rte_lcore_id(),
+		rte_timer_reset_sync(tim, 0, SINGLE, rte_lcore_id(),
 				     sw_event_timer_cb, evtim);
 
 		sw_data->stats.evtim_retry_count++;
-- 
2.13.2.556.g5116f79

Re: [dpdk-dev] [PATCH] eventdev: fix resetting software timer

[Carrillo, Erik G]

> -----Original Message-----
> From: Dan Gora [mailto:dan.gora@gmail.com] On Behalf Of Dan Gora
> Sent: Monday, May 21, 2018 7:14 PM
> To: Carrillo, Erik G <erik.g.carrillo@intel.com>; Jerin Jacob
> <jerin.jacob@caviumnetworks.com>
> Cc: dev@dpdk.org; Dan Gora <dg@adax.com>
> Subject: [PATCH] eventdev: fix resetting software timer
> 
> Fix the call to rte_timer_reset_sync() in sw_event_timer_cb().  The second
> parameter is the number of ticks, the third is the timer type.
> 
> Fixes: 6750b21bd6af ("eventdev: add default software timer adapter")
> Cc: erik.g.carrillo@intel.com
> 
> Signed-off-by: Dan Gora <dg@adax.com>
> ---
Good catch, Dan;  thanks for the fix.

Acked-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>

Re: [dpdk-dev] [PATCH] eventdev: fix resetting software timer

[Thomas Monjalon]

> > Fix the call to rte_timer_reset_sync() in sw_event_timer_cb().  The second
> > parameter is the number of ticks, the third is the timer type.
> > 
> > Fixes: 6750b21bd6af ("eventdev: add default software timer adapter")
> > Cc: erik.g.carrillo@intel.com
> > 
> > Signed-off-by: Dan Gora <dg@adax.com>
> > ---
> Good catch, Dan;  thanks for the fix.
> 
> Acked-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>

Applied, thanks