DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
	Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 0/5] FSLMC bus enchancements
Date: Tue, 16 Jul 2019 12:40:28 +0100	[thread overview]
Message-ID: <38a8dc70-51f2-ad22-c211-953beaadcb99@intel.com> (raw)
In-Reply-To: <2215079.QxrPnuoOdN@xps>

On 7/15/2019 10:53 PM, Thomas Monjalon wrote:
> 15/07/2019 10:44, Hemant Agrawal:
>> Nipun Gupta (1):
>>   bus/fslmc: use cinh read for eqcr ci on ls1088 platform
>>
>> Sachin Saxena (1):
>>   mempool/dpaa2: vfio dmamap for user allocated memory
>>
>> Shreyansh Jain (3):
>>   bus/fslmc: support device iteration
>>   bus/fslmc: enhance error handling for dev parsing
>>   bus/fslmc: dynamic iommu mode detection
> 
> I had the following comments on v1:
> 	The title should start with a verb.
> 	VFIO and DMA should be uppercase.
> I tried to fix it.
> 
> Applied, thanks
> 
> 


Getting build error with "ppc_64-power8-linuxapp-gcc" target [1], related to the
wrong format specifier. Not sure it is only ppc one.

$ /opt/ppc/bin/powerpc64le-linux-gcc --version
powerpc64le-linux-gcc.br_real (Buildroot 2018.08-git-00807-g0184fa3) 8.2.0


[1]
In file included from .../drivers/bus/fslmc/fslmc_vfio.c:37:


                                           [75/3669]
.../drivers/bus/fslmc/fslmc_vfio.c: In function ‘rte_fslmc_vfio_mem_dmamap’:
.../drivers/bus/fslmc/fslmc_logs.h:18:44: error: format ‘%llx’ expects argument
of type ‘long long unsigned int’, but argument 5 has type ‘__u64’ {aka ‘long
unsigned int’} [-Werror=format=]
  rte_log(RTE_LOG_DEBUG, dpaa2_logtype_bus, "fslmc: %s(): " fmt "\n", \
                                            ^~~~~~~~~~~~~~~
.../drivers/bus/fslmc/fslmc_vfio.c:387:2: note: in expansion of macro
‘DPAA2_BUS_DEBUG’
  DPAA2_BUS_DEBUG("VFIO dmamap 0x%llx:0x%llx, size 0x%llx\n",
  ^~~~~~~~~~~~~~~
.../drivers/bus/fslmc/fslmc_vfio.c:387:36: note: format string is defined here
  DPAA2_BUS_DEBUG("VFIO dmamap 0x%llx:0x%llx, size 0x%llx\n",
                                 ~~~^
                                 %lx
In file included from .../drivers/bus/fslmc/fslmc_vfio.c:37:
.../drivers/bus/fslmc/fslmc_logs.h:18:44: error: format ‘%llx’ expects argument
of type ‘long long unsigned int’, but argument 6 has type ‘__u64’ {aka ‘long
unsigned int’} [-Werror=format=]
  rte_log(RTE_LOG_DEBUG, dpaa2_logtype_bus, "fslmc: %s(): " fmt "\n", \
                                            ^~~~~~~~~~~~~~~
.../drivers/bus/fslmc/fslmc_vfio.c:387:2: note: in expansion of macro
‘DPAA2_BUS_DEBUG’
  DPAA2_BUS_DEBUG("VFIO dmamap 0x%llx:0x%llx, size 0x%llx\n",
  ^~~~~~~~~~~~~~~
.../drivers/bus/fslmc/fslmc_vfio.c:387:43: note: format string is defined here
  DPAA2_BUS_DEBUG("VFIO dmamap 0x%llx:0x%llx, size 0x%llx\n",
                                        ~~~^
                                        %lx
In file included from .../drivers/bus/fslmc/fslmc_vfio.c:37:
.../drivers/bus/fslmc/fslmc_logs.h:18:44: error: format ‘%llx’ expects argument
of type ‘long long unsigned int’, but argument 7 has type ‘__u64’ {aka ‘long
unsigned int’} [-Werror=format=]
  rte_log(RTE_LOG_DEBUG, dpaa2_logtype_bus, "fslmc: %s(): " fmt "\n", \
                                            ^~~~~~~~~~~~~~~
.../drivers/bus/fslmc/fslmc_vfio.c:387:2: note: in expansion of macro
‘DPAA2_BUS_DEBUG’
  DPAA2_BUS_DEBUG("VFIO dmamap 0x%llx:0x%llx, size 0x%llx\n",
  ^~~~~~~~~~~~~~~
.../drivers/bus/fslmc/fslmc_vfio.c:387:56: note: format string is defined here
  DPAA2_BUS_DEBUG("VFIO dmamap 0x%llx:0x%llx, size 0x%llx\n",
                                                     ~~~^
                                                     %lx

  reply	other threads:[~2019-07-16 11:40 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-25 10:44 [dpdk-dev] [PATCH 1/5] bus/fslmc: support device iteration Hemant Agrawal
2019-06-25 10:44 ` [dpdk-dev] [PATCH 2/5] bus/fslmc: enhance error handling for dev parsing Hemant Agrawal
2019-06-25 10:44 ` [dpdk-dev] [PATCH 3/5] bus/fslmc: dynamic iommu mode detection Hemant Agrawal
2019-06-25 10:44 ` [dpdk-dev] [PATCH 4/5] bus/fslmc: use cinh read for eqcr ci on ls1088 platform Hemant Agrawal
2019-06-25 10:44 ` [dpdk-dev] [PATCH 5/5] mempool/dpaa2: vfio dmamap for user allocated memory Hemant Agrawal
2019-06-26 21:50 ` [dpdk-dev] [PATCH 1/5] bus/fslmc: support device iteration Thomas Monjalon
2019-06-27  9:20   ` Hemant Agrawal
2019-06-27  9:33 ` [dpdk-dev] [PATCH v2 0/5] FSLMC bus enchancements Hemant Agrawal
2019-06-27  9:33   ` [dpdk-dev] [PATCH v2 1/5] bus/fslmc: support device iteration Hemant Agrawal
2019-07-15  8:44     ` [dpdk-dev] [PATCH v3 0/5] FSLMC bus enchancements Hemant Agrawal
2019-07-15  8:44       ` [dpdk-dev] [PATCH v3 1/5] bus/fslmc: support device iteration Hemant Agrawal
2019-07-15  8:44       ` [dpdk-dev] [PATCH v3 2/5] bus/fslmc: enhance error handling for dev parsing Hemant Agrawal
2019-07-15  8:44       ` [dpdk-dev] [PATCH v3 3/5] bus/fslmc: dynamic iommu mode detection Hemant Agrawal
2019-07-15  8:44       ` [dpdk-dev] [PATCH v3 4/5] bus/fslmc: use cinh read for eqcr ci on ls1088 platform Hemant Agrawal
2019-07-15  8:44       ` [dpdk-dev] [PATCH v3 5/5] mempool/dpaa2: vfio dmamap for user allocated memory Hemant Agrawal
2019-07-15 21:53       ` [dpdk-dev] [PATCH v3 0/5] FSLMC bus enchancements Thomas Monjalon
2019-07-16 11:40         ` Ferruh Yigit [this message]
2019-07-16 13:36           ` Thomas Monjalon
2019-07-16 13:43             ` Bruce Richardson
2019-07-19 19:09             ` Ferruh Yigit
2019-07-22  6:56               ` Hemant Agrawal
2019-06-27  9:33   ` [dpdk-dev] [PATCH v2 2/5] bus/fslmc: enhance error handling for dev parsing Hemant Agrawal
2019-06-27  9:33   ` [dpdk-dev] [PATCH v2 3/5] bus/fslmc: dynamic iommu mode detection Hemant Agrawal
2019-06-27  9:33   ` [dpdk-dev] [PATCH v2 4/5] bus/fslmc: use cinh read for eqcr ci on ls1088 platform Hemant Agrawal
2019-06-27  9:33   ` [dpdk-dev] [PATCH v2 5/5] mempool/dpaa2: vfio dmamap for user allocated memory Hemant Agrawal
2019-07-07 19:55     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38a8dc70-51f2-ad22-c211-953beaadcb99@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).