From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4FE845AA8; Fri, 4 Oct 2024 06:00:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9089A402DD; Fri, 4 Oct 2024 06:00:41 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2066.outbound.protection.outlook.com [40.107.244.66]) by mails.dpdk.org (Postfix) with ESMTP id CEDF9402C9 for ; Fri, 4 Oct 2024 06:00:39 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fUxMc88JJ07mb286nPDgZ66AgZ/qoSe8i2hwcbcmFZ/87oG7w0LNHRC2eP5Ve7od2wxHv/ysG1ZOm/AcCmgEsJFzrNHJ5v8ka+QD7H5IHekvInVUSqkRVf54swrrAzqXTwCjMc7/KMaVmS8MYa9pxijRSbT1u4z0xW9OTkZY4nfIaEc3IVFqvkDAch9TMKcZ3+rrE8ZH4JnaBhOvbmMTCy89pIs7wU3jwB0+3yp+7X8Fa87cPOPV4ijF43IAZD9QMLJZ22K4qGZV9U/POousmksFHzTc3gi/HosvFgVTNfYRzdurlZNQqpnX1gHPGPOR67iTQEDDGSOYYLqXPSOX3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=06Q1zNO8aP9HzBG2uALbMluiQESjuUtkhxs9nB8I6Is=; b=tOyaBTCt+keSvsi+zymVshg6/BFnwcgFuVX1X3Ukn7+InBBCofl7jQF83tS5MhQozayQfChL03L5rgYswGTKHOJdmdI9s8DlomUUo6+cxb4kUf5j+gMIvK5WfSdGml/7hIvvGEMXWFoEyuQObtCVzPK0nZJXYFdCXo6mYLTkGTi3LGNtiGs60Q0chlWCzUuCZMmRn33jruIgf22eOaE9hHxkawE/Z7OjwAKdyv16a5qdmLNfFoO3PPFO5QF5GL8JqzjG9rkBrFqIE9WGr29LNDVXqd3Ee0Lmj0rPL17qBAFt5ICUvM7sS1OChB9F5QEZI+rUcqaOjVHpdKwZdloWvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=06Q1zNO8aP9HzBG2uALbMluiQESjuUtkhxs9nB8I6Is=; b=gSO992w7PDFlVVpkkqAxhv1M5/huwEBpv0rLPqvYehKUG3JxoBQTQyslZSM2pwwsL2TX4b9Lwr3bYKLpgLIakRnpQHTruRkzBT69tWzDQ6NuI8eIzscQPXYA/2MAJ5L9AHR98O+AzxENACwvcvKAF27YiFb88pnkLMpB+h4+FYM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by LV8PR12MB9231.namprd12.prod.outlook.com (2603:10b6:408:192::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.18; Fri, 4 Oct 2024 04:00:35 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.8026.017; Fri, 4 Oct 2024 04:00:35 +0000 Message-ID: <38aafa18-eb58-4b80-a8c9-2d05d0bac963@amd.com> Date: Fri, 4 Oct 2024 05:00:26 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [RFC] cryptodev: replace LIST_END enumerators with APIs To: Akhil Goyal , =?UTF-8?Q?Morten_Br=C3=B8rup?= , fengchengwen , "dev@dpdk.org" Cc: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , Anoob Joseph , "pablo.de.lara.guarch@intel.com" , "fiona.trahe@intel.com" , "declan.doherty@intel.com" , "matan@nvidia.com" , "g.singh@nxp.com" , "fanzhang.oss@gmail.com" , "jianjay.zhou@huawei.com" , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "konstantin.v.ananyev@yandex.ru" , "radu.nicolau@intel.com" , "ajit.khaparde@broadcom.com" , Nagadheeraj Rottela , "mdr@ashroe.eu" References: <20240905101438.3888274-1-gakhil@marvell.com> <98CBD80474FA8B44BF855DF32C47DC35E9F6A8@smartserver.smartshare.dk> <1d17f91a-fbfe-229b-9772-c149ed9d335a@huawei.com> <98CBD80474FA8B44BF855DF32C47DC35E9F6AD@smartserver.smartshare.dk> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LNXP265CA0083.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::23) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|LV8PR12MB9231:EE_ X-MS-Office365-Filtering-Correlation-Id: d7e01686-0303-4921-c6c9-08dce4291973 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZGtON3BQQXFUei9pMExMSkpzV2REeGZSVmgrN21XdUlrNkQyaG9iZnYxY3lx?= =?utf-8?B?WHNPQVE4U3h6U1hxNDRaOXdDdFB4eERIUVU1c3ZFanI4S1cwZnRJVGpXWTRw?= =?utf-8?B?TWQ3WUJ2azlXckQ0RXJEcGt2SGVxb0lQZ3RPbTBqWjdUU0ZjQnorZzdKNjFB?= =?utf-8?B?UGxuRktBMWkwTWFqaW91aFJLRkxFQncwVTV5cmN1N2xlM0dNb2lVVitEYVlR?= =?utf-8?B?dEwrc3Vtc3ZnVWpjK3ltYWt5QlFvQWZvVVRXNmhqL0Z6bDhaV0N6cjRSSmNp?= =?utf-8?B?d2JJSkNERmUwYTVxU1FEbi9LTzZTZ1BWaktzQTg4d2MyS0hBaWlJWnk1MW1x?= =?utf-8?B?YlloR1NNZ1ppS0V1VTJOVzg3QkJ0MUEwV1gvaVh2UjFLbzlSSHIydURhUGQ4?= =?utf-8?B?TEVwUWlMR1Zqelc5QlpqRXd1ckd6cXBoTkd0d0djWi92WmNnQ0tYRlk4MGNj?= =?utf-8?B?TUJyVDludVNKeVlrcjVyZ2t5SWkweVlIaktEdkRmdEVEclRFTjZRUHcrbWpr?= =?utf-8?B?dmlSWUg2T0VwbWpNNHhKMjJuV3YwZ0o5OWpDQW5NVWMxaHRxSHJmRVFPalZt?= =?utf-8?B?VWxmQ3RhRE9CRDFWcStlWkhzLy85RXh3RGJHc0RjeHlRNzczekNESkJkeTho?= =?utf-8?B?ZlBpSERPSmI3cWdDaHhvZ245RUxncGpLQXUwMVhxWUpnUGpDWmpKem9Ha1Rt?= =?utf-8?B?VmlUNngwZW5tVXZIOXZqbHNqWDl1bXVjUFdNdkRGUUZQSjU1Tk5meGVORlFN?= =?utf-8?B?amlBV1BjWDZKRG5VT0xKWlZUZTQwRy9xWklxV21pZ2Z1cWpmd0VtT1pKNzgw?= =?utf-8?B?ZFJpM2Q0aUNzaHJnc0l0Y3kxRmVNdFhCeFF1RFM0QXIvYVRLNm9MU01kS09w?= =?utf-8?B?aHl6d0tuTlUwWHJMNWJ3dGJHSWRmQmUyWnNpWnEwNS94R29IQVFZbUlNZno1?= =?utf-8?B?NVk3MHFxeXhwUTJhcTFuZXhJZzJrZ0tBelBWY2NKTDFkZTdYVjJOa2pLRUho?= =?utf-8?B?Nk5Td2dpOFBKYTF6a05haER0MEM2TTFsMCt2aWN2bHNtSDdOMlVEZUhwejV4?= =?utf-8?B?R0VkZ0NuRkRneDZZdTUrendGLzR1MEdhbjFDMWV4UTNKVDBEVjNERmYwRysz?= =?utf-8?B?VlM1YVdtMklRemt5MHpJcWNSQXJLdTlwYXZTbS9kVHB1NzJTaWdFUVpud3NZ?= =?utf-8?B?czR0bytmVnBTdCtOUWxBWUYwK2s4MEZaYkRKR0xHcWdJVVpLaU0xNHFSU1Y5?= =?utf-8?B?eXlPTnkzRFhMWWZvTHFZcm4yK0V4enlmSUxrc2MwS3ZFdWV5cTNQN25ydUxl?= =?utf-8?B?TytHMkNyMzBNUE5zVVlIVVBlSEVCVmx2b0JvR2hlQk9QNGhER1dJVEordDFU?= =?utf-8?B?L1VjenN3RDdtbmtjQlVldFpYeHBvL2J1NW1lTHZXdGJzZ2FzcHJVejIxekdO?= =?utf-8?B?dFh4MmVzNkVsb0ZpZm9MOC8wdzhQNDZPLzkwQ3ljcU43ejBLeGRzTGxUOURT?= =?utf-8?B?enBIcW1UZ2t5aElXWjljMU5tdTdrQTA0bjhCTW93ZTRNQzM0aGhuYXQ5NGFH?= =?utf-8?B?TFZDRzJYdXZlbWF0WWhIdW5INDR3RmQxdjNaaFk3aVhOd3Rob1lqbXFrT3dy?= =?utf-8?B?ZWJPRDVEQVBiL1lYM0pnbXMwMjgrRWJXdUlkL2hUYm1DaG85UWlCRU9GU00z?= =?utf-8?B?ZGsyOHp4dSs3VjVDQ0NZRjJsbGRPOHpTbVRlSWYyQlZUMkI4RGJZcVdRPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(7416014)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UnFKcUNSVmZwazRvZ1dwYUdZemNIeHBDU1RQdUlRdFNMWjFVRkRhN283ZS9q?= =?utf-8?B?M2Z4bEFpZTYxNWhzaU9Ld2hBSDZWQlI5TGRyS2w0bGlBQjRwZkZYS1RkYkN0?= =?utf-8?B?djJNdy9vbFlvejdLODFqYUdEcWdxZG10c1N2KzN1Qm5UbG54NjRWVDBQaUR5?= =?utf-8?B?Y1RnQ3FCTXhPenJFVnRVZ3BwVzZwMFBBRm9senlKcW9rcEp2cVIrSlFJZ0Nu?= =?utf-8?B?WXFRT3hQK2lwc09TR2V4VkRtd1d5NEo0WjNmQXJnRDdIcnU4bFZ1TU9jM2Vn?= =?utf-8?B?M29JWTdFbVd2a0VxVUJMQmpRYWYxVjA4Q0lONWM3QlY0RFNIOFh4L0RYdDhN?= =?utf-8?B?UDRPOEtPWFJJWnAwbm9RVmJNNEV1elptdEdIR05PUWFkOWtrWTIwWUk2alFV?= =?utf-8?B?UUV6Z1Z4d3RLYngyS3YzaDE4bm9QRVRHbWhLUHhKdDc3eU1PR0pJeEloQXM3?= =?utf-8?B?WmlGYmljZ0s4RFpKTnJzUm9SaTR4UnZUWllqLzhhSWdaRmY3aEZYUU44aFRE?= =?utf-8?B?K1RDZngrK3VkV3dJdlBWMmJ6d2llNmptd1VSZkVWVnlFekM3aUlsT2xjSmF3?= =?utf-8?B?cmdyVTJxSXFkR041Q1hTWTlRNTRobUxadWczQlBrdkZsM3RRalhwYWltRTZN?= =?utf-8?B?SlV5eURYb0FYNWlyTWkvM0pPR0xOQXlmTGRic0UreXN2Q2tQTU0xSUUxaFpz?= =?utf-8?B?dmppdlhJemdZVTZUUFlab1d5bXE2T2NRcHhVUW9ISjFZUHBERGtQSzVTNDA0?= =?utf-8?B?aGZJTVNPb2Rzdi9McU9hVThmclpPOU8veFQ5OGRQbUNOTUNDN0sxRFBvdm9V?= =?utf-8?B?MitrWDhKOTZ4NVJJMUZSMEtsYnhmanc2eEtMUlZrWHJIc295M0dsK1M4SklN?= =?utf-8?B?VlN5QUkvVHptZWFERDNYd0piRHFiT2hxRk9mODUxNlI2cTh4M1NUT3ljN3I4?= =?utf-8?B?V2JvcWErdHpsZS9OcmtielJOdGZZZVBLK3lHeUV2RWpINWZEMzd4dE5Sd21t?= =?utf-8?B?djFlSzdHNUM2eG1yaXZxT1ZCN0k5RXYyajFwbHdjOTQwcWlhcm1OU1ZUeGVp?= =?utf-8?B?YVUyczdxUW50U2xkc28rZi95VTZMMldnLzU2SU9NMmxENkVBRVNZMmtScThm?= =?utf-8?B?UmE1bUJqWHJna3dCZkpNR3ZmVVgwQUxPSkg0ZGEwWnhWL1VYUnFWR2lFeEYy?= =?utf-8?B?R1V0N1VxcHAwempmakg0am5peFA1TzdxSzhTRHlOMFJqclFvdldyS3doakdL?= =?utf-8?B?YUZQTExaeXc5eml0cXZJSVBpZmxiUjhKenNQczAwVUU2aDY4VmVoUEpvdSt0?= =?utf-8?B?NnkvOXZZNk0xTHgzNW9HUE14RHY1S1dGeVZsZlIxdkZ5ZlZCVUdNUGtIZy8w?= =?utf-8?B?L2lIdVg0UDgzZEdTVGUvSzY1R29JZCttMURJN1pzRzJLM1ZXM21RbWtXaFNK?= =?utf-8?B?aDVyVlFPRUNGL1FGREhPMkVDeUEwc3Z0TU5JYWc2MXZHcXVIMEZBaElBZ0lO?= =?utf-8?B?QlFGNVRjUjZuY01yV3JOUEFIOEFodmxIRnVlbnZkUWxVQlhVQitDdmR1ZkFh?= =?utf-8?B?QWZDTEIrL3JkZVVSR3NYWHZTWVlya1ByQnk5V1VMaG1jNU04MExieS91bWFE?= =?utf-8?B?T1hvZUhaZ0psY3FmVnNGU1ZGZGpPL0pkWnUwRjlsVXJSZjVLUnlka2lDV2Q1?= =?utf-8?B?dVBWMUc1Vm5WVjlQKy80SVh6OUV5OVZKY1RSa204ZWo0cnJlWDRyRGNjeVBz?= =?utf-8?B?SjBaNUViUzArbFFtUFdidDB2VW9HSFBjVVlJMXowRDFDcWVjbzZqeGJTUVIy?= =?utf-8?B?dzUrVHlGYTIzWUxRTjJnQWFKd3loaVUyUGc0dDMzUmNYc3hKcXZRWkszRUxJ?= =?utf-8?B?ZGVOekE1b0dwRmMwOTBTSWpUWkxpRStTWVROUXFlWmpzUklyYWVNS2RUSENN?= =?utf-8?B?RVUwU0hyd0l0emVDZWU0eXFSOTJKMEMxUGw4NHl3ZXMyN1NCY1lLWnBqY281?= =?utf-8?B?a2plY3Z5cmY0T0lvTjZYc2Y4WVJscEhuUG1WVUM2SmIyRzlaL2srNTBUenNn?= =?utf-8?B?YUprVTRha3ZkR3BqSGtFaTVHRUl2NEw0VFlGeTlXbDFOaThFc0lYRzFNMFJI?= =?utf-8?Q?eARlafwrmNqpiI2esaf0HVkdU?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7e01686-0303-4921-c6c9-08dce4291973 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2024 04:00:35.3671 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HW6V0wtB96EzGxxof3Nj/KC+9ikj+tlApezcir51ZTYTQF6zdNrXBtQ9Bbk3hthW X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9231 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/23/2024 9:41 PM, Akhil Goyal wrote: > Hi Morten, > > Apologies for delayed response. >> Maybe a combination, returning the lowest end of the two versions of the list, >> would work... >> >> ---------------------------------- >> Common header file (rte_common.h): >> ---------------------------------- >> >> /* Add at end of enum list in the header file. */ >> #define RTE_ENUM_LIST_END(name) \ >> _ # name # _ENUM_LIST_END /**< @internal */ >> >> /* Add somewhere in header file, preferably after the enum list. */ >> #define rte_declare_enum_list_end(name) \ >> /** @internal */ \ >> int _# name # _enum_list_end(void); \ >> \ >> static int name # _enum_list_end(void) \ >> { \ >> static int cached = 0; \ >> \ >> if (likely(cached != 0)) \ >> return cached; \ >> \ >> return cached = RTE_MIN( \ >> RTE_ENUM_LIST_END(name), \ >> _ # name # _enum_list_end()); \ >> } \ >> \ >> int _# name # _enum_list_end(void) >> >> /* Add in the library/driver implementation. */ >> #define rte_define_enum_list_end(name) \ >> int _# name # _enum_list_end(void) \ >> { \ >> return RTE_ENUM_LIST_END(name); \ >> } \ >> \ >> int _# name # _enum_list_end(void) >> >> -------------------- >> Library header file: >> -------------------- >> >> enum rte_crypto_asym_op_type { >> RTE_CRYPTO_ASYM_OP_VERIFY, >> /**< Signature Verification operation */ >> RTE_ENUM_LIST_END(rte_crypto_asym_op) > > Will the ABI check be ok for adding anything in between > RTE_CRYPTO_ASYM_OP_VERIFY and RTE_ENUM_LIST_END(rte_crypto_asym_op)? > Don’t we need to add exception for that if we somehow make it internal by adding a comment only? > Library is actually not restricting the application to not use RTE_ENUM_LIST_END(rte_crypto_asym_op) directly. > > Also we may need to expose the .c file internal function as experimental in version.map > >> } >> >> rte_declare_enum_list_end(rte_crypto_asym_op); >> >> --------------- >> Library C file: >> --------------- >> >> rte_define_enum_list_end(rte_crypto_asym_op); > > If we want to make it a generic thing in rte_common.h > Will the below change be ok? > ---------------------------------- > Common header file (rte_common.h): > ---------------------------------- > #define rte_define_enum_list_end(name, last_value) \ > static inline int name ## _enum_list_end(void) \ > { \ > return last_value + 1; \ > } > > ---------------- > Lib header file > ---------------- > //After the enum definition define the list end as below > rte_define_enum_list_end(rte_crypto_asym_op, RTE_CRYPTO_ASYM_OP_VERIFY); > I assume Morten suggests his macros to escape from maintenance cost of updating inline function each time a new enum is added. But with above suggestion, that cost is still there, so I don't think this one has a benefit against the original suggestion.