From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58D67A04A8; Wed, 26 Jan 2022 15:02:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 36F9A4273C; Wed, 26 Jan 2022 15:02:22 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id BF5B142716 for ; Wed, 26 Jan 2022 15:02:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643205739; x=1674741739; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=4YQkt8ayQa4d9ORS/0vojnxYgRWhjvX2PNwYl4rTUZU=; b=cCncR10QoOR3iufZrDKFB9cBE6Lw7y1rW6PabDF/N6wbiaiTWE1NdDSj AQuWFdVAIqSosajnWb+OE30zl26/+DLeL60CK0+GMXo9YnrHqYoU/Yr76 9hoFChon2Uir9EnCfJ4RzCyTTYXyTiLoi068j0EChUBS176Ka7NWy2nVJ 9MRiK3ZHv1pwMxhc7ay7sSTorK8VCb2mXQ2vGnfDgDamPXFD065rM6tbl LyqyEbnHlp7vopl2aIWd0zmYI8k2VF9B/Wt9sgWKvhFQTyo9TlnnZmp0w oGgFcnFkpmAXSmsw7GY254dJ2dRu/80y8UgKdoRckPGVvMNp8/YnJO16r Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10238"; a="226529808" X-IronPort-AV: E=Sophos;i="5.88,318,1635231600"; d="scan'208";a="226529808" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2022 06:02:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,318,1635231600"; d="scan'208";a="696247674" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga005.jf.intel.com with ESMTP; 26 Jan 2022 06:02:02 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 26 Jan 2022 06:02:02 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 26 Jan 2022 06:02:02 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 26 Jan 2022 06:02:02 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XUZ5ffiGJLxsZfmDzr2Pz5tzmZQrzGOhWGYM4vZTc+nT34mp/5poNbMidj+FMuhXuQp5Hpt3BglCNM+PYc0CHUnzCv6D+xtmf1RfX2VweJbkDVFDPwSIMC+N2U6Endy0Hr3NaK3HUlLAv74vOkSdG/gGXvRfPRvdzwU8jBMTPNQJ6VRFzUTTWeJgOSRsPlcukZ221GmO8aCX0BHKCZ1VnXe0C36+ExiSPDgvjFqJuQKvBNHmPYS//tpqy1L/pErGhWHQF8m7i7AfGwiR7A3Lqc6svD7pW5jDDsbMd38wnSSUgLk8MLuyFA1S/J47RYc+6CNYpVJ56fQg5y29+rLxUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PuGhckBsb1/hF5L846pbbn/HwVL2cpXBtT5ygwuOvIo=; b=cp4AVn8gNMDA0szAcGbtdGGnqXNMyfJL3tZ5gJ7gRNXivi0kHUiQP2hD1NFk4uOBJdPnagajceufM13Z8KEy/7g/9g0rNc7gZQsYFgg+MeXVU2Yj52Hc7WZ9idbJHWg1dT6W/7FuTrocUHLBr31YoGFQSke39mwDbKPt4QbIEkvWbl01RhrV8TEJm5TyLtBhIp3G8xenDkBYNexX9hewqKP741EoSIELXWML6sXRoz9gx3QVy3JjCz1CSPczd/v8ZwfDEsCvPeP2t7TRwCMg+gbp9jzASQr4LvBmiRuXIJWdm2k+FmREeO0A4lYeZC9qdGUMWD5FyqHf/wOyTE8/Rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BN6PR11MB4180.namprd11.prod.outlook.com (2603:10b6:405:7c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Wed, 26 Jan 2022 14:01:59 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4909.019; Wed, 26 Jan 2022 14:01:59 +0000 Message-ID: <38aec558-8449-f0b2-2ab2-e52a6ad6ce15@intel.com> Date: Wed, 26 Jan 2022 14:01:53 +0000 Content-Language: en-US To: John Daley , CC: , Hyong Youb Kim References: <20220114031036.19052-1-johndale@cisco.com> <20220114031036.19052-4-johndale@cisco.com> From: Ferruh Yigit Subject: Re: [PATCH 3/3] net/enic: support max descriptors allowed by adapter X-User: ferruhy In-Reply-To: <20220114031036.19052-4-johndale@cisco.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0350.eurprd04.prod.outlook.com (2603:10a6:10:2b4::22) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bb1a1ba3-779f-4a58-d85e-08d9e0d46baf X-MS-TrafficTypeDiagnostic: BN6PR11MB4180:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2150; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GTiV2rVwdLshKmJaeQfWHFEasqiI+9lfL/jZZo40dZ2e7Tyg83qPrdtBaywsQlAovffBeq7PSrpIhznB2lii4XSHMWUiNsrMlBky6GIegk0DY2dDoIfJk8q9FByLE/CwvOa0gkJiW7EGhqyj5RGAw3HmdUUpgFGyD117MFBT+1sudamQaYsphBhbiF1qsDhSUWB4u7oBq2b+Gcp3Rzmftsk53yCkuPXDst8ShVRW9gpQvJsK+wjv1hndr3RCsN3NLn6rU1TzY4Cv7WxdeE3oHRrfbVUaYcuUpA+ZfQFuWRA/7DGydStj7J9VZF5GN65ewdymYFvUrzR6Ob9EFIZ4MF2794eh7erhWg3vjZsZwkeNfEcOlemQbIWrzqhpc5s8rpTjhS1ZCMWRZGcH2G5zEoXLykBqZcP+aiyIAsVBRHaBkzRtXkgXyU67xPJjUmwN875wlWMHvfLnVaxS34h5JLLWwLu6/IhPbhAX/xWEVzhscbeIc/sxRo99KG5JJMlKqoLqbfEjyQ5kGfEYVCd6J8+rN34VIYw/RkCuHNUM2+3QPbQDZxsFUIgJIrxSyn3KdvfnUCZ2JMiyRIQtxlbUdfwDSkqLjzxIqr3Pdkm7d7oe3SO7r1TEF3WRxXplQzTMCt9RShSlF//fvntZFKcwAcTQfpwqsuUMqIZgvWNvd4jXMCjE4TSF0Ku7Rtq2uwqUgno4G3V3R317et22H9Bu0g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2616005)(186003)(26005)(8676002)(6506007)(6666004)(6512007)(36756003)(83380400001)(53546011)(44832011)(66946007)(66556008)(31696002)(86362001)(5660300002)(4326008)(31686004)(66476007)(2906002)(8936002)(82960400001)(38100700002)(316002)(508600001)(6486002)(45980500001)(20210929001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzAwdGdYMU95WjFvZlNNWXBSTE1pU1VLdXVJQllqd1FrbGZsbm5NVVF4SXpL?= =?utf-8?B?Y00wdEdBU0FVelEzZWxrMWh3c1RjRXZib0JQS2RDS3UzQ0lYK2JJUUIvbm9v?= =?utf-8?B?c0RmempVVGJ3SkliZzNJdWZSWXRCZmh1cUVBdzRRZ2FLTWoxY1JERVZiSVRB?= =?utf-8?B?S3d3RlBYNDJmVzZ3S2F2b0RhUWhSaVVzbzkyaEFHa0tUWE93VlA3SzU5TUhC?= =?utf-8?B?RmY0YlY1SFZzU3gvZEswb3Z4MHFWNVRDOEoyTDFpRDZXeW5DaXdReWtFQ0tO?= =?utf-8?B?VmlMODRFQ0xHL1hRZzFzMldQcjFmYjF4dXpWT2djbUNGdGkzSW0vL240MnNN?= =?utf-8?B?TEFjSUFuVnF0TlEyQUtTNGdjVmcrMERPdVQvbU9rNldxenhXL3RrckxuWmtD?= =?utf-8?B?VVdDNkNLak04WGRZbTNhQW52R0lKcW81NVl2VGl2dEczb1NrOWdPT28vUVBW?= =?utf-8?B?MnM3Nm5aS1h1TkkxNzV3WmVHK2paWHVTTHpaS0daZFV5ZmgvRGN4YU8yUGRJ?= =?utf-8?B?K2g5dWFIMFBIUjFweGExQlpCSXZ2SUFPT0g1MSt6cXU0ZHJBeE9DSHJ1WnU4?= =?utf-8?B?bUQzSEpyKzZVR0RlVzFyRStJSUlUNjhaQnl5VG1BNGRraGdLOS83MFlza3dB?= =?utf-8?B?eEdpQk1nNXlMd3ZqVG5rR1JacVBUVE1xRVZvYU1XczhraU10ZlE5MExzUGt3?= =?utf-8?B?R01XeGxHWHJLRTNHeXVtNXdqNnJsODVxVkpXakt2b2Y0cUd1aWViOEdtbVZI?= =?utf-8?B?SlNnZzFBcHdzREt5Zzl2Q2VrSEEvWVJ0a2pPZmFXdFFTVWt1MVNGUnpCYUhV?= =?utf-8?B?UXhKKy9Ob2lEQTRKQnlkeldZcFM5ZEF6d2dObTJWZWo5TEs4VnZKTUhPTU8v?= =?utf-8?B?Zk1nVVRvOHYvYkdSTVN1UWRSbFdCZXZWNm5XTWlEZS9xWlJ0WUJXcklFRE04?= =?utf-8?B?WmN5cTBFQTB6SzdSRHorU3d1SUQ1VTVkZk51djcyc1ZON2JHbWFLZThnMU96?= =?utf-8?B?bnVqNUdiV1F3cUFHcCtsQlFKWFBrTVl4NkR0RkRvWDZpOGZON1NXT042cE9O?= =?utf-8?B?M2Z3SC9wOHBsOXdyRW5wanJ2RjNYRmxtb1hseEg1NWw1QTFrVHpsMjBKSysv?= =?utf-8?B?U1JWNUVFbnpsMm9RbnRrdE1LQ0RvbXNmWHU3OURZanBlaVVQODNhSkVCOFpT?= =?utf-8?B?dUI5TklkYkE2TzVQUUNmMzE5SmhnT1RuWENFZGNucCtBRHdudXY1SnRjMnBy?= =?utf-8?B?OHlmN1BIZjdaTFFiWlRMc2pOSnhHQnNZMFFlNWtIc1Jodnk0Kys2dXJxSVpo?= =?utf-8?B?d3JBOFE0MDdOalp4bTh1VGI1dDVpNDlRUGdXTGl4bFBja1h0TGgrcGNLa1VC?= =?utf-8?B?dVpZSTh5S0hUbkxZaVZnYWFwTyttWGRBdXhwaURRS3dlc0laeWQraUE1dHFW?= =?utf-8?B?ckNVSFREdHBhbDlrMVBSSlVhVmpORjhtMmdMaW5oaThmVXpNTnVkeC96bjdZ?= =?utf-8?B?Q3FuK2UzK05IeVhOL1NDVFFkQ0JSeklBdm9sNDBUZ21HcFFQWm0yazlQcjZw?= =?utf-8?B?eGpleWFVeVFVZGJzQWgvNUFUY1BDU3dDWVRIOW9iOVlacUI2eGs4NXp5a0lJ?= =?utf-8?B?bjhEalB5dnhYQWNpZmROWmVoeHE0REdHQ1kxV3ptc2p2Rml0K1AvcVlHSjdm?= =?utf-8?B?N1hoOEFqV0ZCSVlIVHg2bXJ0a2RaT2lub3dFTWQzcW9hcDNBcnEzVFcyc0dN?= =?utf-8?B?K040dlBONENNR3lJVjJ4MjhzcWFWV0FtK2lYNFZKTWQ5eEpsYzloeEdzVTEw?= =?utf-8?B?dW51U3lLV3JjSzM5bXp1QXppR3puQjNYbGkyN2MxalAwSmxnbTJ6K29kOFlN?= =?utf-8?B?U1JGdnc1bGEzTTZQMy81ckN5WjlwOVZ2S1Q0dkJJYk9FdnlRRFpTYURxL2JO?= =?utf-8?B?QjFZZVVESUFXQURFYWxobDVJc3ZrMXZRR0VvbzY5b2FqSzdrbXYrSFVCbTRG?= =?utf-8?B?M1BBamQ4ZEhKSHQ5Y0JRdWs5Zkg1dVBVay9IeHcxUDN0eHIvR1EwY1NrNGdD?= =?utf-8?B?UW05d0dTeXEvTk5VWGdMNTZZWWxjRXAxU0lCSHpmZThpYk5ZSCtNL2ZLZ0ZM?= =?utf-8?B?bjRpSGo3VmFqYnA5RTBJcTNTUS9jNTM2aDRjdnk2Y0VrZlZpSElra3dxdVpK?= =?utf-8?Q?OKKwmzCrylYkDn76DODSWPM=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: bb1a1ba3-779f-4a58-d85e-08d9e0d46baf X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2022 14:01:59.6510 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EZ1EK+1RDyLgdBJTMZAUggM5SWCZxOoasQoiQd3QBCTN0V8QalxywHyA+Izgvr3l4UyeysBqFCwajRvdhTXEZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB4180 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/14/2022 3:10 AM, John Daley wrote: > Newer VIC adapters have the max number of supported RX and TX > descriptors in their configuration. Use these values as the > maximums. > > Signed-off-by: John Daley > Reviewed-by: Hyong Youb Kim <...> > diff --git a/drivers/net/enic/enic_res.h b/drivers/net/enic/enic_res.h > index 34f15d5a42..ae979d52be 100644 > --- a/drivers/net/enic/enic_res.h > +++ b/drivers/net/enic/enic_res.h > @@ -12,9 +12,11 @@ > #include "vnic_rq.h" > > #define ENIC_MIN_WQ_DESCS 64 > -#define ENIC_MAX_WQ_DESCS 4096 There are still 'ENIC_MAX_WQ_DESCS' usage remaining in the code, causing build error, can you please fix. ../drivers/net/enic/enic_rxtx.c: In function ‘enic_free_wq_bufs’: ../drivers/net/enic/enic_rxtx.c:397:46: error: ‘ENIC_MAX_WQ_DESCS’ undeclared (first use in this function); did you mean ‘ENIC_MIN_WQ_DESCS’? 397 | RTE_ASSERT(nb_free < ENIC_MAX_WQ_DESCS); | ^~~~~~~~~~~~~~~~~ ../lib/eal/include/rte_branch_prediction.h:38:45: note: in definition of macro ‘unlikely’ 38 | #define unlikely(x) __builtin_expect(!!(x), 0) | ^ ../lib/eal/include/rte_debug.h:47:25: note: in expansion of macro ‘RTE_VERIFY’ 47 | #define RTE_ASSERT(exp) RTE_VERIFY(exp) | ^~~~~~~~~~ ../drivers/net/enic/enic_rxtx.c:397:25: note: in expansion of macro ‘RTE_ASSERT’ 397 | RTE_ASSERT(nb_free < ENIC_MAX_WQ_DESCS); | ^~~~~~~~~~ ../drivers/net/enic/enic_rxtx.c:397:46: note: each undeclared identifier is reported only once for each function it appears in 397 | RTE_ASSERT(nb_free < ENIC_MAX_WQ_DESCS); | ^~~~~~~~~~~~~~~~~ ../lib/eal/include/rte_branch_prediction.h:38:45: note: in definition of macro ‘unlikely’ 38 | #define unlikely(x) __builtin_expect(!!(x), 0) | ^ ../lib/eal/include/rte_debug.h:47:25: note: in expansion of macro ‘RTE_VERIFY’ 47 | #define RTE_ASSERT(exp) RTE_VERIFY(exp) | ^~~~~~~~~~ ../drivers/net/enic/enic_rxtx.c:397:25: note: in expansion of macro ‘RTE_ASSERT’ 397 | RTE_ASSERT(nb_free < ENIC_MAX_WQ_DESCS); | ^~~~~~~~~~