From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 0C56C1B068 for ; Tue, 7 Aug 2018 10:39:41 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Aug 2018 01:39:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,454,1526367600"; d="scan'208";a="61227985" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.148]) ([10.237.220.148]) by fmsmga008.fm.intel.com with ESMTP; 07 Aug 2018 01:39:39 -0700 To: Thomas Monjalon , chaozhu@linux.vnet.ibm.com Cc: dev@dpdk.org, Takeshi Yoshimura , Takeshi Yoshimura References: <20180806084309.5489-1-tyos@jp.ibm.com> <4068541.lKVHRX04u0@xps> From: "Burakov, Anatoly" Message-ID: <38b342bb-3f41-7912-83d5-a9f207032cd2@intel.com> Date: Tue, 7 Aug 2018 09:39:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4068541.lKVHRX04u0@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal/vfio: fix sPAPR IOMMU mapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Aug 2018 08:39:42 -0000 On 06-Aug-18 10:50 AM, Thomas Monjalon wrote: > 06/08/2018 10:43, Takeshi Yoshimura: >> Commit 73a639085938 ("vfio: allow to map other memory regions") >> introduced a bug in sPAPR IOMMU mapping. The commit removed necessary >> ioctl with VFIO_IOMMU_SPAPR_REGISTER_MEMORY. Also, vfio_spapr_map_walk >> should call vfio_spapr_dma_do_map instead of vfio_spapr_dma_mem_map. > > This is fixing an old patch: > http://git.dpdk.org/dpdk/commit/?id=73a639085938 > >> Fixes: 73a639085938 ("vfio: allow to map other memory regions") > > You probably want it to be backported in previous release, > so you need to add Cc: stable@dpdk.org > >> Signed-off-by: Takeshi Yoshimura > > It is common to have bugs in sPAPR implementation. > How can we be sure this one is OK? > Should it be added in last minute of 18.08? > Or can it wait 18.11? > > Adding Anatoly and Chao who are maintainers to decide. > The patch appears to be correct - we did have a VFIO_IOMMU_SPAPR_REGISTER_MEMORY ioctl in the old map() function, but not in the new one. However, i agree with Thomas - without more testing from other sPAPR users/IBM, i would be hesitant to allow it in at the last minute. In any case, this code has been there for a while and no one has reported any issues - so this can probably wait until 18.11, seeing how this codepath is so popular :) -- Thanks, Anatoly