DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/mlx5: fix a wrong error handler
@ 2017-02-28  8:33 Nelio Laranjeiro
  2017-03-04  0:05 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
  0 siblings, 1 reply; 2+ messages in thread
From: Nelio Laranjeiro @ 2017-02-28  8:33 UTC (permalink / raw)
  To: dev; +Cc: Adrien Mazarguil, stable

The returned error code was wrongly handled causing the PMD to refuse to
start.

Fixes: 91572d2a0b1a ("net/mlx5: fix startup when flow cannot be applied")

CC: stable@dpdk.org
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
 drivers/net/mlx5/mlx5_trigger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c
index 683b57c..0acbf28 100644
--- a/drivers/net/mlx5/mlx5_trigger.c
+++ b/drivers/net/mlx5/mlx5_trigger.c
@@ -87,7 +87,7 @@ mlx5_dev_start(struct rte_eth_dev *dev)
 	if (dev->data->dev_conf.fdir_conf.mode != RTE_FDIR_MODE_NONE)
 		priv_fdir_enable(priv);
 	err = priv_flow_start(priv);
-	if (!err) {
+	if (err) {
 		priv->started = 0;
 		ERROR("%p: an error occurred while configuring flows:"
 		      " %s",
-- 
2.1.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix a wrong error handler
  2017-02-28  8:33 [dpdk-dev] [PATCH] net/mlx5: fix a wrong error handler Nelio Laranjeiro
@ 2017-03-04  0:05 ` Ferruh Yigit
  0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2017-03-04  0:05 UTC (permalink / raw)
  To: Nelio Laranjeiro, dev; +Cc: Adrien Mazarguil, stable

On 2/28/2017 8:33 AM, Nelio Laranjeiro wrote:
> The returned error code was wrongly handled causing the PMD to refuse to
> start.
> 
> Fixes: 91572d2a0b1a ("net/mlx5: fix startup when flow cannot be applied")
> 
> CC: stable@dpdk.org
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

Squashed into original commit "net/mlx5: fix startup when flow cannot be
applied"

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-03-04  0:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-28  8:33 [dpdk-dev] [PATCH] net/mlx5: fix a wrong error handler Nelio Laranjeiro
2017-03-04  0:05 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).