From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5045CA00C3; Mon, 28 Nov 2022 12:12:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B61E4067C; Mon, 28 Nov 2022 12:12:51 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2048.outbound.protection.outlook.com [40.107.93.48]) by mails.dpdk.org (Postfix) with ESMTP id 00C0140156 for ; Mon, 28 Nov 2022 12:12:49 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GUpWHdioGC1lMISFqLBZimxuCfn3/3xgoP0YnD4E/JcjfP74G/jvSsayi2JnqRlTgMBtTjcPW5Grk5aDEq+zxEIdHEKUdWaAPUbuoTWNR6DFkztHlqqL0skLciHrHJoJzakv4bT73BA5FzCMWzn4ryqRkOniVEy+WzKaCrKaMlwse0kaPt7slayJE0AfcJIWZBh76a05v4ORCbPD0tc+L3cbVnj/b4715LG1jDQxE6gqqrFQ6GyYMKYhHLSrWkqwtR3/oI++L6Iu/xByr/YpgfxWc/oZeMvYegi7PzuFNiZ4NMqa0MUPAGapXX77h12JrfRUbpT09mHOHhGkKUxqow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EA385hRhIF+MPFoSUaTAt6Q3A/y3PdaYX9aoEQ/gaTk=; b=hR95yuL3ZPnAYn46HCIjWyJsA6S3Hs72+I7O72BpwjU7Zc0smsVhS4ChniLoTWrmziHFxm4scUrTXzyMA5MLD5HkcyLxDRiOou5weBG89oNTN0oASkXP5EUukHT1Rqji45ev4kxEuUclB133JljL9yzUQUzw9QfMZdliTAsJowIX73IkA//xQSdygvcLgdjzUkiZJo9dKTmCjaXjGiAseea3KJPsjyd5JLFAJRDhvHqyMDSp2LGkHmWQYlSXzsiywLp+b8LzMXZJAmgM/6r73VetrHt3GeaP990KbyhTQ7a94pXYxiQb7zMEb5UweNAJzudV3+NKoJ/ZMqFQu3xh7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EA385hRhIF+MPFoSUaTAt6Q3A/y3PdaYX9aoEQ/gaTk=; b=by1DRcbYJs6jjwY7y8oMBwrMwd4haYrDRJAkYPzgtSCpoZOWGU7gHKrQ3q8lfRJNeULVAUZ/LZJ46VT9jeqb95Svee9ldJN1UMGEv2ULef0XBCLZvQEVDgIx87TT6LGzVKA8+AIADkeAvtYkPayu1Q6E5ul5tStdlnjnPqFSHsI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS0PR12MB6536.namprd12.prod.outlook.com (2603:10b6:8:d3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.21; Mon, 28 Nov 2022 11:12:48 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842%9]) with mapi id 15.20.5857.023; Mon, 28 Nov 2022 11:12:48 +0000 Message-ID: <38d43919-f060-4ccc-67e6-180957015dc5@amd.com> Date: Mon, 28 Nov 2022 11:12:38 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] net/gve: add support for basic stats To: Stephen Hemminger , Rushil Gupta Cc: Junfeng Guo , qi.z.zhang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, dev@dpdk.org, jeroendb@google.com, jrkim@google.com, Xiaoyun Li References: <20221124073335.3985214-1-junfeng.guo@intel.com> <20221124085926.46430390@hermes.local> <12af66b4-0715-a0f0-a401-664632189e80@amd.com> <20221126093433.7b3b5078@hermes.local> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <20221126093433.7b3b5078@hermes.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0032.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::20) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS0PR12MB6536:EE_ X-MS-Office365-Filtering-Correlation-Id: 951b3beb-313f-46cb-03c7-08dad1317a90 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: afrCbf/JPodMuLis/bEDevZy5tEuFVqcha9/0Gm2spjzT2ZLem8izUTee/5Qca7lwhZnjXTUNYBJc6fAEV2TAIT86O5Mj4jRrGB9i/0BYHbjqZVcJDs2WI6YBcWCzPM5iZiPdqV3+ogVm1FKHR+609xvR0YEXTaBHwNfgveibu9s2E6rXcsZN+KSIKLrLstFOa/mMi++ELt5u6oXqxqRQpG3QyHZ2uwZopjHrVDqz1k8RxLA6h/rIzxN9IhN4YcCGoNIA7r7eWZfWHJCG7JXnDkz8vnUKdq1Nde8I2cp0y186BzOURcpjW+NrM+gKftu42Hx2IwiFRNVvKW0vclec7w8R5TPw48qsawXe1rhegNOCFjFaAb3DUPCn+celurGL5sZvS7tshrYbowUMR+XjflPsrqeL+mZGAuG8HStfE+MrxN7gbQHcTk1qN+B7tmZoF5t7s3o8UI41lBA5zeyfcYY5pimK8XcGS9BlPDybZUK4K8YnqxpVOwJkXb0f82yXFhy6JfEasb5lYeZXG9AyFawn8Lkw2PWNz4StObMA6aEewvYyopniIQ+hforvtDHyTvaIStWBD0dC4r/sVGLnew0ax8CkkhTviRBKov/xIDorxx3ajSn3OXFRmPOB4YAmK91yZzlObHmfYFod2daBQW0jlb3XlCOAZ3J7Zb9zefbVDx0rkKshswNSo21sw14BrTRiHfL3X8Qlk2AfMpmgbsU3eHP1pEUbTYFYE2sYtbyQ3T6mwtMLjjnrQ/ZoCki X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(396003)(366004)(136003)(376002)(39860400002)(346002)(451199015)(2906002)(31686004)(8936002)(7416002)(31696002)(86362001)(2616005)(186003)(44832011)(36756003)(316002)(5660300002)(41300700001)(66946007)(38100700002)(66476007)(4326008)(66556008)(8676002)(110136005)(54906003)(6486002)(6506007)(53546011)(83380400001)(6666004)(478600001)(26005)(6512007)(21314003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZlViMG9TbVhpL0hTckZ4QlF0aXA2eGkwbW5wSjZyQ2tMaWtWOVhCNTJLblpT?= =?utf-8?B?bThtbjNIUW52U1dTWVoyTjlQQngzRTZFaFNiVGRuRng3VmFrbXljc2lTeUJI?= =?utf-8?B?TnNiSHBYeThnS2xibGlheUVvZ2h4cG9CUXc5Z2RIcGE1dGc1WlRHTklDMllj?= =?utf-8?B?QlQ0YmRkRVlEeXY4L01ELytvOWhBSEp4SS9nMk01eGovc2ZrcmcxNklONlZJ?= =?utf-8?B?c0JianBLRlRqczBRbUZXendLOEZwRW8yUld5N2V0Wko3RlYrWHdHOUFwUGFO?= =?utf-8?B?d2ZRT3dhOHU0VDFySzI5UVpIdDZrL3BtUFlwOTg5OFRFb0pSSDRqVFZBYUVw?= =?utf-8?B?eW9vMEJzQi9PUVl6aldUdUVrM0FtZExLK29LOE1SNlovUW1QUURoMWVXK1Ew?= =?utf-8?B?Uks4bC8yNmZsemhSR3R5Z1FGSDRpNXFwcExzd3JvQmhtZUorS0E5SkUzUS9S?= =?utf-8?B?elA2d2tzWEFqa3hSQVh5eHVqQWJ5MWp0aWlKSFgrSVlrRXVHREJrL3drNDFw?= =?utf-8?B?cFJSMDljUFFkR0M0dDFIVlY0bXFVbGtSZmZxS25pRnkxVFZPY0xyQ0p2WG55?= =?utf-8?B?WkNhMFB6NHF3NDF3MDlYUjhBZjVWMDNBSlMyVEhDVnI2WThpeFVjdGh6dXE2?= =?utf-8?B?VWNRSXlFTi9ac0FXcWk2SmluMVBtNTBGb1hIQUxGL0loZjFVMGd1ZFpQSExw?= =?utf-8?B?Ynk0M0x1RDJnaXFnZk14WUtsLzZ1bk1EV25XR0FYbWZYNE80RHJPOXZObito?= =?utf-8?B?TmVoakg0ODlzSktVNTdHamQ3OWRST1dMMzE3QmJSeER5bngxYnp5VGRLQVVl?= =?utf-8?B?V2wrbTA1NUhPdTUxWWVZL1AvZFRyWGk3a1FhWENNTTdTb3h4RUwzZS94K24z?= =?utf-8?B?dlhOdHhBZW1mOEU0clRPNUJrVlNPQVJHSWR2Tm9pMkdpbFBOMzd0bU1EckVG?= =?utf-8?B?NjVHcWpUMXc3N2hWQVNMNzZwUytHSlpXSXJ2ZFJJYTJPYW1GR3lDUC9NeUNT?= =?utf-8?B?WjBOcW11S2ltZ1F6ZFBPdWRyV1NoVUZvTGJKYjVKVktiejF4YmNBMDNZOW1X?= =?utf-8?B?NVJ2eXZsblNMb2xQRldkSWExOEttUlNXNGhoQUFYUGJSOTZObnNKQ1ZLUGNk?= =?utf-8?B?NE1UdzlsYzE3TCtwRlcvTm5MckVPMXk3Q1B1VzFTZWIyYlRjTU95WDJZR0Fl?= =?utf-8?B?TmZvVEVQeldUQmJmenBTMzluTW5Jd0NDUjRYTXc5VWc5WjZmZzBqREpYOG1t?= =?utf-8?B?NFducnBXaTR3enRleThxNDVmaDVDUkRrQmVUcGVhL3dVR0xvNCsxOXZwT2tZ?= =?utf-8?B?bHRSY01ET1Fpc1pjM2taVy9KaW9vWmt5c08xYVFpZDRsL1p3b2wvdVhleElX?= =?utf-8?B?b1IvS1htQ0tYS1E1b3o2VlZWZ3VSSEE1K3hUdUNOSS95aExJUXJPa2QwY3pD?= =?utf-8?B?amhiR2RBb3ZESkxkWXBCbTd1RE9uMmRYbTJzTmkvWTF0TGlkeGRyQktUZEJu?= =?utf-8?B?YkJJWDNQZGQrZTZCUmhFV0tuS3A0K3h4L05Ua0JxVTVWMVFaZzBMa3E4Skxs?= =?utf-8?B?NkI3SjlDdzB4dUd2L1pZZTRyUGpDTHI1TFZLNHlHRmtTK01FU3E1Q2s0cDB2?= =?utf-8?B?eXBGQ3gzYTVOcXl4STFnSmdVcGpleTBkOVBLZXllL2Z4QTJPMFhBeTQrUERx?= =?utf-8?B?Vkc0dG9PYVg4SzVTeHBYcE1JUEN2cnp2d2IzYU9iVklEWFFjV0J1dzBUc1pL?= =?utf-8?B?UHFmMlF3bnNGZ2FWb1dPcjFFcDNnYmhYTkVSY0ZjVmVsLzZWSk82TC9iOGt6?= =?utf-8?B?cHcxZ0EvWXoyK2x3NWQxenV3czBMK3F0U2Jzb0pDRHovMUo4U056R3FVNGVS?= =?utf-8?B?a0NjRzVRaVo0TS9zNkR4WkJZc3U3dS9JRFZFbEVPeGZuQU1CVTZUbkdUNmFX?= =?utf-8?B?bUVPS2JRSFFTbUdkd25ZakZyaEc4NUZLOWI5dFRVdm15Y29KTk9vekNabjBJ?= =?utf-8?B?NFRndWdOVmJ0dDZKbFBIS01QTUFRcHdjbUZhSHV6RzdLV0FVNGc5bmJLNHRL?= =?utf-8?B?aC9GUC8zVlpqL2VIQkpaS2pueTlHcFRrTXpsK0dRWStBQjV1RUR6d0twNE1i?= =?utf-8?Q?6AW13lMVNXf1ODy3bmaxW+zxa?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 951b3beb-313f-46cb-03c7-08dad1317a90 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 11:12:48.0761 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LFpLHtL8pjFWlzBAALmda7nB8tNzeOuWyUNZEleePzo12nu5bBUmwLMmAaTYtAA8 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6536 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/26/2022 5:34 PM, Stephen Hemminger wrote: > On Fri, 25 Nov 2022 19:16:00 -0800 > Rushil Gupta wrote: > >>>> >>>> The driver should be filling in the per-queue stats as well. >>>> q_ipackets, q_opackets, q_ibytes, q_obytes, q_errors >>> >>> >>> Hi Stephen, >>> >>> Queue stats moved to xstats, and there is a long term goal to move all >>> queue stats from basic stats to xstats for all PMDs, and remove interim >>> 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag. >>> >>> That is why request to new PMDs is to not introduce queue stats in basic >>> stats, but in xstats. > > Agree that xstats are better but: > > * the current checked in version of GVE does not have driver op for xstats > > * if driver fills in the q_XXX[] stats then eth_dev_get_xstats_basic will be > able to use it. > That is an option, but it will require driver to add 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag what we want to get rid of in long term. That is why we are requesting new driver to add the xstats implementation instead of adding queue support in basic stats. It is up to PMD to provide xstats implementation if they want queue stats. > The per queue stats are limited to 256 queues and bloats the info structure, > but until an API breaking change is made to remove them, drivers should support > it.