From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21153A04A7; Mon, 24 Jan 2022 12:02:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 82C3C410F7; Mon, 24 Jan 2022 12:02:56 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id A834F40E0F for ; Mon, 24 Jan 2022 12:02:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643022174; x=1674558174; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=WOxY1DpovIgjFlTidD3lBuBNKW3xVSp+idgvgmaO7Zo=; b=L9Qdh4gIqRl2y9roWd/c3pRXGAdDtQjbaoEqIVyahxix06TgZdxEF1eG X3q3Qmzs6TqyHs1Fw6L7Q7+CS4sXn27LPpmQjOtpAO/ZgsSkondUlwY4L qo/g9sHCo9NmZKMgTnxJPc6ZnwqMyG7oKBOVG7Sq5we8WGE5SIB70yBkE ui4sP+9fGsS8Gha+DnDqOsZQChl+3pkO1zzVQxZpbNzLZt20ypUrhYxnN TfwdXPL9Tj1ZdhbEWNYTdyxKNi2c/aqJWPGf59l5ShSqhk250bsJt5OUN 8eQ7pTTLBqBoICHh5cSR1KiWQ0eRrBugQki2jGqb2ieCOqQ0fTpuLZRmb w==; X-IronPort-AV: E=McAfee;i="6200,9189,10236"; a="309340301" X-IronPort-AV: E=Sophos;i="5.88,311,1635231600"; d="scan'208";a="309340301" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2022 03:02:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,311,1635231600"; d="scan'208";a="617196222" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by FMSMGA003.fm.intel.com with ESMTP; 24 Jan 2022 03:02:53 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 24 Jan 2022 03:02:52 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 24 Jan 2022 03:02:52 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 24 Jan 2022 03:02:52 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 24 Jan 2022 03:02:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z0YWH01uhSGl8JeRBdxUNHdTRPobmvxnzrBXMQOnFHH9RrbRIdCzHvJak/iDQJqr2kbNdqJfSd1PoRn6tKrkmLTn8pDiaYC6iYUOmgvxVTMOuA43cugQRd8npSPAV1QLfriHArSWa9zsl3FY48MGnKHDJ7sHl+3zaQ9UL3D0C4cdsbSAr25XowUpc7v4CwcCQOAp+yRXyyYW0egygSN/lNO36erTm2HnCE8km39/qRk5rNZ897DnpSyab2rzxFdTLrP1kLTyGij7KVG0LS3A6ukfprFmi+aWIGic7E0T0JEvYveqUCm4zXkldOkOgsM/CrzxgkEEwdYv17idsstXBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T5taBFlRsqX4VThMeIG7lcTNfRYhUrAVVFbgJeLLtJ4=; b=HLx0QWTszIZbp4PiTzGAAUYHDGV6g1XbFJIYzjEk0Ekic6/4h3CAdJFPkLEUu+FUoasbbcXJosEGdiHP7kIvfGkQeNgMMyEmBFztcmvuzl2Z9uktnwjudI5SWnUDQYyf1dcNROVTNEDm0MDqqnNmS3wbbO06d+zKMUlUnHcNrREBiHKEvc0pgiPZ0bRLS68qvn5GlKkXUdnfUgS7gyHxf/ErpGEBUlzdKBooUeCODVRrduvnB7Seslg6ipQMZRrrSlmR/QeFde+3KHSSkNXbczm/Lw9hGS4LG40V09uzsWynxvecZYDeWA1XeJLbm8HzttUwfuO4WKPMrRqLxxwxJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by MN2PR11MB3648.namprd11.prod.outlook.com (2603:10b6:208:f0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.12; Mon, 24 Jan 2022 11:02:50 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4909.017; Mon, 24 Jan 2022 11:02:49 +0000 Message-ID: <38df8f4a-f0ce-ef47-d57b-ac65397b5dec@intel.com> Date: Mon, 24 Jan 2022 11:02:43 +0000 Content-Language: en-US To: Kevin Traynor , Xiaoyun Li , , , , , , CC: , Sunil Pai G References: <20211015051306.320328-1-xiaoyun.li@intel.com> <20220106160333.762686-1-xiaoyun.li@intel.com> <20220106160333.762686-3-xiaoyun.li@intel.com> From: Ferruh Yigit Subject: Re: [PATCH v5 2/2] testpmd: fix l4 sw csum over multi segments X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0202.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::9) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eca42d24-716d-4353-1cc8-08d9df290f76 X-MS-TrafficTypeDiagnostic: MN2PR11MB3648:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:813; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hfcz8ylvNM5MN5fYEdjMlfnxT4jOXuT2bypHpVWoQHzs19sllwj2v4LCYwntSoZj1Nnlj2hFBrXmZujBcpGcrkhg41YcrZPKSI3DdM40AuEErMLkA6Od+24w5Yx4w6hURfjH/vouzVmzhmIyeHhexAvAnES3HKWOowKZb2bD+jfOst6tWIYJNVVtChKmeZWTktJDSlNtZtj32uaQGmkJSLXLpso1XUtpbxzDYTkdemXsbrtJINob12ulF3vh/P/weBkTTvd2UpyHhHCpDSMBqMWgPUx2KTqy0R6AKaeuBJAXYPfNHBOST6wAfO7Du6Uvyfhs1FblNIApcCHZwD4BM5vbU6MBQmgQ9/vJCun6NofTKsLXU4F1UiB5GApkTNv3TgWVws4L9/xnk/9bppqDvAJOamCC/X7ltNKg+Tlf/Vf+dYmKAJjRLeCavtC3vxtJQ5ryfszaDlbdYnDTtiXcNHJMYD1pdEvfqKuFetab4XhtgEisnt1yRpMwlaouIY64u7yCEyrAwabnlY9aCB3GpjHuvNnNLlOkFTFy3kPzQpraFy3+NOB38zfZvT7kSRJlcdYHNAwLbUzOENwrngD5bdwNG7qqdz5tz2zszh6Q+aZTrg1+pSwWicn1TQZQ0u71vKH2psOXAXqnfigB5W1yu+gWhQb78Yq3InJmdGBeoWGwMxfJAYyMAEturM8wXv2xWMzSLYxmMsZZXUmM5Rkg+g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(110136005)(66556008)(66946007)(44832011)(316002)(31686004)(36756003)(66476007)(82960400001)(38100700002)(83380400001)(8936002)(5660300002)(508600001)(8676002)(53546011)(6512007)(186003)(6506007)(6636002)(86362001)(6666004)(2906002)(107886003)(6486002)(26005)(4326008)(31696002)(2616005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YTJaT1pjaGFWa2pRZzVldHA3VENQUEMxQXhRM1E0MzhaK3daSjlTc3MwcnI4?= =?utf-8?B?b1F5aXFaOCtGVjJCRS96OHRJczNHQXd2cGtFekZZSEIzM3MxckRqT1RHUzcw?= =?utf-8?B?WFA2WWZSL0RTdHQvbm94emp1eTZlNDdsRDdYeEc2OWpGNGxnZUtnNnEyaWlt?= =?utf-8?B?L3phVG5XaXBXZDJoQk0zUmo0VzU0YVZxR3dSZnUyR1JyRU5iaWlCdGVLdTZo?= =?utf-8?B?OGJnNnZ2K0diMTdpNTVBcEplakJBZlVnK3ozMEhiZmk2WEpwdXRtYVNsRllh?= =?utf-8?B?Z2xzTVlrM2poSmZsN2pQeGFZWkVTWG0xam1WdlVDYnoxSlYwV29XVlpvRWsz?= =?utf-8?B?L0tDWVpwL2RHRmg2SUNHVkFPZWg4d0pGNUVtcmc4UjRDVEw2dXVVMXlXUFFC?= =?utf-8?B?ZTQvQU01YkdqS3dHa2I4ajZ4SUVkOS9WTW9JQk0veHc4ZjVjZGFZYWJObUdF?= =?utf-8?B?SWc0MlRFUlVJUjNTTzhScG9QME9HSDB6a3FwSmp2bDQ2KzBxR09zd0JYbWVn?= =?utf-8?B?TlBmZjNIVWFyYlZ1enJKTnJOTHB6RCt1SGNHY1FjWlpSZnB0OHlpZ2lHRkp2?= =?utf-8?B?UTRHdVFBVWl0TlczNXM5QXhCVlNzd1RQcjZ2T0lNMlRQRllkOXFTNGl6b0dh?= =?utf-8?B?ZVl4TGZ4SE9CQ0NpR0pST3NncC9pamh5ZW5LVmhNNHFZL05WdzNtZk1IWEJx?= =?utf-8?B?d0lVNmJOMW9vZkFNTEpPSXEvcW81SndOL0g0VlR3VHZicm1SWGZVZHRZYksv?= =?utf-8?B?clBhVVYxaTI5aU1aR2JFNW1Fb3dXRXlQOXhPdi8zVlZUeG80b2hncHlJTzA5?= =?utf-8?B?bHFZQVB2YStsWklmYzhEakRsV1E4TFJlejh2Ui9uK2VsZ1dCQWh0bDEvUTVB?= =?utf-8?B?VUs5V1FIRGtQYVFCY1lPYkdyYUdBa285WVFrdS9MZ2UvZFRDUXBiRXRnUXo5?= =?utf-8?B?L1RCV3NCbEZZUldkOGJWT0JnTGJ2NGtNd0JwZTB3USs0ckhQTGFYSUlLekRw?= =?utf-8?B?dEFiOUFBdXF4WmlLenJZaWdwUjRublZBUExjTk1KdFBkR0N0TDMxVERSS0tY?= =?utf-8?B?bkFlL01GcU9XMVVzWnNpTzJueEtMRG5PV2djVWpkUXZGelIvUVNvZ2xyN1dj?= =?utf-8?B?c2xMTFBCYnBOYXNKL2UwK1E1b3ZVa2JuY1N2UEkvY096aW9PN1R4TVg0VENG?= =?utf-8?B?VldJcnVRRGF0YUJkSTdqTjJGZWdvVDlxMkROSUJNMGZnWTFLeGhOZFV5SDJJ?= =?utf-8?B?WXdqR0JpVjlTWDU1ZVQybXZqQ1BweHRyWmV6VlRpWVlQckdoNWRoWHl6bTFu?= =?utf-8?B?SjFQcmdCSlVaYXJhRTJ6UE9nbHUvVW9LMUI0WTJUWExHWGNXOUxhQzN4b1p6?= =?utf-8?B?WGtOL3RFOXU1N1dBWkVmZThWQ1Qvako2TlFuc3kvUmFhZ204QWYvbmZ5d1Nm?= =?utf-8?B?YlR6cE5lYmFvR24yNmRrdzB3N0NhM0NHTTdQNzloK01wcEFzOXBLVndjS2NY?= =?utf-8?B?TzBMQWtnZ0IzUW1GelRLbXZxclo1MzBPVVBxZCtNeGxNeFMzR0U2ak53WEly?= =?utf-8?B?bjI2Nm9KZmJKR3ZHV29TUysxRDhmNVRkUXN1UUpYY3VyUEM4UE1aWEFldFRS?= =?utf-8?B?YW9MOExrb3VCOWcyelhERVBsU2d5MVNVcUFZSjlXMGszakJuTVlyRUlTSzJt?= =?utf-8?B?Q3B3aldqOWRVU1IzZTMyWjRyY0NWQUx2VE5FSEtWT29jU2J2TjJNa0RTN2th?= =?utf-8?B?ZnhkeUNYZkxhUFhGSUlpL2MzWXd0bFozaCtWNU9abDNEUllRY0dDTSsxU3JK?= =?utf-8?B?RzRUQWhCbnI3MWtnSlBhNjdLelY1K3dRVE1WVE0rWUNLRk53NVVrN3E4MTEx?= =?utf-8?B?U1BkQ1NzcUhJRDJ5bWZvUlR1U3F5UFZEdWpXQkpob2Y2d3dqOUlrZDFWNWg4?= =?utf-8?B?M2VjelltUFVjdkswaXNUZEU5MHZINDVsOUFtQnZZNmYwdTR3QUk2eGMwNFBi?= =?utf-8?B?b1FtYjdPbHp3Z1ZHRGVPNTRSNkVIamNEK25xeW04MlU1b0xHMGxpZFpxWkpT?= =?utf-8?B?c2FqSEhDYVIrMUx2Vk1NRkp6NG4xeU1yb2pKZjc0Wk4vbkNPWmRUcy9CR25I?= =?utf-8?B?MkpsZnlpa2NjbEZxais3SXhUNGJKZ3VTMTdkOCtoeDU4bi82MlJpcWtwdGF4?= =?utf-8?Q?gqao+h1D171C2sfcRr/M9cs=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: eca42d24-716d-4353-1cc8-08d9df290f76 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2022 11:02:49.8343 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gyO628WAlnVxESRRwv9VtAWbiwtHpioTFKx7yfDed/VmH0d1MRJEU8o1L/eGkL419pxT+zkrWd5shVdXzk5MWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3648 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/24/2022 10:30 AM, Kevin Traynor wrote: > On 24/01/2022 09:16, Ferruh Yigit wrote: >> On 1/21/2022 5:09 PM, Kevin Traynor wrote: >>> On 06/01/2022 16:03, Xiaoyun Li wrote: >>>> In csum forwarding mode, software UDP/TCP csum calculation only takes >>>> the first segment into account while using the whole packet length so >>>> the calculation will read invalid memory region with multi-segments >>>> packets and will get wrong value. >>>> This patch fixes this issue. >>> >>> There should be a 'Fixes:' tag and assuming you want this patch backported to LTS, 'Cc: stable@dpdk.org' too. >>> >> >> It can't be, because fix relies on new APIs added in this release (patch 1/2). >> > > ok, makes sense, thanks. Do you think it worth adding a Bz for it and listing it as a known issue in 21.11.1? > Was discussing with Xialong, it is in the gray area that if this is a fix or new feature. It is not the case that initial implementation says that multi segment mbufs are supported, in that case this is not a fix but enabling multi segment support. So perhaps better to update commit log in this way to prevent confusion for the fixing and fix tag..