DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Yao-Po Wang <blue119@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] kni: use netif_rx instead of netif_receive_skb in which ocurr deallock on userpace contex
Date: Fri, 11 Jul 2014 09:45:20 +0200	[thread overview]
Message-ID: <39030235.AJ30siSIub@xps13> (raw)
In-Reply-To: <1405011865-26028-1-git-send-email-blue119@gmail.com>

Hi,

Thank you for sending this patch.
Please, could you re-send it with a more detailed explanation and a
Signed-off-by line?

There is a how-to for patch contributions here:
	http://dpdk.org/dev#send


2014-07-11 01:04, Yao-Po Wang:
> ---
>  lib/librte_eal/linuxapp/kni/kni_net.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/linuxapp/kni/kni_net.c
> b/lib/librte_eal/linuxapp/kni/kni_net.c index d3c0190..28cc5ab 100644
> --- a/lib/librte_eal/linuxapp/kni/kni_net.c
> +++ b/lib/librte_eal/linuxapp/kni/kni_net.c
> @@ -179,7 +179,7 @@ kni_net_rx_normal(struct kni_dev *kni)
>  			skb->ip_summed = CHECKSUM_UNNECESSARY;
> 
>  			/* Call netif interface */
> -			netif_receive_skb(skb);
> +			netif_rx(skb);
> 
>  			/* Update statistics */
>  			kni->stats.rx_bytes += len;

      reply	other threads:[~2014-07-11  7:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-10 17:04 Yao-Po Wang
2014-07-11  7:45 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39030235.AJ30siSIub@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=blue119@gmail.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).