From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com
 [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 9D0D7B37C
 for <dev@dpdk.org>; Fri, 11 Jul 2014 09:45:06 +0200 (CEST)
Received: by mail-wi0-f180.google.com with SMTP id hi2so878336wib.13
 for <dev@dpdk.org>; Fri, 11 Jul 2014 00:45:30 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=izRUcM/6Z4tCFXSbV/PbKa7WNkZSYKdGa+wVeHb3VFA=;
 b=WodNK3KFnm7fm7DJs+IPMTCNMt4/7DSImDEW8S9mGYaPcPBmR2HPPZ94P6T34v/87P
 AC4PDb+xInSf6UtHuCNSQy0n8+Xpa8O8hF5ZLSe/dK4JUTwhOyxxxM6iSwu4CgOxCTAZ
 TWkRDf5MZrDzR8l3lw5+bcCHuQBnCvLxB87fGg9JpwQ1Yx9U2lHi8MRm6BpqdAbn0+SE
 8vzyjnuJJPjokrA3yc9vgV+NkwAM9m/r11W5J4ObPo3jackkawdgZr3QzTTwqqMVvv4i
 5Nu9+l9My+04O7LORnUDFqsueP4O6qTpCBjExs86J+vuUXq1xskiGxcDk5RLkSWMoLZF
 ce4Q==
X-Gm-Message-State: ALoCoQm6bWPM1/YU+Lm1Ta718Hz/kGGGQuS3heyEEi0+KqoLPgpF+33jZLqVHMBr6Lu04utFQq3t
X-Received: by 10.180.206.109 with SMTP id ln13mr2778785wic.17.1405064730121; 
 Fri, 11 Jul 2014 00:45:30 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id gi15sm3451511wjc.20.2014.07.11.00.45.28
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 11 Jul 2014 00:45:29 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Yao-Po Wang <blue119@gmail.com>
Date: Fri, 11 Jul 2014 09:45:20 +0200
Message-ID: <39030235.AJ30siSIub@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; )
In-Reply-To: <1405011865-26028-1-git-send-email-blue119@gmail.com>
References: <1405011865-26028-1-git-send-email-blue119@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] kni: use netif_rx instead of
	netif_receive_skb in which ocurr deallock on userpace contex
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jul 2014 07:45:06 -0000

Hi,

Thank you for sending this patch.
Please, could you re-send it with a more detailed explanation and a
Signed-off-by line?

There is a how-to for patch contributions here:
	http://dpdk.org/dev#send


2014-07-11 01:04, Yao-Po Wang:
> ---
>  lib/librte_eal/linuxapp/kni/kni_net.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/linuxapp/kni/kni_net.c
> b/lib/librte_eal/linuxapp/kni/kni_net.c index d3c0190..28cc5ab 100644
> --- a/lib/librte_eal/linuxapp/kni/kni_net.c
> +++ b/lib/librte_eal/linuxapp/kni/kni_net.c
> @@ -179,7 +179,7 @@ kni_net_rx_normal(struct kni_dev *kni)
>  			skb->ip_summed = CHECKSUM_UNNECESSARY;
> 
>  			/* Call netif interface */
> -			netif_receive_skb(skb);
> +			netif_rx(skb);
> 
>  			/* Update statistics */
>  			kni->stats.rx_bytes += len;