From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 7C06A6CA2 for ; Mon, 16 May 2016 18:34:12 +0200 (CEST) Received: by mail-wm0-f49.google.com with SMTP id g17so145017982wme.1 for ; Mon, 16 May 2016 09:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=jzKVKEAQuHxOn8B24BB5WB2/iuMdirzNkMDaPWiuwcQ=; b=tRrOBqbLrocyqn0ixNTQRwifpFdlGLzZmgUhis5I69ev8gIyxjMcwo1Nfsjq+rJU+o mGOojGAyCXKR77whgBgRh5fYQefeTilwK/5BwKDmp2onceWoFcDbAZM4AWBfxrwpbcCu +7jJzYWQ/i/mb5eT46Rdpw3Pj6lqj1iplXutb+v6dgce3V+zXyyOAXJtakiP9WVLurPw pilY0pgVvgcIVFAjl6Dy4qWDkGthLadeWEQqzAF+gNaiXQY7ph2dFxmyDQXA2TVXG3Mk KMOScgvIfI0OyA+idOKQpShmck5rXi9ebFOOXl7h5uFMzP7vYQ04zEYSIvFBcqInhTLt zsXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=jzKVKEAQuHxOn8B24BB5WB2/iuMdirzNkMDaPWiuwcQ=; b=Eor6VBq0W35lfLnfAqQiv3V99oAfm6m7IIpcXX7txd+BxC4MOCiX8WnkFYSQX4xIBl u/L9r3v/tNS6C/PxlS2FZMHEXvINQXRa/tETEJVgitZ8T2A1Gq6rlG3zYixYe972ZO8G Jfw2c3TlE9lvlSgfBGj0G1Y4IhJEc+MCATHDrJH0pJvLarYkHML+mvmAVTzmqG8a08eH SHhcqKndCXy5gtsHA58CjbQkM9Hu7DWFyFGvk4OAqgTGQDpwtpXhBIhDNKhDcuucR3IJ 5HdSxVhSAKBYz+xjGoFXfGOl5yGcErRmS+6yaCkXZNKa/0OJCfuPFzkiWkYEeJymhBmY B0dA== X-Gm-Message-State: AOPr4FU4oAKtDVeqT3om/NmewKgXgNUOMgMiiC3Rm0mAy7HPTaXWaf2yt9HETQH0v835WN/t X-Received: by 10.194.216.65 with SMTP id oo1mr28352083wjc.97.1463416452313; Mon, 16 May 2016 09:34:12 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id he10sm34657348wjc.21.2016.05.16.09.34.11 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 16 May 2016 09:34:11 -0700 (PDT) From: Thomas Monjalon To: "Dumitrescu, Cristian" , "Mrozowicz, SlawomirX" Cc: dev@dpdk.org Date: Mon, 16 May 2016 18:34:10 +0200 Message-ID: <3903086.2L5T4XfrGH@xps13> User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D89126479BB334@IRSMSX108.ger.corp.intel.com> References: <1462956485-3701-1-git-send-email-slawomirx.mrozowicz@intel.com> <3EB4FA525960D640B5BDFFD6A3D89126479BB334@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] examples/qos_sched: fix bad bit shift operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2016 16:34:12 -0000 > > Subject: [PATCH v4] examples/qos_sched: fix bad bit shift operation Slawomir, please use --in-reply-to when sending a new revision, to let us see the full history in our mailer and in the archives. [...] > > diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c > > index 3e7fd08..354372d 100644 > > --- a/examples/qos_sched/args.c > > +++ b/examples/qos_sched/args.c > > @@ -123,7 +123,7 @@ app_eal_core_mask(void) > > uint64_t cm = 0; > > struct rte_config *cfg = rte_eal_get_configuration(); > > > > - for (i = 0; i < RTE_MAX_LCORE; i++) { > > + for (i = 0; i < APP_MAX_LCORE; i++) { > > if (cfg->lcore_role[i] == ROLE_RTE) > > cm |= (1ULL << i); > > } > > @@ -142,7 +142,7 @@ app_cpu_core_count(void) > > char path[PATH_MAX]; > > uint32_t ncores = 0; > > > > - for(i = 0; i < RTE_MAX_LCORE; i++) { > > + for (i = 0; i < APP_MAX_LCORE; i++) { > > len = snprintf(path, sizeof(path), SYS_CPU_DIR, i); > > if (len <= 0 || (unsigned)len >= sizeof(path)) > > continue; > > diff --git a/examples/qos_sched/main.h b/examples/qos_sched/main.h > > index 82aa0fa..c7490c6 100644 > > --- a/examples/qos_sched/main.h > > +++ b/examples/qos_sched/main.h > > @@ -68,7 +68,10 @@ extern "C" { > > > > #define BURST_TX_DRAIN_US 100 > > > > -#define MAX_DATA_STREAMS (RTE_MAX_LCORE/2) > > +#ifndef APP_MAX_LCORE > > +#define APP_MAX_LCORE 64 > > +#endif > > +#define MAX_DATA_STREAMS (APP_MAX_LCORE/2) > > #define MAX_SCHED_SUBPORTS 8 > > #define MAX_SCHED_PIPES 4096 > > > > -- > > 1.9.1 > > Acked-by: Cristian Dumitrescu Cristian, please remove patch content when acking. My hand is tired of scrolling ;)