From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 41BF01DB1 for ; Mon, 7 Nov 2016 21:14:55 +0100 (CET) Received: by mail-wm0-f53.google.com with SMTP id t79so199717530wmt.0 for ; Mon, 07 Nov 2016 12:14:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=aQc/fTFS95vxHW4nyskBLK17hS6huqDlNXOagcrZJfI=; b=gVVqya3PK/Ge1/z11bwau2S1KT6QRuUeT0Wf0B/9GpaNdpH9ONYIGsAc+TJ/ODbi0J dzqiJBKiFKopAI76BgXp+KpxbCyJbbymCYpCQCeA4C+fVS6nA7pb7TjVrIYXrlHM1XG9 CRvIbQJzVRkDYZnR+2Xk5HCj4sdQ8FKHjSz/6jINuHKTAOIiWmuna0A0P3BLwjcq/e2F /HSHRja+9DJz/EU67mG/yOpHoOdsFjVlM0OODlkS4X1C2fJ4YaSX1F1f5u9xex1l6AbR dKvVU7YkEwU0r/JUh1RC91231YLxTzb3xgpVVMAMbi6CAN92teadDVDwt4hdm52xPKV0 jyPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=aQc/fTFS95vxHW4nyskBLK17hS6huqDlNXOagcrZJfI=; b=XHtfXEcWJF/oITrbeLuTGEanU3/FL0eOcFO0Ku056OX2jMp1Y9WSqB6ImJFfxAr2fv qcqoC5lPFjTb9hZytonBiXXXueSsW75NM1i0/8gl9JJCn1XiPGbN2x2JkDrsQLGTLcOC cfiVxgFHKhT7bvSpsy0+Cm/Vmbm1RfwaiXlt5Hsw5OgA9m5VWwkVzbbuTbCg9Xd7GIq6 U73SDjIvG0s1QVth+FMrXymZvnY6iaPmJPwqZjAEaLUOxXsQ38D4XHKnIcXMukrh8bu5 1fVea4gIGc1ZJu+y4va91KXWxAv6z6YzRdKFn04zTANFCpETkmpC/SPYjRnyhMXJxaes /Icg== X-Gm-Message-State: ABUngvcEZcX9xnouuQQFFYTw7brDU5gb26C3+cdxie/PWFH4AcWyVQnHylN9r8riN5xXh0HJ X-Received: by 10.194.104.232 with SMTP id gh8mr7117301wjb.49.1478549694943; Mon, 07 Nov 2016 12:14:54 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id cl10sm24486395wjb.4.2016.11.07.12.14.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Nov 2016 12:14:54 -0800 (PST) From: Thomas Monjalon To: Yong Wang Cc: dev@dpdk.org, stephen@networkplumber.org Date: Mon, 07 Nov 2016 21:14:53 +0100 Message-ID: <3903659.xK46R3T4LA@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1477503907-11306-1-git-send-email-yongwang@vmware.com> References: <1477503907-11306-1-git-send-email-yongwang@vmware.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: fix mbuf release on reset/stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Nov 2016 20:14:55 -0000 2016-10-26 10:45, Yong Wang: > During device reset/stop, vmxnet3 releases all mbufs in tx and > rx cmd ring. For rx, we should go over all ring descriptors and > free using rte_pktmbuf_free_seg() instead of rte_pktmbuf_free() > as the metadata of the mbuf might not be properly initialized > (initialization after mempool creation is done in the rx routine) > and the mbuf should always be a single-segment one when populated. > For tx, we can use the existing way as mbuf, if any, will be a > valid one stashed in the eop. > > Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver implementation") > Signed-off-by: Yong Wang Applied, thanks