From: Thomas Monjalon <thomas@monjalon.net> To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Andrew Rybchenko <arybchenko@solarflare.com>, Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru> Cc: Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>, Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 01/11] ethdev: change eth dev stop function to return int Date: Wed, 14 Oct 2020 15:33:49 +0200 Message-ID: <3910167.mFdbjSblXh@thomas> (raw) In-Reply-To: <1602682146-4722-2-git-send-email-arybchenko@solarflare.com> 14/10/2020 15:28, Andrew Rybchenko: > From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru> > > Change rte_eth_dev_stop() return value from void to int > and return negative errno values in case of error conditions. > Also update the usage of the function in ethdev according to > the new return type. > > Signed-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru> Please no capital letter in the email address. > Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> Thanks for taking care of this cleanup. A note in the API changes of the release notes is missing. Except that miss, Acked-by: Thomas Monjalon <thomas@monjalon.net>
next prev parent reply other threads:[~2020-10-14 13:38 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-14 13:28 [dpdk-dev] [PATCH 00/11] ethdev: change device stop to return status Andrew Rybchenko 2020-10-14 13:28 ` [dpdk-dev] [PATCH 01/11] ethdev: change eth dev stop function to return int Andrew Rybchenko 2020-10-14 13:33 ` Thomas Monjalon [this message] 2020-10-14 13:40 ` Andrew Rybchenko 2020-10-14 17:29 ` Ferruh Yigit 2020-10-14 13:28 ` [dpdk-dev] [PATCH 02/11] test/event: check eth dev stop status Andrew Rybchenko 2020-10-14 13:28 ` [dpdk-dev] [PATCH 03/11] app: " Andrew Rybchenko 2020-10-14 17:34 ` Ferruh Yigit 2020-10-14 13:28 ` [dpdk-dev] [PATCH 04/11] examples: " Andrew Rybchenko 2020-10-14 17:38 ` Ferruh Yigit 2020-10-14 13:29 ` [dpdk-dev] [PATCH 05/11] net/bonding: " Andrew Rybchenko 2020-10-14 17:45 ` Ferruh Yigit 2020-10-14 13:29 ` [dpdk-dev] [PATCH 06/11] kni: " Andrew Rybchenko 2020-10-14 13:29 ` [dpdk-dev] [PATCH 07/11] test/bonding: " Andrew Rybchenko 2020-10-14 13:29 ` [dpdk-dev] [PATCH 08/11] app/flow-perf: " Andrew Rybchenko 2020-10-15 8:04 ` Wisam Monther 2020-10-14 13:29 ` [dpdk-dev] [PATCH 09/11] app/testpmd: " Andrew Rybchenko 2020-10-14 13:29 ` [dpdk-dev] [PATCH 10/11] net/failsafe: " Andrew Rybchenko 2020-10-15 10:37 ` [dpdk-dev] [PATCH v2] " Gaetan Rivet 2020-10-14 13:29 ` [dpdk-dev] [PATCH 11/11] ethdev: change stop device callback to return int Andrew Rybchenko 2020-10-14 18:08 ` Ferruh Yigit 2020-10-15 10:40 ` Gaëtan Rivet 2020-10-15 13:30 ` [dpdk-dev] [PATCH v2 00/11] ethdev: change device stop to return status Andrew Rybchenko 2020-10-15 13:30 ` [dpdk-dev] [PATCH v2 01/11] ethdev: change eth dev stop function to return int Andrew Rybchenko 2020-10-16 9:22 ` Ferruh Yigit 2020-10-16 11:20 ` Kinsella, Ray 2020-10-16 17:13 ` Andrew Rybchenko 2020-10-19 9:37 ` Kinsella, Ray 2020-10-16 16:20 ` Ferruh Yigit 2020-10-15 13:30 ` [dpdk-dev] [PATCH v2 02/11] test/event: check eth dev stop status Andrew Rybchenko 2020-10-15 13:30 ` [dpdk-dev] [PATCH v2 03/11] app: " Andrew Rybchenko 2020-10-16 1:28 ` Min Hu (Connor) 2020-10-15 13:30 ` [dpdk-dev] [PATCH v2 04/11] examples: " Andrew Rybchenko 2020-10-15 13:30 ` [dpdk-dev] [PATCH v2 05/11] net/bonding: " Andrew Rybchenko 2020-10-15 13:30 ` [dpdk-dev] [PATCH v2 06/11] kni: " Andrew Rybchenko 2020-10-15 13:30 ` [dpdk-dev] [PATCH v2 07/11] test/bonding: " Andrew Rybchenko 2020-10-15 13:30 ` [dpdk-dev] [PATCH v2 08/11] app/flow-perf: " Andrew Rybchenko 2020-10-15 13:30 ` [dpdk-dev] [PATCH v2 09/11] app/testpmd: " Andrew Rybchenko 2020-10-15 13:30 ` [dpdk-dev] [PATCH v2 10/11] net/failsafe: " Andrew Rybchenko 2020-10-15 13:30 ` [dpdk-dev] [PATCH v2 11/11] ethdev: change stop device callback to return int Andrew Rybchenko 2020-10-16 18:37 ` Ferruh Yigit 2020-10-18 8:55 ` Xu, Rosen 2020-10-16 18:54 ` [dpdk-dev] [PATCH v2 00/11] ethdev: change device stop to return status Ferruh Yigit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3910167.mFdbjSblXh@thomas \ --to=thomas@monjalon.net \ --cc=Ivan.Ilchenko@oktetlabs.ru \ --cc=andrew.rybchenko@oktetlabs.ru \ --cc=arybchenko@solarflare.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=mdr@ashroe.eu \ --cc=nhorman@tuxdriver.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git