From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54B10A0C41; Wed, 12 May 2021 17:35:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A4C84003F; Wed, 12 May 2021 17:35:05 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 945084003E; Wed, 12 May 2021 17:35:03 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 74113700; Wed, 12 May 2021 11:35:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 12 May 2021 11:35:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= VqVNmxPa7DQJb76UEq2ubFMBEaQr4fTT1FbokU2DGCc=; b=XvIbGuatllAORf+F SADShXi1SMqELEO9qwV/2g/vFHJui+9yvHjHgSsX+jOHIyv0ad9MPzl2DOjKPsl2 NBZ1FAB+tqKYMEGDWeR+GMNqg4YPgQRfvJ0ZAMdTf+ltDcDOFBvngQLSvvN+G1oN HGuCcZ9wReFBt8wzb3b99Pkm2Cu1FBTflSbeTft111HfDLL89J29dhQTFnc9jVl7 xQyYeLqg6va2akHDM9YgLmSfQS5VjZSvMx7ZcmN3Y6L/opOW7KQsNaM8+9J37uLn /NC6G/TTnEodtXWGtxR6ETGM2Hn+KVVwRvg691IbJAuxbSaCX5U1EVYAZOPdqOHn gMErQQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=VqVNmxPa7DQJb76UEq2ubFMBEaQr4fTT1FbokU2DG Cc=; b=U4s/XW6DdXw+UJyFy1MgXDkf326kHtVG4XB7A5P+ePTmgE5VwUu/Dj7WW U/fQsqlEfVzZeQvSnHVyabKXcl3/tvql5QMFJhrXgh8nrrj5OBVrjscnt8ERuRnP 6uvLGRFZjYaNXfxKqDSLSy9u+VDsuwR++YENqT/bi6sBxa01ZT5JfhxBzqsFZ2J5 ObEJm99Ktlfn0TgoP5On0FsCCv//4MNS2THe+FRHeSG6tphD0rc5sRy5S6fcksMR avReP7cR9egq/ttL8aE4Ax4sh5gGumFLz3KabJ3DKXXDPSu2NbKMrLeD3C+KqxsO AL8O9EpLCQYMwRqNAKYyFmthQHK0w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdehvddgkeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 May 2021 11:35:00 -0400 (EDT) From: Thomas Monjalon To: David Hunt Cc: dev@dpdk.org, stable@dpdk.org, "Burakov, Anatoly" , ferruh.yigit@intel.com Date: Wed, 12 May 2021 17:34:59 +0200 Message-ID: <3917343.xMDbZIhCeM@thomas> In-Reply-To: References: <20210422144030.16746-1-david.hunt@intel.com> <20210422144030.16746-2-david.hunt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v1 2/4] test/power: add turbo mode to freq check function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/04/2021 18:13, Burakov, Anatoly: > On 22-Apr-21 3:40 PM, David Hunt wrote: > > --- a/app/test/test_power_cpufreq.c > > +++ b/app/test/test_power_cpufreq.c > > @@ -48,7 +48,7 @@ static uint32_t total_freq_num; > > static uint32_t freqs[TEST_POWER_FREQS_NUM_MAX]; > > > > static int > > -check_cur_freq(unsigned lcore_id, uint32_t idx) > > +check_cur_freq(unsigned int lcore_id, uint32_t idx, int turbo) > > Nitpicking, but stdbool exists :) it would be nice to use bool type for > bool variables, not int. Dave, I think you missed this comment.