From: Ferruh Yigit <ferruh.yigit@intel.com>
To: wangyunjian <wangyunjian@huawei.com>, dev@dpdk.org, nikhil.rao@intel.com
Cc: jerry.lilijun@huawei.com, xudingke@huawei.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net/tap: free mempool when closing
Date: Mon, 14 Sep 2020 15:43:53 +0100 [thread overview]
Message-ID: <391ede8a-2308-4cf6-c0cc-55716a113217@intel.com> (raw)
In-Reply-To: <1596880723-1552-1-git-send-email-wangyunjian@huawei.com>
On 8/8/2020 10:58 AM, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> When setup tx queues, we will create a mempool for the 'gso_ctx'.
> The mempool is not freed when closing tap device. If free the tap
> device and create it with different name, it will create a new
> mempool. This maybe cause an OOM.
>
> The snprintf function return value is not checked and the mempool
> name may be truncated. This patch also fix it.
>
> Fixes: 050316a88313 ("net/tap: support TSO (TCP Segment Offload)")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2020-09-14 14:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 11:35 [dpdk-dev] [PATCH] " wangyunjian
2020-08-05 13:47 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2020-08-06 12:47 ` wangyunjian
2020-08-06 13:19 ` Thomas Monjalon
2020-08-28 12:51 ` wangyunjian
2020-09-01 10:57 ` Thomas Monjalon
2020-08-05 16:35 ` [dpdk-dev] " Ferruh Yigit
2020-08-06 12:45 ` wangyunjian
2020-08-06 13:04 ` Ferruh Yigit
2020-08-06 13:35 ` wangyunjian
2020-08-08 9:58 ` [dpdk-dev] [PATCH v2] " wangyunjian
2020-09-14 14:43 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=391ede8a-2308-4cf6-c0cc-55716a113217@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jerry.lilijun@huawei.com \
--cc=nikhil.rao@intel.com \
--cc=stable@dpdk.org \
--cc=wangyunjian@huawei.com \
--cc=xudingke@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).