From: Thomas Monjalon <thomas@monjalon.net>
To: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Cc: Ray Kinsella <mdr@ashroe.eu>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
dev@dpdk.org, "fiona.trahe@intel.com" <fiona.trahe@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>, Akhil Goyal <akhil.goyal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function
Date: Tue, 14 Apr 2020 15:03:54 +0200 [thread overview]
Message-ID: <3920120.q0ZmV6gNhb@thomas> (raw)
In-Reply-To: <VI1PR04MB3168DBEBE62AC49C2295393BE6DA0@VI1PR04MB3168.eurprd04.prod.outlook.com>
14/04/2020 14:13, Akhil Goyal:
> Hi Ray/Thomas/Bruce,
>
> Could you please help review this patch wrt ABI policy?
> >
> > This patch adds versioned function rte_cryptodev_info_get.
> > Node 20.05 function works the same way it was working before.
> > Node 20.0 function strips capability added in 20.05 release
What are Nodes 20.05 and 20.0?
> > to prevent some issues with ABI policy. To do that new capability
> > array is allocated per device and returned to user instead of the
> > original array passed by PMD.
rte_cryptodev_info is provided by the caller of the function.
I don't understand what you explained above, and the code is missing
some comments explaining the reason of the logic.
I still don't know whether this patch or not because it is missing
some clear explanations.
next prev parent reply other threads:[~2020-04-14 13:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 20:41 Arek Kusztal
2020-04-14 12:13 ` Akhil Goyal
2020-04-14 13:03 ` Thomas Monjalon [this message]
2020-04-14 13:52 ` Trahe, Fiona
2020-04-14 13:54 ` Ray Kinsella
2020-04-14 18:27 ` Trahe, Fiona
2020-04-15 17:24 ` Trahe, Fiona
2020-04-16 9:51 ` Bruce Richardson
2020-04-16 10:01 ` Thomas Monjalon
2020-04-17 7:24 ` Ray Kinsella
2020-04-17 9:31 ` Bruce Richardson
2020-04-17 9:42 ` Ray Kinsella
2020-04-17 10:17 ` Thomas Monjalon
2020-04-17 10:33 ` Ray Kinsella
2020-04-17 11:46 ` Trahe, Fiona
2020-04-17 16:01 ` Ray Kinsella
2020-04-20 16:59 ` Trahe, Fiona
2020-04-20 17:31 ` Ray Kinsella
2020-04-20 17:37 ` Thomas Monjalon
2020-04-21 6:01 ` Ray Kinsella
2020-04-21 9:36 ` Thomas Monjalon
2020-04-22 8:21 ` Ray Kinsella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3920120.q0ZmV6gNhb@thomas \
--to=thomas@monjalon.net \
--cc=akhil.goyal@nxp.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=mdr@ashroe.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).