From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D525142DF7; Fri, 7 Jul 2023 12:40:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA1AE406B5; Fri, 7 Jul 2023 12:40:22 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 4051140685 for ; Fri, 7 Jul 2023 12:40:21 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id CC8EB5C017F; Fri, 7 Jul 2023 06:40:20 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 07 Jul 2023 06:40:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1688726420; x=1688812820; bh=xfj1B7qBR/1KykF8GBabXdiuGYvCYdUTMc6 f1dh64R4=; b=m/V1XT4HX9AuqGTpJGA+sjxClLv0oD1jRz5ZpJgZDLWV9zWfFD5 enENHIgXbpHnJEQpI2fIXM55a2MzHEi1p9eGbac4qVHtm1X6p8w+B+2gGXEK7j70 etV5aMZlimLyy1lf0qmfrU/OqF7AdXpVIox5HWCGhh7llHgC6mbXrXFjcsDWN7cC M1M3ZCNr+XVTJNoZ7mFkj1xYSWMdzptMZEVRLgbk4X01i8QfgF8gf2r6xFBEtdHV SfcLbE/2lk5S1RlCIXGIoazilSbMHkx9aY7VOKb+Lgum24C1aRGGTQCkXv9rTldK pNgCglLQzyKPixAxW5lR+gNKRDDc/yl4TUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1688726420; x=1688812820; bh=xfj1B7qBR/1KykF8GBabXdiuGYvCYdUTMc6 f1dh64R4=; b=MVOymSCFxCvgj3V1PPWtONn5xhZ5OhtwHw15gBv6+SxREIBTIiX r1lRQlb23iA4n81Ynb2EKyu98OQ75xF18pilvAZ8vvzuzw4xkc3ETHesNxIlFaUn 7+uota25pKQfUGrDIcgXK88H9Fae8VnKPzwMxPGQfcLRkk5YoTpNHEDuF5M28+k+ fkl/EvGU79EoQ8ETXxXkMAS4IFkodh0cuQ3kQJZvuayDdKwS1m9uYGQuCxyDgRaQ 9dlBi8k8spxfN4Yqv06K5WDslghrTYcSs3vPU/8BiMasOPvNUHC+7yc9vSV3jEVD e507XRwFTufh+ooFxwV+KpBieoIB2SfIhTQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrvddugdeftdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepfefhjeeluedvvedtuddtuedtvefhieejtefhffeujefhteduudev tdektdeikeffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 7 Jul 2023 06:40:19 -0400 (EDT) From: Thomas Monjalon To: Chengwen Feng Cc: mb@smartsharesystems.com, Kevin Laatz , Bruce Richardson , dev@dpdk.org, david.marchand@redhat.com Subject: Re: [PATCH v4] dmadev: add tracepoints Date: Fri, 07 Jul 2023 12:40:18 +0200 Message-ID: <3922895.oiGErgHkdL@thomas> In-Reply-To: <20230526084213.30586-1-fengchengwen@huawei.com> References: <20230412024808.41339-1-fengchengwen@huawei.com> <20230526084213.30586-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 26/05/2023 10:42, Chengwen Feng: > Add tracepoints at important APIs for tracing support. >=20 > Signed-off-by: Chengwen Feng > Acked-by: Morten Br=F8rup >=20 > --- > v4: Fix asan smoke fail. > v3: Address Morten's comment: > Move stats_get and vchan_status and to trace_fp.h. > v2: Address Morten's comment: > Make stats_get as fast-path trace-points. > Place fast-path trace-point functions behind in version.map. There are more things to fix. =46irst you must export rte_dmadev_trace_fp.h as it is included by rte_dmad= ev.h. Note: you could have caught this if testing the example app for DMA. Second, you must avoid structs and enum in this header file, otherwise it cannot be included alone. Look at what is done in other *_trace_fp.h files.