From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 0BC6411DE for ; Sun, 10 Jul 2016 15:58:22 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id k123so64883486wme.0 for ; Sun, 10 Jul 2016 06:58:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=jc7qB9WC9uX6oiSqVNYv2V+2PiV+/iw7v//IOukdnhI=; b=HjunUl9Llj15NqC9Nt3cT35uzQ7985noLjJyzmm69OEmAb/q+XkC9wMTPIS4ZljQkQ x97DicjmNghR3upP/k/BqUKVEkM7J1WSETDH0DjEEM9DA0dWqwsNPrTR7ULx2f5s0mXu QllvdnWvv2XOg/8jxRK/Jxo6nQhpQcL+pQnkDTktJq2nPseLfgnrQxbfHbQpvuSgHNlS jG1O/4NUb7eI7p+vqBueWlA2z6xNAEZuEGPdXb/mqjrTkx7YstfD4ltCLO4hYOGzsJTX q3+ZroQ4EuzPSSrO1PiEOlPutBRZRYPbXMcJYj0k7mJvwhgVgdRhLSI0jYVhVuG+pMMq uzhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=jc7qB9WC9uX6oiSqVNYv2V+2PiV+/iw7v//IOukdnhI=; b=mgej2aZaZf0N2jXGkuUI+JkYGitTlY/jEHCjtwizy/ZMWFhMhZOPYcXvYm4Y/bC/cJ fNOgZed//yam07p/MsxWuKKuBBHD5o1aVf0DRX9lA0180LJB8TgY/ubBFLQvpt0dR6NR KZNGFCoSX++Tevs+ioP6nmY1CHKbAs2V1EVnm5atU4nJeDjA/VeIYbRnrFJFqFWjSsyJ zEXA6xflFmi+oRrTdKYfpKlfoOUst0o6r4LtLVkMYrs49VmOJz60qFHrSerC4dvVsO2t riBOW+r4CB8srCOvaX2wD4QhMW177LULJLQofWZO3iWBdD+/SIdqBLW7t95qyWbrWYx7 GchQ== X-Gm-Message-State: ALyK8tII+Wv0IUem3YmfBrjXkXHxD1GPdB9x0UE287lLCqyQo3v4/G+Q1GdKykk7aUjAXDBq X-Received: by 10.28.152.211 with SMTP id a202mr12088966wme.60.1468159101794; Sun, 10 Jul 2016 06:58:21 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id a2sm7330077wma.2.2016.07.10.06.58.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Jul 2016 06:58:20 -0700 (PDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Stephen Hemminger Date: Sun, 10 Jul 2016 15:58:19 +0200 Message-ID: <3923466.ri2s8GbSSX@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1467730852-12040-1-git-send-email-ferruh.yigit@intel.com> References: <1467385678-16205-1-git-send-email-ferruh.yigit@intel.com> <1467730852-12040-1-git-send-email-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] igb_uio: fix possible mmap failure for Linux >= v4.5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Jul 2016 13:58:22 -0000 2016-07-05 16:00, Ferruh Yigit: > mmap the iomem range of the PCI device fails for kernels that > enabled CONFIG_IO_STRICT_DEVMEM option: > > EAL: pci_map_resource(): > cannot mmap(39, 0x7f1c51800000, 0x100000, 0x0): > Invalid argument (0xffffffffffffffff) > > CONFIG_IO_STRICT_DEVMEM is introduced in Linux v4.5 and not enabled > by default: > Linux commit: 90a545e restrict /dev/mem to idle io memory ranges > > As a workaround igb_uio can stop reserving PCI memory resources, from > kernel point of view iomem region looks like idle and mmap works > again. This matches uio_pci_generic usage. > > With this update device iomem range is not protected against any > other kernel drivers or userspace access. But this shouldn't > be a problem for dpdk usage module since purpose of the igb_uio > module is to provide userspace access. > > Fixes: af75078fece3 ("first public release") > > Signed-off-by: Ferruh Yigit Applied, thanks I suggested to apply it in RC3 but we have no comments. That's why it is part of RC2.