From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 522978005 for ; Wed, 29 Oct 2014 10:51:39 +0100 (CET) Received: by mail-wi0-f172.google.com with SMTP id bs8so1171145wib.17 for ; Wed, 29 Oct 2014 03:00:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=eHSyvmUMyMxo/rBSnE/YAF394RWQ8IFEHpy5zFp2+3w=; b=g6oPrDTatcAcjfCdCMgR8MiEE1p5DvDNVTtwfhTdAgIJgj/tvY6N8tRJzc7PfTbALO kQOW5vkotoWWY7te4UHE6NRrmxj3kVhUd1icTRHQqQbGF7HtHKBVO81DoviKXTxTbW4m 6jIuqareqlRp3u9Ku6ACIBI12OapTaUdTAwvRPRIECsT6119FEETs0Cfgp8i5eTjuEyI FMo4JyPCoo4SfROAdZMH+6xFcxJ9b+yWJq77RFT76UuaPdHYVOe0XXpoRaRe+cW/JT37 nAkyUP5qPxPnFAQwZiWAdoOX9081qCV2tgcZePfkutFLzVcuo9yCybD5CnL4Ndn/zUeG qJMQ== X-Gm-Message-State: ALoCoQl7H8GWh5QsYGbOfUVh0wDxwhxHAwdFfoKGVU4qoNGz111geUW0f7DASRRKF0bj/HfhKVN+ X-Received: by 10.194.109.226 with SMTP id hv2mr11196385wjb.45.1414576830438; Wed, 29 Oct 2014 03:00:30 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id w13sm4617153wjq.29.2014.10.29.03.00.29 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Oct 2014 03:00:29 -0700 (PDT) From: Thomas Monjalon To: "Zhang, Helin" Date: Wed, 29 Oct 2014 11:00:11 +0100 Message-ID: <3930995.vElmohEEnC@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.1-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: References: <1411634427-746-1-git-send-email-helin.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes of redirection table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Oct 2014 09:51:39 -0000 2014-10-29 08:24, Zhang, Helin: > > > -----Original Message----- > > From: Zhang, Helin > > Sent: Tuesday, October 28, 2014 8:01 PM > > To: Thomas Monjalon > > Cc: dev@dpdk.org > > Subject: RE: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes of > > redirection table > > > > Hi Thomas > > > > > -----Original Message----- > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > Sent: Tuesday, October 28, 2014 6:10 PM > > > To: Zhang, Helin > > > Cc: dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple > > > sizes of redirection table > > > > > > 2014-10-28 00:33, Zhang, Helin: > > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > > 2014-09-25 16:40, Helin Zhang: > > > > > > /* Definitions used for redirection table entry size */ > > > > > > -#define ETH_RSS_RETA_NUM_ENTRIES 128 > > > > > > -#define ETH_RSS_RETA_MAX_QUEUE 16 > > > > > > +#define ETH_RSS_RETA_SIZE_64 64 #define ETH_RSS_RETA_SIZE_128 > > > > > > +128 #define ETH_RSS_RETA_SIZE_512 > > > > > > +512 > > > > > > + > > > > > > +#define RTE_BIT_WIDTH_64 (CHAR_BIT * sizeof(uint64_t)) > > > > > > > > > > Are these constants really needed? > > > > > > > > These constants were defined for the third input parameter of > > > > rte_eth_dev_rss_reta_update() and rte_eth_dev_rss_reta_query(). End > > > > users need to give the correct reta size listed as above, as other > > > > values is not valid. So it would be better to list the valid reta > > > > sizes in macros > > > here. > > > > > > OK, so you should explain that only these values are allowed. > > > In general, it's something we explain in the comment of the function > > It would be better to add comments for the functions. > Now do not think explain what value is allowed for the functions in ethdev layer, > as it might be hardware specific. > I think the best way is to comment out end users can get the reta size by > 'dev_infos_get' on each port, rather than telling the values directly. Yes, it's better. Thanks -- Thomas