From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8D26A0350; Mon, 29 Jun 2020 16:15:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B7F281BF6C; Mon, 29 Jun 2020 16:15:48 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 8DF5A1BECB for ; Mon, 29 Jun 2020 16:15:47 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id E0BCE5C019C; Mon, 29 Jun 2020 10:15:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 29 Jun 2020 10:15:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= DrHzwCUlTY633ovekW1CBbl7WFcwiHeLOXk7fFaRACA=; b=ptUQrwflgO83t4QL P+aG/uQGu21aRb78gixRA1U5Rx9wfbvXPtOmh3w1oatPzRLgKubqqH1ECWucshJl VERpy22hri8B1XF+rngvsH8hWOE2kRFsfGw8IZSQqWqBva94yscRo/swopDbTnaP jpszrK06Yvk5yQStsfPeBD23GzvokYf1QJkW50m0Z5o+NBFZOXFhWgK74iV2rYF1 JbzzGorlPJvXqEVcFTe/oqd/mEOEDfCC40fvVgPa1W9X7vph7OGvpvnDdGUvAaaN tCdwFAIBxAIffH7dgF+BD+VLb1grzXncXXsOFq1ASFrx2qWtCkTE40gMjJYe8pPt Vg+aBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=DrHzwCUlTY633ovekW1CBbl7WFcwiHeLOXk7fFaRA CA=; b=er8kSC42bi7SM1mh8lAAxjD0LwsyHUt202Xicf6Cyt0+YIu6v7t+SZzLI FzRWXiJ3jYPf7aa26Q1/b5Fqleq/G1pUJLUMusQ6x9vL83lFeAEBgjIwL0QSRIb5 HZdP0jMTV3JUXmVTdCZXdNKylXkUjWdE5ZzhgSdKfHRN1ufnU8fCapn2DiJKnD+K 1R19SCfHPEhNItvhtFMKQAn19OJ3CIRzAIUr9u7h6rPJ6ydZqtpdDE3OuJvk4bUr ClT3Sy5kICApmnvNs/95h3tf1K1MRW6soiBt3CQa3lPOfJqadMesSKiHjwqZXV/J MVUT+LCta4hLKEfaEdP2DvHkagn9Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudelledgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4EAD73280065; Mon, 29 Jun 2020 10:15:45 -0400 (EDT) From: Thomas Monjalon To: Wisam Jaddo Cc: arybchenko@solarflare.com, jackmin@mellanox.com, jerinjacobk@gmail.com, ajit.khaparde@broadcom.com, dev@dpdk.org, orika@mellanox.com, ferruh.yigit@intel.com Date: Mon, 29 Jun 2020 16:15:43 +0200 Message-ID: <3932794.yixytucIVQ@thomas> In-Reply-To: <20200604133502.28491-1-wisamm@mellanox.com> References: <20200511110811.11474-2-wisamm@mellanox.com> <20200604133502.28491-1-wisamm@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 0/5] Introduce flow perf application X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/06/2020 15:34, Wisam Jaddo: > Add new application to test rte flow performance from: > - Insertion rate. > - Deletion rate. > - Memory consumption. > - PPS forward measurement. > > Unchanged comments: > - Prevent actions such as Queue from adding twice: > * Current design don't support add actions twice. > * This is performace app that not should force coditions like PMD. > * If app allows adding dup actions and user added Queue the PMD should > report the error. > * No memory leak found. > > --- > v7: > * Move add_items/add_actions in items/actions instead of flow. > * Have array of structures with loops instead of branching. > * Add limitation part in doc. > * Align items/actions generator methods with same signature. > * Convert item/action & attrs selector to be 64bit instead of 32bit. More than 3 weeks passed since this v7. It looks to be good enough to be merged, and let this new application to be improved with more features. I fixed few minor details in maintainers, doc, etc. Applied, thanks