From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 9BCA237AF
 for <dev@dpdk.org>; Wed,  1 Jul 2015 12:48:33 +0200 (CEST)
Received: by wgjx7 with SMTP id x7so33091013wgj.2
 for <dev@dpdk.org>; Wed, 01 Jul 2015 03:48:33 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=5kzdrjW3TeVlG6nRpihn6YmVAlDiUmRxPRKxM8nRib0=;
 b=EV6895spIDrO1LfFqShOc1WBw7RGWy2cK8z9gtjOBX9KJY9HLRB17vKt/8L7dhKibv
 u+eKdPLeMYxjubrMUx/prYxMVMptC/5yHTuDAWApcTqLVKitc14/QfFmFs692by+XJ6u
 T314LcfR3px3VM1EQiKmeKEyaH+zloV3v3CQyqX6ko9Y3Z0pvSd94SJekpPXLXrf3V/I
 PDsWEW0TkCs7z0YjonDwjKxNpsSUV6Jeqrk/Ucq/thdq06sbViqbOJRL70jYI5pC0Zn/
 rFU+Gnil7i8eGEhZ9ZPVzTqJ2RnG+w56tYf68EyBDwUDrnuiFa2mXJCyFBJ5IgEV1u1E
 l8vA==
X-Gm-Message-State: ALoCoQlanoi0YejK88wEqo5cI8FgCgTQMAFz49BKNT/ZISedlEsrYqw+yeefyxzxMabeCZS1pQ76
X-Received: by 10.194.89.225 with SMTP id br1mr48921133wjb.97.1435747713428;
 Wed, 01 Jul 2015 03:48:33 -0700 (PDT)
Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.151.210])
 by mx.google.com with ESMTPSA id um5sm2289930wjc.1.2015.07.01.03.48.31
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 01 Jul 2015 03:48:32 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "He, Shaopeng" <shaopeng.he@intel.com>
Date: Wed, 01 Jul 2015 12:47:24 +0200
Message-ID: <3937025.fl7qCHlTup@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <FB82FCC69332B84596FE0CEC3C1310949EBFC9@shsmsx102.ccr.corp.intel.com>
References: <1431680162-13704-1-git-send-email-shaopeng.he@intel.com>
 <FB82FCC69332B84596FE0CEC3C1310949E2DC9@shsmsx102.ccr.corp.intel.com>
 <FB82FCC69332B84596FE0CEC3C1310949EBFC9@shsmsx102.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] fm10k: support XEN domain0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Jul 2015 10:48:33 -0000

2015-06-30 03:27, He, Shaopeng:
> From: He, Shaopeng
> > From: Liu, Jijiang
> > > Acked-by: Jijiang Liu <Jijiang.liu@intel.com>
> > >
> > > I think this patch could be merged before Stephen's following patch[1] is
> > > merged, then Stephen should rework the patch[1].
> > > Thanks.
> > >
> > > [1]http://dpdk.org/ml/archives/dev/2015-March/014992.html
> > 
> > Do you think we can accept this patch in current no-so-elegant way, so user
> > can
> > use XEN with fm10k from release 2.1; or better to wait for Stephen's patch?
> > Thank you in advance for your attention to this matter.
> 
> This patch is necessary for fm10k to use on XEN environment with DPDK. How could
> we move forward, could you please kindly give some advice?

Applied.
It's probably the last time this ifdef is used. Next time, we'll have to introduce
a function which is common to Xen and standard case. A rework is welcome.
The Xen case could also be switched at run-time. Stephen's patch must be
reviewed for that.