From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id B5A61DE5 for ; Mon, 23 Jan 2017 16:25:30 +0100 (CET) Received: by mail-wm0-f43.google.com with SMTP id r126so138198705wmr.0 for ; Mon, 23 Jan 2017 07:25:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=j3u+OIHzXG3eoD377YfpX/Grlv/1ZJ0LB7qsiScvHy8=; b=Zbbi69elzy7yh5jnHwL6GHyDawGG8k14ewpF3ATEZU+n5xxhFMQ0EsEBu1Wjnq5Mre YeIOXEVg5iATcNjW4KkdiJsli1rHNziJjtWqcKFKmH7Wxu+cxmcDWe20/UIbUSjjQvO7 tGo+r3dvPc8rI3b7eHkX+lAWU2PAuob2+dUG8SzxiRsVu6BaAFzGrEBcMEFwvedgeUnV 1Mnyzf1+NFAu4gy/XEonJwRmxYGqUMsTRBwR9nyiORUF+CehHttlAFxyZ/+50XuXQ2VR TbGwg6ge2ge/Wst5CT5qTc5IezmXpGoamt+g3SNC79nP7c0xWHG2xS97BCPYcnC7n+ev 9nZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=j3u+OIHzXG3eoD377YfpX/Grlv/1ZJ0LB7qsiScvHy8=; b=QFua4yQt8STw8mR9A4/UOqfxwl2Bw/6LrN2xeb6u7hNmKUB+coioAGotGgtxaACnWd wwjHdR1e27ud0tpkwWac8yR+O9YLuUOMpTo2c+YY9WH0HPwZivDwTV/WhiGIe6spQO4X VhPGg2QCHr9wVXLbP041prFc8KgUW19hmXxCK6pjqN80q2I6tiRicLwQ+BAwJszWvXQ5 M++Cspsqs7EvcH+YW4JYEsbQo0lTUZi2FeirFTal9Dlu1v/0lmRKfqUhAoZe4Ob3LhTv EvDJ/1Z73pA2OujZubLbEa45DtKremE1FuqkhVPVfX5oTe1mNOht3r2iEFrQL0u5VLHo lGWA== X-Gm-Message-State: AIkVDXJZ3Y2705X74olkfTJUeDoyv8sHbBCdU1uqlcDszGFi3MJmPshkBJto3insRIEXPON4 X-Received: by 10.223.133.152 with SMTP id 24mr23681819wrt.29.1485185130217; Mon, 23 Jan 2017 07:25:30 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id x39sm15196696wrb.3.2017.01.23.07.25.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jan 2017 07:25:29 -0800 (PST) From: Thomas Monjalon To: Billy McFall Cc: wenzhuo.lu@intel.com, dev@dpdk.org Date: Mon, 23 Jan 2017 16:25:28 +0100 Message-ID: <3938869.5RB17SFArz@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170120160109.1088-1-bmcfall@redhat.com> References: <20170120160109.1088-1-bmcfall@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 0/3] new API to free consumed buffers in Tx ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2017 15:25:31 -0000 Hi, Thanks for bringing a new convenient API. 2017-01-20 11:01, Billy McFall: > Based on a request from Damjan Marion and seconded by Keith Wiles, see > dpdk-dev mailing list from 11/21/2016, Generally we use links to ML archives to show prior discussions. > add a new API to free consumed > buffers on TX ring. This addresses two scenarios: > 1) Flooding a packet and want to reuse existing mbuf to avoid a packet > copy. Increment the reference count of the packet and poll new API until > reference count is decremented. > 2) Application runs out of mbufs, or resets and is preparing for > additional run, call API to free consumed packets so processing can > continue. > > API will return the number of packets freed (0-n) or error code if > feature not supported (-ENOTSUP) or input invalid (-ENODEV). > > API for e1000 igb driver and vHost driver have been implemented. Other > drivers can be implemented over time. Some drivers implement a Tx done > flush routine that should be reused where possible. e1000 igb driver > and vHost driver do not have such functions. Before considering to use such API, user apps may check how well it is supported by drivers in this table: http://dpdk.org/doc/guides/nics/overview.html Please add this feature in the appropriate files: doc/guides/nics/features/default.ini in patch 1 doc/guides/nics/features/e1000.ini in patch 2 doc/guides/nics/features/vhost.ini in patch 3 Then it will be introduced in the beginning of the 17.05 cycle. So more drivers could be implemented before the 17.05 release. Does it sound good? PS: please use --in-reply-to when sending new versions to keep track of versions changes and discussions.