From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0042.outbound.protection.outlook.com [104.47.38.42]) by dpdk.org (Postfix) with ESMTP id DF6D73255 for ; Fri, 1 Dec 2017 09:59:12 +0100 (CET) Received: from BN6PR03CA0018.namprd03.prod.outlook.com (10.168.230.156) by CO2PR03MB2357.namprd03.prod.outlook.com (10.166.93.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Fri, 1 Dec 2017 08:59:11 +0000 Received: from BN1BFFO11FD048.protection.gbl (2a01:111:f400:7c10::1:151) by BN6PR03CA0018.outlook.office365.com (2603:10b6:404:23::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.282.5 via Frontend Transport; Fri, 1 Dec 2017 08:59:10 +0000 Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD048.mail.protection.outlook.com (10.58.145.3) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.239.4 via Frontend Transport; Fri, 1 Dec 2017 08:59:10 +0000 Received: from [10.232.133.65] ([10.232.133.65]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id vB18x28p001907; Fri, 1 Dec 2017 01:59:03 -0700 To: Ferruh Yigit , Thomas Monjalon , Shreyansh Jain , Nipun Gupta , Jerin Jacob , Santosh Shukla , "John W. Linville" , Shepard Siegel , Ed Czeck , John Miller , Allain Legacy , Matt Peters , Harish Patil , Rasesh Mody , Stephen Hurd , Ajit Khaparde , Declan Doherty , Rahul Lakkireddy , Wenzhuo Lu , Marcin Wojtas References: <20171201022957.64329-1-ferruh.yigit@intel.com> <20171201022957.64329-3-ferruh.yigit@intel.com> CC: , From: Hemant Agrawal Message-ID: <393b75b1-bc37-3aeb-a63b-f33abff546bc@nxp.com> Date: Fri, 1 Dec 2017 14:29:01 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20171201022957.64329-3-ferruh.yigit@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131565923504886393; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(979002)(6009001)(7966004)(336005)(346002)(376002)(39380400002)(39860400002)(2980300002)(1110001)(1109001)(3190300001)(339900001)(189002)(24454002)(199003)(189998001)(23746002)(33646002)(58126008)(2906002)(53546010)(31686004)(104016004)(67846002)(68736007)(305945005)(356003)(31696002)(76176011)(83506002)(8936002)(86362001)(54906003)(105606002)(4326008)(110136005)(54356011)(106466001)(316002)(229853002)(65826007)(47776003)(65956001)(65806001)(230700001)(77096006)(6246003)(81166006)(81156014)(50466002)(97736004)(8676002)(8656006)(36756003)(53936002)(64126003)(7416002)(2950100002)(5660300001)(498600001)(921003)(1121003)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR03MB2357; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD048; 1:P5NutbsocKgOJTzfBeP8jIH+2pEYcJvQzjx5RP96N6RGe7yJihDuo90I0GxRt3LrbLW9XhbzYYwS++TvIpavGL0nwm9PQ9LW1uKJa9s/S743ClgsF/GAQOEp1Tbl4BSp X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7160ef94-8638-45fd-4fbd-08d53899c980 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4628075)(201703131517081)(5600026)(4604075)(2017052603286); SRVR:CO2PR03MB2357; X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2357; 3:AGdVfOPg78B/PdPk08no0hQoiLdITy1KMpna/vnXcUS3IPm4iIrvCie6XDV1KenYl0HPy4dmLVVp+Evrdj5pjJ+/TB0lnGaXDa4CPf5xuddlMNWqLxYzsvQxjCOS/aB6NlPS9DSefnt84/Xu2fPujdiWw+BVSYi9WpB5uh4Lj8wrJgDXHsmoBPoOaIaPFOBHue3MRMWFUA+ki7mj+/ntMbW01QrcgsxrAY5PfZbnAA6ReboNzGx/M+GPzVB71WbBjCKzp9DcYQ+sYJ/hxx7ZrYWlWlXmYaqLRmUWNodrAsB2uZNqy2V2ZnVZwe1lTwXz2o0vbQlUBXlT263M+pDgpGfgzVD95z1DqShn3dT2AXY=; 25:p3WjqBByS48juTCtWBmS/Vv5gNPhmB1LoYAxRs/vL1fczPjsAUnZQG4QKtRaZNBbw1B6uQCFWBJiHgcTlUUmO5JEsJ1YquMut1+T2hDF8xgo0HyggwByDHLjDZNpCF8o5tXZKzTQ4TG3VWPVzsF08s9noTGlDbZImkJaeEUkTgijgg26DdXg1Ggrr+nmoI/SurIl1I64d6TgLNfiSOy5sRH5y90hZ6EEsUaVd9ckMzl44E8xNazGqPLCq7sOkRa1JIZhYs2oQBqb3zHyfHvl1/hcIIsQO2QK4JRgtLFahiixJGuPnC1sjPJ67mx2+sQ8yDGBDZJzD/CYl9RLYdFhiA== X-MS-TrafficTypeDiagnostic: CO2PR03MB2357: X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2357; 31:dwe/Z1fEZZMadgth7nv5UEsFNnbxAI8EDNoJGbELeL+K3OtOqsrZv4w8V0U+bJegNZXnxyV7FCeSUP4F1stMGWTjMUwWJNnc59JFgNqMDUcrVZeUiH3NkSoYlm43ygI+IXSC5EdmL+GQ069yUdTcdF4F0G2oY/Ex40Q1rtjDLmnRYAYpXoilKgnhFd0lOmJ9ahMa815i667k5TuG+QXGg/LndG3jLRa3f5O/TsBkS+A=; 4:/F9iJ1vcKoM173p+fjlX0gCgiFdiRM0PRcD5a11WZX3cuHYIii+/YP+iQTH1Xf6YL0HmE4mBE2NmvWbf+YSeH4O6G6J5qHplpCkKwaPGzQFrObOc5zQA7zludzUjIL9X37VYTfOkPj5Bg6vDjcpNQrQjgpBUKEKU5zVyO8fW8CgaEayaW4k/llwBod9LV1DO0bK89SVjUILgLunIRCQcGcOUzwKfs8pWcwYnddkYl9BshzH8f6vYsKJDBfr83IXwbyjM5ytaTMSEyEMYgNmQXY9qdDgblmato1/gBf7aOlX5+omT9ZZLPxInFiH76Pu1 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(3231022)(6055026)(6096035)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123563025)(20161123556025)(20161123561025)(20161123565025)(20161123559100)(201708071742011); SRVR:CO2PR03MB2357; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:CO2PR03MB2357; X-Forefront-PRVS: 05087F0C24 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CO2PR03MB2357; 23:MZh04TQxRMiePIvy/zVe9D/oUhUb9JEMhThd3?= =?Windows-1252?Q?Kvjuy2Ui2/1B+Br2w3pQJOy3M8LYy2r/pFQQORwCDn8svRvLY2NfPamO?= =?Windows-1252?Q?vlZU58zsGbg1P4Qmpyjhgxz9yYaQFQgbkADyFCwLoRxXmF1d+KDNjN+d?= =?Windows-1252?Q?1V96bKkQqM1QqRL1AS9He/HlbfhAyrT7HlaLENNeMjht3Cove3jQ9c4P?= =?Windows-1252?Q?B4uvP8m6jziu6ymRou52vnCLnjY7y2TD3IHgqURHzmySKGSfMJ039Oqz?= =?Windows-1252?Q?PKM1yY1/Us8V5HCnis7aohb2LBWh5XnULxmB+FNkKKZ2BulI++gxdsr6?= =?Windows-1252?Q?8JPe5ZKujRV8686a0Ta1x2nUImulEg4SZCAhHZnVTOvMtqVkVN8Zxhi1?= =?Windows-1252?Q?7TpUzCEW5nFxjm6Ai/WSI4A+5Jqqu/UxL0VnFHNeXOTLyvoLgd+2SbCp?= =?Windows-1252?Q?UACYSZoc75WgXHHGhSPJVzXoHcZDGkNrtqdJz3moXlGP4foynV7QR/Xy?= =?Windows-1252?Q?nC2gXZoILFRlymFfGbKMWKdFjMFDGP/EoAvq0wd5sjQBWwAgNKaumBs0?= =?Windows-1252?Q?elcydBxHUh3qti8n0hZmPQP2Hh3Jr+myq/VbpXdKyRNd40t71+GXGeZX?= =?Windows-1252?Q?v3KwTkaW67uBEXlew6cra5oH5JR2BvGhMcfVz0lO8oN3uXy2GAbsFCyZ?= =?Windows-1252?Q?iPxeeI+tKJucsgyKIXn02x8d6VdkXC6T2UfJOkCwc/5usZNQ+s5rL+6a?= =?Windows-1252?Q?/hxJvrfsPIKFa9cWsRzCRZ/f2xUq3xtiPYOoER2mNQPBKef39/MpZcuK?= =?Windows-1252?Q?W6F/Sm/k4yMmwPR7oLJNcaaRMbRKvhcAl3kUJQFKs62DKUJ2NOPHIZut?= =?Windows-1252?Q?VOJuvOHysk8n2GLFm+xvZkOE8/ijKO2xZyu1Wl+vElHkN+qtWeNknE6E?= =?Windows-1252?Q?VJOWe51RjWijG+oxlP9VEelGcGHu3LmwQXtN9JWa15i5vz3gM/l32Su5?= =?Windows-1252?Q?7Rk6k6+SeiOgbBny5HhOZ0/o1q4CQyH+p+Jn/P92nfdG310lTmtsoekX?= =?Windows-1252?Q?fUYlkML9MXBxPUmZi+/orBBvv5+AyvJzwYbgYbDDRTlVy92r1XJpiIAs?= =?Windows-1252?Q?u+cuqkcyY+cV2dEc6G3eFc548U0766RHOOhCyuotPcck8YKkXbiDXgnX?= =?Windows-1252?Q?ZtXYPBNOXaehMLS3U0IjTESKZUbpPcCouEaTCTVYRQ5xDiFhRWJxb/Pj?= =?Windows-1252?Q?1O1HlZLgonSi9PhwYth/z4+mFsBqjlueAvNcofu9+pXwq9mBAW+Kxz3W?= =?Windows-1252?Q?dZnF76peRP0yJmAfIsRT+DaI8Irqq9bZdtXjILxJG/86C153btd68WPX?= =?Windows-1252?Q?+giR52iqs/YdReZp4nClpqUpZydo4L2gQdfKSf3w4lcUYbPVYwC/G56T?= =?Windows-1252?Q?B4GDgfd7XCKy7TTEMohHX07x4mACvmTybWq3/MghL/5Pg67LhOUsxaPw?= =?Windows-1252?Q?Eb10B2LzRcDyTXrHTcjrBAVJviI8OloaYe6SlApvWqUoEhP7v3ve5eCN?= =?Windows-1252?Q?9VnoyodQcHiWuBbve0FPIc7YwPutjVMT+QJK1XjlznA9likMMHajFPCb?= =?Windows-1252?Q?oDR+dTUnj8k6IJjJZ0mq1wZ51jymWDIBFh460cZb0+D?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2357; 6:uzHWG8g9jn2J4pMD3rvA+McwBwhz4Ezi/Jjj+U7y/IJN2GUqS924JinYozTUeH+uyJD2vJnWEeAkuFox930xiQ+odm8xCRiW1RosDgEb6R57XVZs8mpf4dLz0Vui8746Gd5bbs4obU945E+jSl2S4kHGp3UjVIAYkkB/EblsnEdMnnJof75uiRnySvXWpYIlZ6ctVWQyPQLD4PD+WEifJzcA1UykUxEbHZTjxikCzFUpjBKc+6bRILwrz4jRkz64zrA/qh7QwRi38sF5VPPanHCQr4k3IADiCiiIh+sOliWttXYMC8kArLUWivkjGIrTNhrfv/IwKGwSw3FVFMFNMea0JegIL4AGiyMA8HESVbw=; 5:sxf+Pn5OH9Aop0q62zLJEvxH8f/K9YO1VV6q8T4Yu4FTqYoVrUevpiORUBWQdlFdt9uqX26/9PacP/5gjqbUwkBgPTPJH05sCwFss5Qi0SGQLGOpf3GQV8N1KPYnbuUUey9Mhtatoak8TiwfbjSVzWDzibQAY/8n3ARMn4N/3NQ=; 24:NcoafSd86Brfo4W9xvKbO6KDIpMp3WgCgE9q1duny44aST1wXIgvgRx8fBj8JC9CRrAKr3WEdeQlUo7OLoUnreUurH5DlUJOGDRSFPcnXy8=; 7:sv5uw8bwkusVHfDudzkkK1aG4O+XMF9g4esYPFDXbngbQt4Gs/s6T1RDLjbfWNx85tUz10gY7n9g++LZMiKWSWW796/9xfa5a4BP/o1mvpmpRA1hv2fU5LRkGZFH0/jAw+hnA/XFbPFX0ipNvO3zcrwMoZNtNqX9aiCDkpGEu5RNiNQVHVsyIyd3XqwuPauWicC/gupb0rzNYt9y+yRuZHpBL+VAe6O2rEVW3BXEshpreWPj9qvBrkRVwAxE9obC SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2017 08:59:10.1454 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7160ef94-8638-45fd-4fbd-08d53899c980 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2357 Subject: Re: [dpdk-dev] [PATCH 3/7] ethdev: separate driver APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Dec 2017 08:59:13 -0000 On 12/1/2017 7:59 AM, Ferruh Yigit wrote: ... > diff --git a/lib/librte_ether/rte_ethdev_driver.h b/lib/librte_ether/rte_ethdev_driver.h > new file mode 100644 > index 000000000..3e77d1439 > --- /dev/null > +++ b/lib/librte_ether/rte_ethdev_driver.h > @@ -0,0 +1,163 @@ > +/*- > + * BSD LICENSE > + * > + * Copyright(c) 2017 Intel Corporation. All rights reserved. > + * All rights reserved. You can remove one of the all rights reserved. This is also an issue in your next patch for rte_ethdev_core.h Also, as Shreyansh mentioned, Why not start with SPDX tags instead of full license text? ... > +/** > + * @internal Executes all the user application registered callbacks for > + * the specific device. It is for DPDK internal user only. User > + * application should not call it directly. > + * > + * @param dev > + * Pointer to struct rte_eth_dev. > + * @param event > + * Eth device interrupt event type. > + * @param cb_arg > + * callback parameter. > + * @param ret_param > + * To pass data back to user application. > + * This allows the user application to decide if a particular function > + * is permitted or not. > + * > + * @return > + * int > + */ > +int _rte_eth_dev_callback_process(struct rte_eth_dev *dev, > + enum rte_eth_event_type event, void *cb_arg, void *ret_param); > + > +/** > + * Create memzone for HW rings. Like all other functions, you can also add "@internal" for this as well. Acked-by: Hemant Agrawal