From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 5048F10B7 for ; Mon, 23 Apr 2018 22:16:41 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id ABF332105E; Mon, 23 Apr 2018 16:16:40 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 23 Apr 2018 16:16:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=yOUvVZ1FiTYDnMzL1HtP9c3GEW VoaNQw1elkZVr88JQ=; b=QWWL4OPwRyGY57yZ0A0xa4Z8yjgUk1bULmV8ga2b4k HO9TCrzZLoVAkGRXKaGgyZ8vF8ddSz/x9aj8ocQvnvHpREoRbFKmttt1Q1Q6uSZY rEG9mc00pS7K1tQLUWsB93a2vUVKARYgVKcMEljNCuUuaraQ/nMnOx//ZmMJA00B w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=yOUvVZ 1FiTYDnMzL1HtP9c3GEWVoaNQw1elkZVr88JQ=; b=TEx6M5mlivjEBlOpXOTx4x P5SBMJY0ghBx6x5ckkzC1clCuPSlcvXVDM7jHQe64Bv9DuNH27wYz5M5cGE38Siy 9S496I3WEyltwqoVxXZEEJO7H7+y12AbCoy10mmvH316ui0gr03XQ9v6J1KDRIhu 67PiB98asyU1Hcw62JuPjN29UF5EiagA/wMkuPZ8u4BypQ/NhNBPe/mCKrAFWucl wr69JwqIJHr8BlkB+Yx8yH1MiEDIPivn4VT4v3gsEqn8nZK/D4T1+6GmbSoF/nhJ /ZH7KUWqwoT+TmopBmbqFtRQL5hiCgEQemU9mB0nzmVHjq6OU2UXcnd5rGs/G4Cw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0540AE47F2; Mon, 23 Apr 2018 16:16:39 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, Adrien Mazarguil Date: Mon, 23 Apr 2018 22:16:38 +0200 Message-ID: <3940059.fMP8snkLnf@xps> In-Reply-To: <20180418085139.GN4957@6wind.com> References: <20180418085139.GN4957@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 0/4] Fixes for coverity issues in fbarray X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 20:16:41 -0000 18/04/2018 10:51, Adrien Mazarguil: > On Tue, Apr 17, 2018 at 04:44:04PM +0100, Anatoly Burakov wrote: > > This patchset fixes a number of Coverity issues introduced > > in recent DPDK memory hotplug patchset. > > > > Coverity issues fixed: > > - 272564 - error condition not checked > > - 272579 - dereference before null check > > - 272586 - error condition not checked > > > > There are two additional issues reported by coverity: > > - 272598 - error condition not checked > > - 272599 - error condition not checked > > > > However, they are fixed by a separate patch [1]. > > > > [1] http://dpdk.org/dev/patchwork/patch/38091/ > > > > Anatoly Burakov (4): > > fbarray: use strlcpy instead of snprintf > > fbarray: add check for failed file descriptor open > > fbarray: fix potential null-dereference > > fbarray: handle negative return > > Given that I recently addressed a similar issue in fbarray as well: > > Acked-by: Adrien Mazarguil Applied, thanks