* [dpdk-dev] [PATCH] net/mlx5: fix flow director matching rules
@ 2017-10-27 6:50 Nelio Laranjeiro
2017-10-31 0:53 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Nelio Laranjeiro @ 2017-10-27 6:50 UTC (permalink / raw)
To: dev; +Cc: Yongseok Koh, Adrien Mazarguil
Flow director API does not provide a layer 2 configuration when the filter
is for layer 3 and 4 causing the translation to generic flow API to be
wrong, as not providing a mask for layer ends by using the default one. In
this case, the Ethernet mask layer is full whereas it must be empty.
Fixes: 4c3e9bcdd52e ("net/mlx5: support flow director")
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: Yongseok Koh <yskoh@mellanox.com>
---
drivers/net/mlx5/mlx5_flow.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index f392f1f65..567c7f675 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -479,6 +479,7 @@ struct mlx5_fdir {
struct rte_flow_action actions[2];
struct rte_flow_item items[4];
struct rte_flow_item_eth l2;
+ struct rte_flow_item_eth l2_mask;
union {
struct rte_flow_item_ipv4 ipv4;
struct rte_flow_item_ipv6 ipv6;
@@ -2615,6 +2616,7 @@ priv_fdir_filter_convert(struct priv *priv,
attributes->items[0] = (struct rte_flow_item) {
.type = RTE_FLOW_ITEM_TYPE_ETH,
.spec = &attributes->l2,
+ .mask = &attributes->l2_mask,
};
switch (fdir_filter->action.behavior) {
case RTE_ETH_FDIR_ACCEPT:
@@ -2778,6 +2780,11 @@ priv_fdir_filter_add(struct priv *priv,
{
struct mlx5_fdir attributes = {
.attr.group = 0,
+ .l2_mask = {
+ .dst.addr_bytes = "\x00\x00\x00\x00\x00\x00",
+ .src.addr_bytes = "\x00\x00\x00\x00\x00\x00",
+ .type = 0,
+ },
};
struct mlx5_flow_parse parser = {
.layer = HASH_RXQ_ETH,
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix flow director matching rules
2017-10-27 6:50 [dpdk-dev] [PATCH] net/mlx5: fix flow director matching rules Nelio Laranjeiro
@ 2017-10-31 0:53 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2017-10-31 0:53 UTC (permalink / raw)
To: Nelio Laranjeiro, dev; +Cc: Yongseok Koh, Adrien Mazarguil
On 10/26/2017 11:50 PM, Nelio Laranjeiro wrote:
> Flow director API does not provide a layer 2 configuration when the filter
> is for layer 3 and 4 causing the translation to generic flow API to be
> wrong, as not providing a mask for layer ends by using the default one. In
> this case, the Ethernet mask layer is full whereas it must be empty.
>
> Fixes: 4c3e9bcdd52e ("net/mlx5: support flow director")
>
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-31 0:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-27 6:50 [dpdk-dev] [PATCH] net/mlx5: fix flow director matching rules Nelio Laranjeiro
2017-10-31 0:53 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).