From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 98A825A43 for ; Thu, 9 Apr 2015 15:33:56 +0200 (CEST) Received: by wgso17 with SMTP id o17so8476454wgs.1 for ; Thu, 09 Apr 2015 06:33:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=rJqjctXUexKfC0C/XAm17fEzNrHZU3RnKola888HQw4=; b=lrwQgVvoDHrMi3FKYOYD23DpApDgPJ7832JDbznpAhTxlZ5rbjFhLPMswE96tApIha Se4mvseUCUT6Ek3vmKwv0s7ft8riDEiX1tXRcA5wEEtBTgFhXm8KpeiFkcxw8ApWGcCW D4KRLNbm7005EZlNioY2uB9mQ3DIScDF9So0wa6mnj6X8LFEvhhhzHr1S55AGSVyStde 9WqthgNBSCW9XpVosJwNrXFKyMdtNTKDLE2pDtXYUNT+moTaK/26WlidmhuHutxrrUh8 KhdV7dcPED1PdfZS1dequwk5X/mV9kP4kW13vEng2rgtW6GgmkJ6/6/FEeu9sUgJ+LMe +hPw== X-Gm-Message-State: ALoCoQn7MuvB62APnJUmiMyGzJz/j2Najn+5XP+v5r76d+O6Nh8spc7d6EYMc1LqENAhdtHqMstK X-Received: by 10.194.93.165 with SMTP id cv5mr61626447wjb.24.1428586436438; Thu, 09 Apr 2015 06:33:56 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id e18sm20151025wjz.27.2015.04.09.06.33.55 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Apr 2015 06:33:55 -0700 (PDT) From: Thomas Monjalon To: Neil Horman , Avi Kivity Date: Thu, 09 Apr 2015 15:33:13 +0200 Message-ID: <3947209.nq3HLHzIVI@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <20150409111943.GA26201@hmsreliant.think-freely.org> References: <1428505645-5578-1-git-send-email-sergio.gonzalez.monroy@intel.com> <55264127.2020604@cloudius-systems.com> <20150409111943.GA26201@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 1/5] mk: remove combined library and related options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Apr 2015 13:33:56 -0000 2015-04-09 07:19, Neil Horman: > On Thu, Apr 09, 2015 at 12:06:47PM +0300, Avi Kivity wrote: > > On 04/09/2015 11:33 AM, Gonzalez Monroy, Sergio wrote: > > >On 08/04/2015 19:26, Stephen Hemminger wrote: > > >>On Wed, 8 Apr 2015 16:07:21 +0100 > > >>Sergio Gonzalez Monroy wrote: > > >> > > >>>Currently, the target/rules to build combined libraries is different > > >>>than the one to build individual libraries. > > >>> > > >>>By removing the combined library option as a build configuration option > > >>>we simplify the build pocess by having a single point for > > >>>linking/archiving > > >>>libraries in DPDK. > > >>> > > >>>This patch removes CONFIG_RTE_BUILD_COMBINE_LIB build config option and > > >>>removes the makefiles associated with building a combined library. > > >>> > > >>>The CONFIG_RTE_LIBNAME config option is kept as it will be use to > > >>>always generate a linker script that acts as a single combined library. > > >>> > > >>>Signed-off-by: Sergio Gonzalez Monroy > > >>> > > >>No. We use combined library and it greatly simplfies the application > > >>linking process. > > >> > > >After all the opposition this patch had in v2, I did explain the current > > >issues > > >(see http://dpdk.org/ml/archives/dev/2015-March/015366.html ) and this was > > >the agreed solution. > > > > > >As I mention in the cover letter (also see patch 2/5), building DPDK > > >(after applying this patch series) will always generate a very simple > > >linker script that behaves as a combined library. > > >I encourage you to apply this patch series and try to build your app > > >(which links against combined lib). > > >Your app should build without problem unless I messed up somewhere and it > > >needs fixing. > > > > Is it possible to generate a pkgconfig file (dpdk.pc) that contains all of > > the setting needed to compile and link with dpdk? That will greatly > > simplify usage. > > > > A linker script is just too esoteric. > > > Why esoteric? We're not talking about a linker script in the sense of a binary > layout file, we're talking about a prewritten/generated libdpdk_core.so that > contains linker directives to include the appropriate libraries. You link it > just like you do any other library, but it lets you ignore how they are broken > up. > > We could certainly do a pkg-config file, but I don't think thats any more > adventageous than this solution. As already commented (http://dpdk.org/ml/archives/dev/2015-March/015367.html), pkgconfig could be something useful in any case (single or multi-libraries). Having a linker script to replace the single ("combined") library may be convenient in some cases but do not replace pkgconfig.