From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id C66F0A0A02;
Tue, 18 May 2021 18:28:38 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 4AF094068E;
Tue, 18 May 2021 18:28:38 +0200 (CEST)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
by mails.dpdk.org (Postfix) with ESMTP id 8D3CE40041
for <dev@dpdk.org>; Tue, 18 May 2021 18:28:37 +0200 (CEST)
IronPort-SDR: IlyeglI7Qea3qVjIqeCtmajRXB+nWx2j1EO8QJA2X2KgJn71qiIJztn9vxvFxl9DBdwWw46z+z
CMfJP85A8SuQ==
X-IronPort-AV: E=McAfee;i="6200,9189,9988"; a="286288386"
X-IronPort-AV: E=Sophos;i="5.82,310,1613462400"; d="scan'208";a="286288386"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
18 May 2021 09:27:30 -0700
IronPort-SDR: V68bAaZwOzdgh8Nr4SVrF1rLqCBVQlWzfs2bbJ7KT1aZXCIYxW6dQ+JEoMke9cMNUtkVovAy1S
ppLBCrEYnWTg==
X-IronPort-AV: E=Sophos;i="5.82,310,1613462400"; d="scan'208";a="439512626"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.224.73])
([10.213.224.73])
by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
18 May 2021 09:27:24 -0700
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
Chengwen Feng <fengchengwen@huawei.com>,
"thomas@monjalon.net" <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "jerinj@marvell.com" <jerinj@marvell.com>,
Ruifeng Wang <Ruifeng.Wang@arm.com>,
"viktorin@rehivetech.com" <viktorin@rehivetech.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"jerinjacobk@gmail.com" <jerinjacobk@gmail.com>,
"juraj.linkes@pantheon.tech" <juraj.linkes@pantheon.tech>, nd <nd@arm.com>
References: <1620808126-18876-1-git-send-email-fengchengwen@huawei.com>
<1620986039-29475-1-git-send-email-fengchengwen@huawei.com>
<1620986039-29475-3-git-send-email-fengchengwen@huawei.com>
<DBAPR08MB5814CF0C67992FBFB0C45F1298509@DBAPR08MB5814.eurprd08.prod.outlook.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-User: ferruhy
Message-ID: <394de3ea-f0ba-a5a3-e751-be04f479281d@intel.com>
Date: Tue, 18 May 2021 17:27:20 +0100
MIME-Version: 1.0
In-Reply-To: <DBAPR08MB5814CF0C67992FBFB0C45F1298509@DBAPR08MB5814.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile
method
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 5/14/2021 3:12 PM, Honnappa Nagarahalli wrote:
> <snip>
>
>>
>> Currently, the SVE code is compiled only when -march supports SVE (e.g. '-
>> march=armv8.2a+sve'), there maybe some problem[1] with this approach.
>>
>> The solution:
>> a. If the minimum instruction set support SVE then compiles it.
>> b. Else if the compiler support SVE then compiles it.
>> c. Otherwise don't compile it.
>>
>> [1] https://mails.dpdk.org/archives/dev/2021-April/208189.html
>>
>> Fixes: 8c25b02b082a ("net/hns3: fix enabling SVE Rx/Tx")
>> Fixes: 952ebacce4f2 ("net/hns3: support SVE Rx")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Looks good to me.
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>
Applied to dpdk-next-net/main, thanks.
(Only this patch, 2/2, applied, not whole set)