From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 3B8F32BE5 for ; Mon, 15 Jan 2018 11:27:17 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2018 02:27:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,363,1511856000"; d="scan'208";a="21572361" Received: from unknown (HELO [10.237.221.96]) ([10.237.221.96]) by fmsmga004.fm.intel.com with ESMTP; 15 Jan 2018 02:27:15 -0800 To: "De Lara Guarch, Pablo" , "dev@dpdk.org" Cc: "Ananyev, Konstantin" , "Yigit, Ferruh" , "Gonzalez Monroy, Sergio" , "Doherty, Declan" , "akhil.goyal@nxp.com" References: <1513083027-11741-1-git-send-email-radu.nicolau@intel.com> <1513083027-11741-2-git-send-email-radu.nicolau@intel.com> From: Radu Nicolau Message-ID: <394f830c-ef7b-9c20-61ef-fcbbdbf7e214@intel.com> Date: Mon, 15 Jan 2018 10:27:14 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: implemented security session get size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 10:27:18 -0000 On 1/8/2018 10:15 AM, De Lara Guarch, Pablo wrote: > >> -----Original Message----- >> From: Nicolau, Radu >> Sent: Tuesday, December 12, 2017 12:50 PM >> To: dev@dpdk.org >> Cc: Ananyev, Konstantin ; Yigit, Ferruh >> ; Gonzalez Monroy, Sergio >> ; De Lara Guarch, Pablo >> ; Doherty, Declan >> ; akhil.goyal@nxp.com; Nicolau, Radu >> >> Subject: [PATCH 2/3] net/ixgbe: implemented security session get size > Use "implement" in infinitive. > >> Signed-off-by: Radu Nicolau >> --- >> drivers/net/ixgbe/ixgbe_ipsec.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c >> b/drivers/net/ixgbe/ixgbe_ipsec.c index 105da11..720d6a1 100644 >> --- a/drivers/net/ixgbe/ixgbe_ipsec.c >> +++ b/drivers/net/ixgbe/ixgbe_ipsec.c >> @@ -446,6 +446,12 @@ ixgbe_crypto_create_session(void *device, } >> >> static int > >> +ixgbe_crypto_session_get_size(__rte_unused void *device) { > Do you think passing device to the function prototype is needed? > Are you expecting other drivers to use it? I added for consistency with cryptodev. > > Also, move the braces to a new line (both opening and ending). They are correctly formatted on the patch itself. > > >> + return sizeof(struct ixgbe_crypto_session); } >> + > Thanks, > Pablo >