From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0574542B84;
	Tue, 23 May 2023 17:47:04 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E9DFD410EE;
	Tue, 23 May 2023 17:47:03 +0200 (CEST)
Received: from mail.redfish-solutions.com (mail.redfish-solutions.com
 [24.116.100.90])
 by mails.dpdk.org (Postfix) with ESMTP id D70D240689;
 Tue, 23 May 2023 17:47:02 +0200 (CEST)
Received: from smtpclient.apple (65-36-4-84.static.grandenetworks.net
 [65.36.4.84]) (authenticated bits=0)
 by mail.redfish-solutions.com (8.17.1/8.16.1) with ESMTPSA id 34NFkwPi651284
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 23 May 2023 09:47:00 -0600
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\))
Subject: Re: [PATCH 1/1] vfio: Make buildable with MUSL runtime
From: Philip Prindeville <philipp_subx@redfish-solutions.com>
In-Reply-To: <1984747.PIDvDuAF1L@thomas>
Date: Tue, 23 May 2023 10:46:46 -0500
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>,
 stable@dpdk.org
Content-Transfer-Encoding: 7bit
Message-Id: <39530A91-B51D-43D7-8D3B-A8E2ABC403C7@redfish-solutions.com>
References: <20230520180730.5789-1-philipp@redfish-solutions.com>
 <9ebbc874-a6b0-b2f0-8e3b-e1f7d5bd0e8f@intel.com> <1984747.PIDvDuAF1L@thomas>
To: Thomas Monjalon <thomas@monjalon.net>
X-Mailer: Apple Mail (2.3731.500.231)
X-Scanned-By: MIMEDefang 3.3 on 192.168.8.3
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org



> On May 23, 2023, at 5:33 AM, Thomas Monjalon <thomas@monjalon.net> wrote:
> 
> 22/05/2023 11:27, Burakov, Anatoly:
>> On 5/20/2023 7:07 PM, Philip Prindeville wrote:
>>> From: Philip Prindeville <philipp@redfish-solutions.com>
>>> 
>>> pread64() and pwrite64() are declared in <unistd.h> in MUSL and
>>> other (i.e. not glibc) C runtimes.
>>> 
>>> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
>> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
> 
> It was "buildable" already, and I don't understand how.
> In any doubt, I've added Cc: stable@dpdk.org for backports.
> 
> Applied, thanks.
> 
> 


Yeah, it builds with glibc just fine.  MUSL is another story...