From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 6BBCB1BB72 for ; Fri, 19 Apr 2019 13:26:00 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id F09B52129D; Fri, 19 Apr 2019 07:25:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 19 Apr 2019 07:25:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=5HrIQrexNwfSBzoQO+4FpbrkjgMDgg6VAxGAZ7jnO8U=; b=c9l2Mufqz8qP bYlur5QY6E/H/skXOWAWewoXVSCr96rwPAvSjhEpXcg/i7xNSteC9TZGvin5KOPb OJH06WwJbV1a5/sesHrUTTcYrNxreVWNsiPkMOumKgWK1e73CxQxrP2qjbRjLiq7 40ClDprZE2a1TyV3+uWKlzsbeJ1yU0k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=5HrIQrexNwfSBzoQO+4FpbrkjgMDgg6VAxGAZ7jnO 8U=; b=T4QJujO3MZj//A3c/nSZrCEClY0+/ih3Teb8XP8AQuGZB5NEgsbg6sBbl hBz3GJKY54FDsh2WmBrDzBxwvfK8O4r8VzRkTHF63g7Bs+ZiHkfb5YqdhRYsFBs/ XehHtZsDwcm+9Hoqwdolyn0vLfsTGhvxyb7Hqv9FANALChHXmXN528zvTsDZWuH6 xpcKmxWaMwr2g3M2cq8wO1FOr7tlame1yAEf3qtInoFe/FcdS24JeFb74SO+7Ani 0IblLr2DjZnBdbaOqtR0e+oq+qsrthix86/PmRjfiJMbaOc5nAt0f7ixHrFG4RZE x/hDkG6MgToChk4EwY5OzhN/8/i0Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfeejgdefkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EF656E4122; Fri, 19 Apr 2019 07:25:57 -0400 (EDT) From: Thomas Monjalon To: "Jozwiak, TomaszX" Cc: dev@dpdk.org, bruce.richardson@intel.com, david.marchand@redhat.com, fiona.trahe@intel.com, yskoh@mellanox.com, tomaszx.cel@intel.com Date: Fri, 19 Apr 2019 13:25:56 +0200 Message-ID: <3955282.IgHOaonqCx@xps> In-Reply-To: References: <1555667827-3715-1-git-send-email-tomaszx.jozwiak@intel.com> <4602312.zkvPNgCjdN@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Apr 2019 11:26:00 -0000 19/04/2019 12:57, Jozwiak, TomaszX: > > What is supposed to be "i"? > > It is initialized at 0 and never touched. > > > It's touched inside test_deflate_comp_decomp function. What do you mean? It's a local variable and its address is referenced: int_data.buf_idx = &i; It looks really wrong. Another error is seen in FreeBSD. Should I totally revert this patch? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DAA72A00E6 for ; Fri, 19 Apr 2019 13:26:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BFCC61BB78; Fri, 19 Apr 2019 13:26:01 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 6BBCB1BB72 for ; Fri, 19 Apr 2019 13:26:00 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id F09B52129D; Fri, 19 Apr 2019 07:25:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 19 Apr 2019 07:25:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=5HrIQrexNwfSBzoQO+4FpbrkjgMDgg6VAxGAZ7jnO8U=; b=c9l2Mufqz8qP bYlur5QY6E/H/skXOWAWewoXVSCr96rwPAvSjhEpXcg/i7xNSteC9TZGvin5KOPb OJH06WwJbV1a5/sesHrUTTcYrNxreVWNsiPkMOumKgWK1e73CxQxrP2qjbRjLiq7 40ClDprZE2a1TyV3+uWKlzsbeJ1yU0k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=5HrIQrexNwfSBzoQO+4FpbrkjgMDgg6VAxGAZ7jnO 8U=; b=T4QJujO3MZj//A3c/nSZrCEClY0+/ih3Teb8XP8AQuGZB5NEgsbg6sBbl hBz3GJKY54FDsh2WmBrDzBxwvfK8O4r8VzRkTHF63g7Bs+ZiHkfb5YqdhRYsFBs/ XehHtZsDwcm+9Hoqwdolyn0vLfsTGhvxyb7Hqv9FANALChHXmXN528zvTsDZWuH6 xpcKmxWaMwr2g3M2cq8wO1FOr7tlame1yAEf3qtInoFe/FcdS24JeFb74SO+7Ani 0IblLr2DjZnBdbaOqtR0e+oq+qsrthix86/PmRjfiJMbaOc5nAt0f7ixHrFG4RZE x/hDkG6MgToChk4EwY5OzhN/8/i0Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfeejgdefkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EF656E4122; Fri, 19 Apr 2019 07:25:57 -0400 (EDT) From: Thomas Monjalon To: "Jozwiak, TomaszX" Cc: dev@dpdk.org, bruce.richardson@intel.com, david.marchand@redhat.com, fiona.trahe@intel.com, yskoh@mellanox.com, tomaszx.cel@intel.com Date: Fri, 19 Apr 2019 13:25:56 +0200 Message-ID: <3955282.IgHOaonqCx@xps> In-Reply-To: References: <1555667827-3715-1-git-send-email-tomaszx.jozwiak@intel.com> <4602312.zkvPNgCjdN@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190419112556.tT9lo5mPaUWqshq8xlrCdZoz8xvc3u4w71f7NWokes8@z> 19/04/2019 12:57, Jozwiak, TomaszX: > > What is supposed to be "i"? > > It is initialized at 0 and never touched. > > > It's touched inside test_deflate_comp_decomp function. What do you mean? It's a local variable and its address is referenced: int_data.buf_idx = &i; It looks really wrong. Another error is seen in FreeBSD. Should I totally revert this patch?