Re: [dpdk-dev] [PATCH v4 02/44] bus/vdev: add driver IOVA VA mode requirement

["Kinsella, Ray" <mdr@ashroe.eu>]

On 26/01/2021 12:50, David Marchand wrote:
> On Tue, Jan 26, 2021 at 11:16 AM Maxime Coquelin
> <maxime.coquelin@redhat.com> wrote:
>>
>> This patch adds driver flag in vdev bus driver so that
>> vdev drivers can require VA IOVA mode to be used, which
>> for example the case of Virtio-user PMD.
>>
>> The patch implements the .get_iommu_class() callback, that
>> is called before devices probing to determine the IOVA mode
>> to be used, and adds a check right before the device is
>> probed to ensure compatible IOVA mode has been selected.
>>
>> It also adds a ABI exception rule to accommodate with an
>> update on the driver registration API
>>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>> ---
>>  devtools/libabigail.abignore    |  2 ++
>>  drivers/bus/vdev/rte_bus_vdev.h |  4 ++++
>>  drivers/bus/vdev/vdev.c         | 29 +++++++++++++++++++++++++++++
>>  3 files changed, 35 insertions(+)
>>
>> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
>> index 1dc84fa74b..170304c876 100644
>> --- a/devtools/libabigail.abignore
>> +++ b/devtools/libabigail.abignore
>> @@ -11,6 +11,8 @@
>>  ; Explicit ignore for driver-only ABI
>>  [suppress_type]
>>          name = eth_dev_ops
>> +[suppress_function]
>> +        name_regexp = rte_vdev_(|un)register
>>
>>  ; Ignore fields inserted in cacheline boundary of rte_cryptodev
>>  [suppress_type]
> 
> Ray,
> Are you okay with this exception?

Ask a perhaps silly question, 
shouldn't rte_vdev_register & rte_vdev_unregister have been INTERNAL in any case?

> Thanks.
> 

Ray K