From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34BF6A052A; Tue, 26 Jan 2021 14:23:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 92E901414BB; Tue, 26 Jan 2021 14:23:21 +0100 (CET) Received: from mail-109-mta17.mxroute.com (mail-109-mta17.mxroute.com [136.175.109.17]) by mails.dpdk.org (Postfix) with ESMTP id 5B7121414B4 for ; Tue, 26 Jan 2021 14:23:19 +0100 (CET) Received: from filter004.mxroute.com ([149.28.56.236] 149.28.56.236.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by mail-109-mta17.mxroute.com (ZoneMTA) with ESMTPSA id 1773edccfd20009319.002 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Tue, 26 Jan 2021 13:23:14 +0000 X-Zone-Loop: 2bf93499b122f59c382e9007fd5df7a2b7377d990d5a X-Originating-IP: [149.28.56.236] Received: from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109]) by filter004.mxroute.com (Postfix) with ESMTPS id 97D083EDA7; Tue, 26 Jan 2021 13:23:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=sKKdYhL4GgJb9V3MwJ68J8mMkUkUxMaLhDbxTQV1Gt4=; b=TpqzY6UY+HQHGH32ffTMpAnHpX tx11KaoqSKUz4dqjgf7r8/EEwD2Jz4sfRq+8d0l3i2Jk4GBU11qv8NGgpqZzobUgTo8gGXErOlv5/ fYb3lHh/lAIueWSW1OL39AhSR52XhrgdodPs1m521UvDFCpREc9TxvcbsxeEt9GWFrgApEn2WPSIK Dw0ERsosdCUSNmvR2lLuvJNuIcGzra35L2ydEZHE66kHd43COGbLjjG9lRHA9uz+eU5ckxgb+H1B7 ZWi1zZyC8GqjReZ+Owda/4Emk5DtEzbyWsjQ6UBOLtc6LL8inOK21EWP4mNzNIZ2up7Qee2udgMsT iP7ZZ++w==; To: David Marchand , Maxime Coquelin Cc: dev , "Xia, Chenbo" , Olivier Matz , Adrian Moreno Zapata References: <20210126101639.250481-1-maxime.coquelin@redhat.com> <20210126101639.250481-3-maxime.coquelin@redhat.com> From: "Kinsella, Ray" Message-ID: <39585a4d-e937-b186-c482-b0dc0a48f762@ashroe.eu> Date: Tue, 26 Jan 2021 13:23:10 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH v4 02/44] bus/vdev: add driver IOVA VA mode requirement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 26/01/2021 12:50, David Marchand wrote: > On Tue, Jan 26, 2021 at 11:16 AM Maxime Coquelin > wrote: >> >> This patch adds driver flag in vdev bus driver so that >> vdev drivers can require VA IOVA mode to be used, which >> for example the case of Virtio-user PMD. >> >> The patch implements the .get_iommu_class() callback, that >> is called before devices probing to determine the IOVA mode >> to be used, and adds a check right before the device is >> probed to ensure compatible IOVA mode has been selected. >> >> It also adds a ABI exception rule to accommodate with an >> update on the driver registration API >> >> Signed-off-by: Maxime Coquelin >> Signed-off-by: David Marchand >> --- >> devtools/libabigail.abignore | 2 ++ >> drivers/bus/vdev/rte_bus_vdev.h | 4 ++++ >> drivers/bus/vdev/vdev.c | 29 +++++++++++++++++++++++++++++ >> 3 files changed, 35 insertions(+) >> >> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore >> index 1dc84fa74b..170304c876 100644 >> --- a/devtools/libabigail.abignore >> +++ b/devtools/libabigail.abignore >> @@ -11,6 +11,8 @@ >> ; Explicit ignore for driver-only ABI >> [suppress_type] >> name = eth_dev_ops >> +[suppress_function] >> + name_regexp = rte_vdev_(|un)register >> >> ; Ignore fields inserted in cacheline boundary of rte_cryptodev >> [suppress_type] > > Ray, > Are you okay with this exception? Ask a perhaps silly question, shouldn't rte_vdev_register & rte_vdev_unregister have been INTERNAL in any case? > Thanks. > Ray K