From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0083.outbound.protection.outlook.com [104.47.32.83]) by dpdk.org (Postfix) with ESMTP id 96A935A44 for ; Thu, 12 Jan 2017 13:28:15 +0100 (CET) Received: from BN6PR03CA0025.namprd03.prod.outlook.com (10.175.124.11) by DM2PR0301MB0750.namprd03.prod.outlook.com (10.160.97.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.829.7; Thu, 12 Jan 2017 12:28:13 +0000 Received: from BL2FFO11OLC015.protection.gbl (2a01:111:f400:7c09::141) by BN6PR03CA0025.outlook.office365.com (2603:10b6:404:10c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.845.12 via Frontend Transport; Thu, 12 Jan 2017 12:28:13 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11OLC015.mail.protection.outlook.com (10.173.160.81) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.803.8 via Frontend Transport; Thu, 12 Jan 2017 12:28:13 +0000 Received: from [127.0.0.1] ([10.232.134.49]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v0CCS59s001492; Thu, 12 Jan 2017 05:28:10 -0700 To: "De Lara Guarch, Pablo" , "dev@dpdk.org" References: <20161205125540.6419-1-akhil.goyal@nxp.com> <20161222201700.20020-1-akhil.goyal@nxp.com> <20161222201700.20020-3-akhil.goyal@nxp.com> CC: "thomas.monjalon@6wind.com" , "Doherty, Declan" , "hemant.agrawal@nxp.com" , "Mcnamara, John" , "nhorman@tuxdriver.com" , Horia Geanta Neag From: Akhil Goyal Message-ID: <39599067-d86a-7e34-de28-7b6eef631d4f@nxp.com> Date: Thu, 12 Jan 2017 17:58:05 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131286976934759845; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(336005)(39850400002)(39410400002)(39380400002)(39840400002)(39860400002)(39450400003)(39400400002)(2980300002)(1110001)(1109001)(339900001)(3190300001)(24454002)(189002)(13464003)(199003)(377454003)(305945005)(77096006)(120886001)(33646002)(2501003)(23746002)(38730400001)(83506001)(92566002)(93886004)(54906002)(85426001)(230700001)(104016004)(105606002)(106466001)(76176999)(31696002)(7126002)(81156014)(81166006)(64126003)(2906002)(97736004)(626004)(8676002)(54356999)(68736007)(7246003)(50986999)(86362001)(8656002)(5660300001)(356003)(47776003)(229853002)(65806001)(50466002)(36756003)(65956001)(4001350100001)(31686004)(2950100002)(8936002)(4326007)(189998001)(65826007)(5001770100001)(6666003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR0301MB0750; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11OLC015; 1:tIu6pJ0aLS8lXw16RlcvGhehuhN09xNab547dwlyELvPfcjI5Ty8ErpHusikwMKWTRg0NFMu/V3hBcIYjiuRl56l2dSiI6olGUgz0GOQT65ThP/wnDF7VIcQUaujAYF/gcJ/czFXqbpfMZjY/FW9P5RPw/3cKzDTGDRGlelJ/dM59cqViGr++XVEJxC9cfrP5RLlirKWucR4sJmGcLFxxcUCFdBAc/s2XKEB/rfW7x5ONwQT+mIsL4EGG1Wq2Dex54OJFK0qWNbFyE5KWCAiOcDWl68omXH+AKuNhcBZVKwLq07lzCxo32ntvlwF13QTS/AfFLXmOvNqXT3GUN1c0AUUNs1iu4gWM7oQYK+x9QrcvJK5J4wnSuIFgLWDFdjwoHAHNH8Xn+3tjQWCf9Fh4KWCX5q386MHWBJjuPuFKUAdxnnSBoltcv/d0dGooOELfReFaQUqjS1tHFr06yry/byjvE/iYwG2p4wsQPEyN6kJ/HJRB8F9wTnafHxuvazb954Y4ZNdG/1ZWpDaPG4Q9lCDF2MkslA+/FRkyZtzRjFWFKwxNHo0/+RLyVmBiO9hiIihTmTrHBg4LfFh3T1ltjsWocQYtl9Lh2AGYglKzE078ea2supHe2q+TsXgtuu7 X-MS-Office365-Filtering-Correlation-Id: 58cc632f-f994-495c-6c49-08d43ae67a49 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:DM2PR0301MB0750; X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0750; 3:CyaEQsPyc2W6jsOZ+6HiTVMlbKlCpmrWKKYmnG+9BSxEmC+l+WhKqckXvWjWGCnZtaA29uX5X11lHi4ZZcJfu7dJbmHII/824LtO6xMicogyTmBFkhCZEHPqfkVkyeWlhWsOrxW1/E1S4JltU7dot8Z1V3zqUfQSaNSyDHqwxBOpFsR9YxXyZ3MWYNgzrc0M0BMlvo/jANeHq5N5/uA9ueBXETyTEz9k7MwlezV132ixkbaYfSsdc/WUJZJnVq1/7iry3m6M/RtTwEb73mhHGR2elXm8D52L9WWXEgTdi01P72g1gaU6jmB0zhltLVoEkwpm221GcUXsLZByhQFRBDJKkq2P8qAAOvR9DkeB0tsMPjv0lIuiDHOgGF2Bhbfx X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0750; 25:YZCefmHaMMnW/JwyXExW5luNvqN693CR76O6cuU1ktb/ScVsvchQn1m9PSA+AR+v2BM6FYKuh50rPOiZQjmIO7TLowyw/aoLXYZ4qvUUCkiNQxLttDx8m212vbX9QDYjAW7aREUfCuXwikBc3Qi39u3Zk71Ee1ChAxFm5eqCJEoLujfYmKI71d4LJt7QgGeayM/SK6f3DodF1kBms5NUe4/YgCqf/KR/vFjYTkqmAKQ2TvT7s4Y2PRgnKbGfKSUHYk2/83PIsdHU6vFfog6ji4i9+TZCHDMeuxW80/cByWcXk7LryNSnjiT/nfET0fOUVHJO9Ij5tFjoLx50u5tc61EsF8T5uaJloSYzfo5KeyKz0hWAu/e3zmjWyGrNt7iqG3sdxqi4QOc9InL5yibl9+7n6IPSeUHk/9fFFV+m37+iSY7CSdv2aNwDuQoN84Zf7MSypa98gTCLc2h+iPmUQUTCdC8v1ackg1q5JM7JeInOogwvPvsePVajfb3fgJujrtcxyXZizUbSOr87BUt8wm4vHSXcu9vjpSrEaf5oSaFs+7ffmz3gFqGERI3wAXxcMxXYgABQaLgTfdWBsZy1xFtvazmrYCF/Ov1GbfeIH1HDhShvXplxz47u199L6E6kIFJYp2fKOksArBUw9GPTO/FEy4ZTlBAElqXIfjAZnE/xD6o4+Aol+fBoi88gtoiHFQMT1EnsPjDDugCPiVl7iOzEW8bjt7pNj7eBoIvNW4gwRY2d6hvA8ty0+650Ub8gYZth99lBoaZCQ/OxLb++FOtNIkpar4bK9rgXTBUqUBOHtHCWekepVEAuhm2wfOpT X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0750; 31:73WB5GlJyu6OXS7jd3FiAk9dhibkMbQkvpEg2FOzqS1pcDSxQMKqknTLMsFLzPvY0esS0agYtwmCDXxfkIcfrIoc3lbZYpFPDpfxEbCxPRCxmATY2rTtHDPv604Npr2vYl+qD9PQt5BRNIvZz2uW9gPExpYjJTeM0Vj+gsZFkdJPZkmte+WbINpbEL/+GbAI87p6vJbLpqd/vofxTlFxtmgzZGhKbilWgRkPUnD2vlC9fguY3CBxa2RKYdFMDo1Uw7ZKJcYDNFhw7vCZCNcCFhcBwCu+ac15xSs82k1yXJY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(5005006)(8121501046)(13024025)(13015025)(13023025)(13017025)(13018025)(10201501046)(3002001)(6055026)(6096035)(20161123561025)(20161123559025)(20161123556025)(20161123563025)(20161123565025); SRVR:DM2PR0301MB0750; BCL:0; PCL:0; RULEID:(400006); SRVR:DM2PR0301MB0750; X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0750; 4:MdhTTCyXOh669sUxhqJjZC/i6ZrdyzYA2RrPxtgDT/SakKOiM8NmIiPbk+iBNS+HlNp8GhOfhJgZTzR62haZWWaap6YCR1IMSkbD70Cjg4C36P71NOA++VYE3mDChgqJtRIaepdK7tC544Qn9xAz99gZWvOXf/r1fIyBgPiMX0BlLmCsl7FyaXuLb3OTMb/+YUN/CX6qa4VQxytZ0h4PnFcmlgqM9diG42Cm6im7muZf1cJBJhuyjBi9AowJQsWP2ZZxKPBTnDPrlZ/QM2kw+QEkyScLkcX6+7e6+jJ+0MXKzxaQ4LwMvO1YfxjmXiLTZ9ok6SQk+V7JGJ5Gowp/oksPa9Zoza4srWkhg6h51L+gLmx3aWc20FYHWP3J94P0dkNsmEKu7L2DaUij/HGBBdJBqftUek+67JDPRq1cytHoxu0CrzMSrz4kLTk9krKZupDRceuYpd1pHbp2pkvv74Q31ox5HuXGuX+NHoZFsIK/CGi2wl5Qw1IaEbQNK0MaQsGd9OI8MhjBfwoZvrY9hKt/Z7G3tMCjV0ldc0ZENjNJ1eLiUrI+SibmfOst5W5dEX4GPEK9eCHhGtJkV6mdkB+Jl7IAk+1dKdgbXHFC7iKPJJrvZ95NA3M0wCDltMcLhjY6R7+yzmXLEYc/hlpdd5Gpc+MsU4mFtlMxeH5zHd6HXmFxxCgu0zs7O6u48YJCT2jCyRwPul91KLg2GAfN2l1kIbaTJSFdCiS+f/mWGjK6gkaHdtXJR5kl0XWiuOQE X-Forefront-PRVS: 018577E36E X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DM2PR0301MB0750; 23:szv0SHbeAEyNeIpvOkF8idmBCK6GX79tRGK?= =?Windows-1252?Q?immrnRnGg8pEatZmSzb6byrzGH/cVNWB1BkR0zEJ0cxg8BtH1SFl0dD5?= =?Windows-1252?Q?QlK1f9Bzebjop4lt6hNNYh+MrlF5KUHCYexEJYnWIhJeGuwLJx/+oJ0s?= =?Windows-1252?Q?DRclCUimqw8bijh8o455hKqBRcbVF3qF1QPSv9FLdlwoRj1M8tg2xslq?= =?Windows-1252?Q?b0nFwBFbv2lSMwjORsOLxqLpFJi2PmaweomIzDMuaLPNXvX8xKxhFtn/?= =?Windows-1252?Q?a8rrn6HpIeRORMLhDQpchKs8euNNYdtn0XxOpidngPg+AUeKPUXSRgpU?= =?Windows-1252?Q?ftLps8n9ct2hEAjuQVBErT3eunjKMQqh/wLDiTxpmHidBLvclZDhIz2I?= =?Windows-1252?Q?0qso1dOLOO0lRUCTJ7hXxB5z/zCIFTDWcrBECGH+vuILM9aydW72XQIb?= =?Windows-1252?Q?p1xRhzBudCRlTHND6VSL7R73adD1Sg8882gAEAjlWYmen2ztchMfylS+?= =?Windows-1252?Q?/PjfGiouIm5OSVXAJpIkEAipp9heweDTqPdi33vHHbMgben2Yzb5WLbA?= =?Windows-1252?Q?QEQ3C0vKM/GiutA09+4OWAiIkCLEzovL+heMmxncf4DbL7Led5SF1I2m?= =?Windows-1252?Q?w7GFi87SGLIOiHzvbdKgmpIwlK3bw/Az2j0BPLvszrnSQ7nTCTz16Dqn?= =?Windows-1252?Q?dbEQh/+hqY/cUmc6+DrRkjYCj2KtTI4W9s4ikADmDVMUYXsqLtevWBYz?= =?Windows-1252?Q?R+bn/FLuUGmeHvWgdAbOGPH9NYYdr81/WYo9jVJZBLeKNvH3m/Sd1s03?= =?Windows-1252?Q?+J5UjipSif3Lvgc4hJn4TxUF7xcV0do3USM/SAJGPECrS4iK9Ix6v/Hg?= =?Windows-1252?Q?XedNsenrXAlVFjePfC10WP+uV14T3bOqljB/Z6KwR8aDeTMp47sGZe9Q?= =?Windows-1252?Q?/c7VGAYWfHJFlqMT3+07P6Hd6Z4fFEK9nElacKLPMGnnK0Ln7MzAE88J?= =?Windows-1252?Q?YxjECiJbPgZy6P8UdJDqRYYQ/mrIIzDyhnepVzzR97sQS+YlWEHlEY3N?= =?Windows-1252?Q?IcOIbeHHEiBE98tkArSjViyEeP56olqTFi1u+dUjup6yjPHcbPp9HuOR?= =?Windows-1252?Q?9cU1O5iFZbNSV5PwhtFY0RFK27r2g5ewHMboCbjLD/YhDKbLcvL3HKJS?= =?Windows-1252?Q?NJH+ojJaqNfwaA6x5TcEEb1QFMGrNScJM4ejkBnSOfqEAP4/lAs2m2ub?= =?Windows-1252?Q?Y5ADMsuIYM2m8TtXUUbdBO8ha/2Va+J/sWV+xJVlEzJaqOoLuY60Y33c?= =?Windows-1252?Q?tjyd2iyvyF8LQc9fG++iHLn42a+jt5vz932PaHNPsmbV1YSQdP4s9tRX?= =?Windows-1252?Q?QKKdMXggm9mimo8Ac1igf1GyJXNHn5VgUxbCiTWP2rHNpWYEEh3Y02G6?= =?Windows-1252?Q?2FZHaRnTdEPVYzIB3fHR9uJN3IxaJXPIs/IY9GeM8W2UcAlkW8STB5Tn?= =?Windows-1252?Q?sVOGb7+k9SMeV5FwMScq67OQfhai+NsRQUHptnhaz3gfSIVQOjwuXhL7?= =?Windows-1252?Q?WH+DijUp+gQXFIQMmV/igp5GGQk80nuReg2uxDDxngnIA0iRpuAhf22+?= =?Windows-1252?Q?Q8fKDBSSbdE6bVO4QPa25mQbvMyAHLcwSPn1KR9AlAnSNe5qFregiYjz?= =?Windows-1252?Q?fPzxYJLaC+qDpNn1+2anL/HQw1MOMMfJzVKw03Y2TGUq9KqpcpFPiOGz?= =?Windows-1252?Q?CrMvUH94fbpYOR/vzG2Xpn+bA9DOGGWx4jOD9r8I=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0750; 6:0F9hAWD7xZs189ecNB+vx0uJMrWGALx6MajUlTI4bZffU+/sr4dxRfyRmsvQigZe5dAhmY9YUo7toojTq9Ulhcl2B7lhkkEyIPoNjJr1WxhA5mxXzHu0oLnBPI4SeIWzUqxweJB1cVtyouNho/9VO7oDjqFhJutcJfXzNdHCB+JGryM0iWGut9yKAIxh/Gs+wVCM9tTzRzp1wXER4cdIbIJgVW78r4fLC42KoBHWx4jU67eQNZ6gKSBUiXqyD3ykNTaoGMTCSnjVGlK0z5bwbkpxZjkSz/xpMuJKOziRzv0uN25FwwdRtnJNvqMaWODVjAhTKwQx1kZ+s1IYWdxuGZHKmJw60QS5SeGkg6HwAiQwpvDiOCVx0oWoHGhbMAQDPRz/fHufpkToVHYjec6YtwebzzUpPUn4x7l1ZNOEp9YjnpyrrQtXLi6k+9Cz3C8s; 5:VZDMgm94w1AGqQ0ZZZePoUGq6Gk5NfP+Ucbu341VjojQ6a1NtjKWb8+M5k+0iZGTrrj/gb+pXu6bDfUfNeWJNxIi/yB3xzMTTlr7dzJzs074LGHoN/uDXnkhq5EGWps8Z+vD7onWwxyVdu3MyrybnFXaQ9dngRjjmb1iQLqqxdf/8cjL0UzWTArOaQaldZWH; 24:o6/YxljlGhaIOEKfOcsa7s7Qk66WDRXzZUD8Hgp4WG7SokN0xASnmghazLwp338mIbudAU4O2GuU48V/A82wCq5dpGITuqRzRk3peQI4s5M= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0750; 7:sMVeYnV0z6BsjMAjexqu7geKpoARGz5ANHr7OIodVngjVflyc9GBINR6IViKJF8m6buh7ZMyPUdjsZFwYFeBbxFLWO8lkYM0L/laaTUcrT9CBZJi79bJUBYzs14QkhjRCBFJtlmck1h+IBt6PDblDa+3HMmWe3SHAbdT5QoC1HByz4sGJL7RkXcSDi5LNF4hQTJ4+qw3xZggxjkVInVI1eLEzuT7tjwOeZbKqWyq9B5e4iUyei7+HKof+Nv2zEhop7pJG2mgdI7klLPWlQfJJbY2/2g+/gM/3pkNFVXG+9M4n6/fvYgbqUAAfwXYo/Msr6pIFzUayUdRHnDmc7j1so2FynMWCzNGjEHFOulCR2mF/zltbaPeWK+cwQuodZ4DRQ1AQdDhAP37g95dfjm9fFYXlaYrsNFkbRD0TPm6ioNg7odKTXANYI0zeSYv11nGsneEo+RQmatgkeknLJq7iw== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2017 12:28:13.2419 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB0750 Subject: Re: [dpdk-dev] [PATCH v2 02/11] crypto/dpaa2_sec: Run time assembler for Descriptor formation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2017 12:28:16 -0000 On 1/9/2017 7:25 PM, De Lara Guarch, Pablo wrote: > > >> -----Original Message----- >> From: Akhil Goyal [mailto:akhil.goyal@nxp.com] >> Sent: Thursday, December 22, 2016 8:17 PM >> To: dev@dpdk.org >> Cc: thomas.monjalon@6wind.com; Doherty, Declan; De Lara Guarch, Pablo; >> hemant.agrawal@nxp.com; Mcnamara, John; nhorman@tuxdriver.com; >> Akhil Goyal; Horia Geanta Neag >> Subject: [PATCH v2 02/11] crypto/dpaa2_sec: Run time assembler for >> Descriptor formation >> >> A set of header files(hw) which helps in making the descriptors >> that are understood by NXP's SEC hardware. >> This patch provides header files for command words which can be used >> for descriptor formation. >> >> Signed-off-by: Horia Geanta Neag >> Acked-by: Akhil Goyal >> --- > > ... > >> diff --git a/drivers/crypto/dpaa2_sec/hw/rta.h >> b/drivers/crypto/dpaa2_sec/hw/rta.h >> new file mode 100644 >> index 0000000..7eb0455 >> --- /dev/null >> +++ b/drivers/crypto/dpaa2_sec/hw/rta.h > > ... > >> +extern enum rta_sec_era rta_sec_era; >> + >> +/** >> + * rta_set_sec_era - Set SEC Era HW block revision for which the RTA >> library >> + * will generate the descriptors. >> + * @era: SEC Era (enum rta_sec_era) >> + * >> + * Return: 0 if the ERA was set successfully, -1 otherwise (int) >> + * >> + * Warning 1: Must be called *only once*, *before* using any other RTA >> API >> + * routine. >> + * >> + * Warning 2: *Not thread safe*. >> + */ > >> +static inline int rta_set_sec_era(enum rta_sec_era era) >> +{ > > "static inline int" should go in a different line than the function name and parameters. > So it should be: > > static inline int > rta_set_sec_era(enum rta_sec_era era) > { > > Could you make this change here and in the rest of the functions? > > Thanks, > Pablo > > Ok, I will correct in the next version. Thanks, Akhil