From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 930BE95B0 for ; Mon, 7 Dec 2015 12:49:06 +0100 (CET) Received: by wmuu63 with SMTP id u63so136924679wmu.0 for ; Mon, 07 Dec 2015 03:49:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=lZl/mdhsrFZA+WF4BD3tG2USwdEYshFR6Z1HxlfN5XY=; b=I3gy+jZIsDbdqFD2nQQll5V1nQHm7sL+NT0aaLk0AtZyknNQ2eyQ7YaGw0iTiXulOT 6Nf1X+Fwsw+gmHI0gzpDGycMNMnHiH7AFqW4H/fiPqV60iF3Nysje1eNNMCK9O5LTHWy bLBU9WV9oLQylOKfUzy58G/5olsSSvdwPznK3j3C8sKqBTALMieMWDCUA3qtvzC9/bm2 xOe47p3flU1dt5NIBzEqE3m6m7gLt2d/Osa2aPAZAGjnz9hGsHDgzGEz1ZNih9TDsQA/ sDfkZ6I2cX+nkJtsAFukC1KXiP5rOW1WucS5vFV5kQR+HOodecDQvVQUvwOISYCyqXay 4j2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=lZl/mdhsrFZA+WF4BD3tG2USwdEYshFR6Z1HxlfN5XY=; b=Su7UPK8KDevCuqciefwXxVIxl+hvARFajAzoJGRp45sCSz6xeFiWP2dfbtpmBGV/x+ EuDBNd4u+DgnT0CuwbQCK1mykMKKSD8d2uO0X2qpKTpdlTqdpyR2kW9CBsTicsNQcqjo 1aR1Ga3/Uvpuong7DMZK8ztYKUqCtCJgN8FbCExmx64x/DecShWFKlyADut2jkRla/mj 3RpP1aiaSHo1r74Nhm91iK+FnFt3sd+gj0I8gQmVEZ70rDtnMYYcS0vUeu+drGS+t2BK 4fpiAEtSuqkOBAMH7jYkVqIlVBYtzdutVCH9J+P7SoR7Q5YKrfEChpr4+U9Uzk8Ohm9w UEeg== X-Gm-Message-State: ALoCoQk6cvllsu07+kqi5D96MVIfPVrXPd73NB6SqHdEkrXyaUsCGZnytDBlzMtUsCVX6bsbB8Wp X-Received: by 10.194.142.203 with SMTP id ry11mr32024218wjb.132.1449488946473; Mon, 07 Dec 2015 03:49:06 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id m11sm16316389wma.5.2015.12.07.03.49.05 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 07 Dec 2015 03:49:05 -0800 (PST) From: Thomas Monjalon To: Panu Matilainen Date: Mon, 07 Dec 2015 12:47:53 +0100 Message-ID: <3959911.rhgNy1YhGd@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <56654454.3040508@redhat.com> References: <20151124085001.58817bf0@miho> <4623746.AUJoGgWqRB@xps13> <56654454.3040508@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] mk: pass EXTRA_CFLAGS to AUTO_CPUFLAGS to enable local modifications X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2015 11:49:06 -0000 2015-12-07 10:33, Panu Matilainen: > On 12/04/2015 08:53 PM, Thomas Monjalon wrote: > >>>> We have encountered a CPU where the AES-NI instruction set is disabled > >>>> due to export restrictions. Since the build machine and target machine > >>>> is different, using -native configs doesn't work, and on this CPU, the > >>>> application refuses to run due to the AES CPU flags being amiss. > >>>> > >>>> The patch passes EXTRA_CFLAGS to the figure-out-cpu-flags helper, > >>>> which allows us to add -mno-aes to the compile flags and resolve this > >>>> problem. > >>>> > >>>> Signed-off-by: Simon Kagstrom > >> > >> Acked-by: Olivier Matz > > > > Applied, thanks > > > > This causes some complications on Fedora/RHEL due to fairly complex > interactions with -Werror, -Wall and -Wformat-security mixup between > upstream- and distro default compiler flags. > > More specifically, when EXTRA_CFLAGS contains warning flag manipulation > this patch can cause mismatch between other options that are okay > elsewhere in dpdk make. A simple fix is to pass WERROR_FLAGS to > AUTO_CPUFLAGS too to counter this, ie > > diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk > index c6bb8de..28f203b 100644 > --- a/mk/rte.cpuflags.mk > +++ b/mk/rte.cpuflags.mk > @@ -33,7 +33,7 @@ > # used to set the RTE_CPUFLAG_* environment variables giving details > # of what instruction sets the target cpu supports. > > -AUTO_CPUFLAGS := $(shell $(CC) $(MACHINE_CFLAGS) $(EXTRA_CFLAGS) -dM -E > - < /dev/null) > +AUTO_CPUFLAGS := $(shell $(CC) $(MACHINE_CFLAGS) $(WERROR_FLAGS) > $(EXTRA_CFLAGS) -dM -E - < /dev/null) > > # adding flags to CPUFLAGS > > > I can send an official patch if this seems acceptable. Yes this is acceptable. Please explain the error you see in the commit message.