From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f179.google.com (mail-we0-f179.google.com [74.125.82.179]) by dpdk.org (Postfix) with ESMTP id 7BFC1594F for ; Tue, 10 Jun 2014 12:02:28 +0200 (CEST) Received: by mail-we0-f179.google.com with SMTP id w62so2774440wes.10 for ; Tue, 10 Jun 2014 03:02:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=FMlQLMU6fRfunmSsPDfhJOlSfXci7NLjUJo9qIyX8gY=; b=I4WEYhpn1p9ZsKkXUt/hfTSU0a1No2807yKmQ7HxCB0NMnmM9R4fVXlGAuwNcvhf11 oBQnjHk1F0prunnO6beoGDX5vR0g2QXBsRXbKTxZhXmWKzaDrxGY3mEaxVOhTuuMlzCO X0EdIQKgi7w3LFXYs5r797uWWFXPoZzB5AqweIBaPkpziJ4erZ3QJNxQbXjtIz7kU2GR i0JbFuGSlXsO2XqlDwx2G9FdYEEsCOldCd0PB5i54Pv3uMEMDmJFxWTiyXXlI2btZR+B dT3FgrIZ3jU4fbpRobGZrbSl6JHf0uYqdPe8/DQyayAdgaIxkQdxK6YfhVfwkT8OQNLE Bl4A== X-Gm-Message-State: ALoCoQn5Pwv3xJjCYsPa2nvTPhAgNVQ7MFNw3w3J4glUOCDKuwEbvl4amXYSKR2O8VzRR7HaFb4P X-Received: by 10.194.110.71 with SMTP id hy7mr39942105wjb.23.1402394562799; Tue, 10 Jun 2014 03:02:42 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id f7sm28846648wjy.24.2014.06.10.03.02.41 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Jun 2014 03:02:42 -0700 (PDT) From: Thomas Monjalon To: Helin Zhang Date: Tue, 10 Jun 2014 12:02:43 +0200 Message-ID: <3962139.NISuUL0v1x@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.4-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <1402303135-28248-1-git-send-email-helin.zhang@intel.com> References: <1402303135-28248-1-git-send-email-helin.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] kni: fix compile errors on Oracle Linux6.4 and RHEL6.5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jun 2014 10:02:28 -0000 Hi Helin, 2014-06-09 16:38, Helin Zhang: > #if ( LINUX_VERSION_CODE < KERNEL_VERSION(3,5,0) ) > #define skb_tx_timestamp(skb) do {} while (0) > -#if !(RHEL_RELEASE_CODE && RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(6,4)) > -static inline bool ether_addr_equal(const u8 *addr1, const u8 *addr2) > +#ifndef ether_addr_equal It should be always true as it is a function (not known by the preprocessor). > +static inline bool __kc_ether_addr_equal(const u8 *addr1, const u8 *addr2) > { > return !compare_ether_addr(addr1, addr2); > } > -#endif > +#define ether_addr_equal(_addr1, _addr2) __kc_ether_addr_equal((_addr1),(_addr2)) > +#endif /* __kc_ether_addr_equal*/ So it is always replacing ether_addr_equal() by a kcompat equivalent for old kernels, even if ether_addr_equal() is already defined as a C function. Just to confirm: is it really what we want? [...] > -#endif > +#define ethtool_adv_to_mmd_eee_adv_t(adv) \ > +__kc_ethtool_adv_to_mmd_eee_adv_t(adv) An indentation is missing here. > +#endif /* ethtool_adv_to_mmd_eee_adv_t */ > +#endif /* */ Why an empty comment? Thanks -- Thomas