From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 871E2A0542; Thu, 26 May 2022 12:24:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6CB7A427EE; Thu, 26 May 2022 12:24:55 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id D04844280B; Thu, 26 May 2022 12:24:51 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 8821F5C009C; Thu, 26 May 2022 06:24:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 26 May 2022 06:24:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1653560690; x= 1653647090; bh=MutW4NxNvY4GTCQV/bUJbkzpIZFRR6uhzYhOOr2x5h0=; b=y jsRQKMMZcuj6zO4kfyJ6wOOAZ0/RObS0tFuc8NLSuQTUNqiIb8ytfgqMzk+h2BUy NU36SBZqjdcdWFWP/HUSIqoTk/4w9PG/aWO2VJIt+ISeq8AxA2D8XD1g42MZ8TVk SXmFt2I/kIGmxL7z1PeANKvgnLNEkz7miOvoO+YqYdu3ywxC7Sd/abxWIAeFjngm NFG/4t/9oZKVtF1LlQwHNhLc1yHdIrM4IIgWegH3qbrHIUASiOL1nN+dk521DYYi xhCYJGW7lCN62L3JdQPsvkIaX49/h7mGVc/QKFahoMdSWRtgr7hmn4lY+r37zLFP BsIGW0WmbmkVWmoBqQcyw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653560690; x= 1653647090; bh=MutW4NxNvY4GTCQV/bUJbkzpIZFRR6uhzYhOOr2x5h0=; b=b vis2BSL716HrpNT5AJBgM4rpEhWJqqo0ykCVZVtV8SfhDJgVnUbbfNSHFZ4HlW5Q 03ns6TGsbK1j8TtQ0AtEuaftulknK9eBj+es+X8BCK+Whbskg4az+dMa0vjexcn2 +YjtLzaqphWx4ridnoOsQnWMtOkr/x/Zu+5clVu8AUI3wDJqgvcmWbVGbqiRwtGV f248o9V9u3O+aM4OXM7oNuLVMbmit/u7Qil/QdriwXjsFBgxDhMFbAgFJxSU2bFR VgU+MPSJR5dWbWj7JH7AZV/l8KFr3TX3qI888UklkvWSkWLlR5X86lIy7vtg2LiD 0HBCCp+n/QkgsqDJhTEnw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjeejgddviecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvd elteeufeefheeujefgueetfedttdeikefgkeduhedtgfenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrd hnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 26 May 2022 06:24:49 -0400 (EDT) From: Thomas Monjalon To: Ray Kinsella , Tyler Retzlaff Cc: dev@dpdk.org, david.marchand@redhat.com, techboard@dpdk.org, David Christensen Subject: Re: [PATCH] eal/ppc: undefine AltiVec keyword vector Date: Thu, 26 May 2022 12:18:59 +0200 Message-ID: <3966769.zXnORWrf4K@thomas> In-Reply-To: <20220525183459.GA24690@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20220525095307.675312-1-thomas@monjalon.net> <878rqpze0j.fsf@mdr78.vserver.site> <20220525183459.GA24690@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 25/05/2022 20:34, Tyler Retzlaff: > On Wed, May 25, 2022 at 07:02:52PM +0100, Ray Kinsella wrote: > > Thomas Monjalon writes: > > > 25/05/2022 13:48, Ray Kinsella: > > >> Thomas Monjalon writes: > > >> > > >> > The AltiVec header file is defining "vector", except in C++ build. > > >> > The keyword "vector" may conflict easily. > > >> > As a rule, it is better to use the alternative keyword "__vector". > > >> > > > >> > The DPDK header file rte_altivec.h takes care of undefining "vector", > > >> > so the applications and dependencies are free to define the name "vector". > > >> > > > >> > This is a compatibility breakage for applications which were using > > >> > the keyword "vector" for its AltiVec meaning. > > >> > > > >> > Signed-off-by: Thomas Monjalon > > >> > --- > > >> > doc/guides/rel_notes/release_22_07.rst | 5 +++++ > > >> > lib/eal/ppc/include/rte_altivec.h | 7 +++++++ > > >> > 2 files changed, 12 insertions(+) > > >> > > > >> > > >> Acked-by: Ray Kinsella > > > > > > Just to make sure, we are all OK to break compatibility of rte_altivec.h? > > > It means the keyword vector is not available anymore with this #include. > > > Please confirm it is OK to merge in DPDK 22.07. > > > > I did think about it yes ;-). > > I can't see how it would break the ABI in the short term. > > And it makes sense to preclude this keyword in the long term. > > > > So I ack'ed - did I miss something? > > Acked-by: Tyler Retzlaff > > double ack, impact of break is understood as follows. > > * this is not an issue with abi it is an issue with api. > * the break will cause a compile failure, the action to resolve is to > replace vector with __vector. Exactly I'll wait few days or acks from the techboard, and will apply.